Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Commit a2aa284

Browse files
author
Marcel Gerber
committed
Merge remote-tracking branch 'upstream/master' into sprint-to-release
Conflicts: appshell/version.rc installer/mac/buildInstaller.sh installer/win/brackets-win-install-build.xml
2 parents 8e61e03 + 4f82c24 commit a2aa284

File tree

7 files changed

+15
-9
lines changed

7 files changed

+15
-9
lines changed

appshell/client_handler.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,8 +353,13 @@ void ClientHandler::SendOpenFileCommand(CefRefPtr<CefBrowser> browser, const Cef
353353
std::string fileArrayStr(fileArray);
354354
// FIXME: Use SendJSCommand once it supports parameters
355355
std::string cmd = "require('command/CommandManager').execute('file.openDroppedFiles'," + fileArrayStr + ")";
356-
browser->GetMainFrame()->ExecuteJavaScript(CefString(cmd.c_str()),
356+
357+
// if files are droppend and the Open Dialog is visible, then browser is NULL
358+
// This fixes https://github.com/adobe/brackets/issues/7752
359+
if (browser) {
360+
browser->GetMainFrame()->ExecuteJavaScript(CefString(cmd.c_str()),
357361
browser->GetMainFrame()->GetURL(), 0);
362+
}
358363
}
359364

360365
void ClientHandler::DispatchCloseToNextBrowser()

appshell/mac/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
<key>CFBundleSignature</key>
2020
<string>????</string>
2121
<key>CFBundleVersion</key>
22-
<string>0.43.0</string>
22+
<string>0.44.0</string>
2323
<key>CFBundleShortVersionString</key>
24-
<string>0.43.0</string>
24+
<string>0.44.0</string>
2525
<key>NSMainNibFile</key>
2626
<string>MainMenu</string>
2727
<key>NSPrincipalClass</key>

appshell/version.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
3232
//
3333

3434
VS_VERSION_INFO VERSIONINFO
35-
FILEVERSION 0,43,0,0
35+
FILEVERSION 0,44,0,0
3636
/* PRODUCTVERSION 1,0,0,0 */
3737
FILEOS VOS__WINDOWS32
3838
FILETYPE VFT_APP
@@ -43,7 +43,7 @@ BEGIN
4343
BEGIN
4444
VALUE "CompanyName", "brackets.io\0"
4545
VALUE "FileDescription", "\0"
46-
VALUE "FileVersion", "Release 43\0"
46+
VALUE "FileVersion", "Release 44\0"
4747
VALUE "ProductName", APP_NAME "\0"
4848
VALUE "ProductVersion", "\0"
4949
VALUE "LegalCopyright", "(c) 2012 Adobe Systems, Inc.\0"

installer/linux/debian/brackets.desktop

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@ Categories=Development
55
Exec=/opt/brackets/brackets %U
66
Icon=brackets
77
MimeType=text/html;
8+
Keywords=Text;Editor;Write;Web;Development;

installer/mac/buildInstaller.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# config
44
releaseName="Brackets"
5-
dmgName="${releaseName} Release 43"
5+
dmgName="${releaseName} Release 44"
66
format="bzip2"
77
encryption="none"
88
tmpLayout="./dropDmgConfig/layouts/tempLayout"

installer/win/brackets-win-install-build.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ default="build.mul">
1111
<!-- Product & version labeling -->
1212
<!-- See also: product name definitions in Brackets_<locale>.wxl -->
1313
<property name="product.shortname" value="Brackets"/>
14-
<property name="product.release.number" value="43"/>
14+
<property name="product.release.number" value="44"/>
1515
<property name="product.version.number" value="0.${product.release.number}"/>
1616
<property name="product.version.name" value="Release ${product.release.number}"/>
1717
<property name="product.fullname" value="Brackets ${product.version.name}"/>

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "Brackets-Shell",
3-
"version": "0.43.0-0",
3+
"version": "0.44.0-0",
44
"homepage": "http://brackets.io",
55
"issues": {
66
"url": "http://github.com/adobe/brackets-shell/issues"
@@ -28,4 +28,4 @@
2828
"install": "",
2929
"postinstall": "bash -c 'mv .appshell.gyp appshell.gyp;'"
3030
}
31-
}
31+
}

0 commit comments

Comments
 (0)