Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Commit a99ea81

Browse files
committed
enable yosemite traffic lights on yosemite
1 parent 0736837 commit a99ea81

File tree

2 files changed

+56
-15
lines changed

2 files changed

+56
-15
lines changed

appshell/cefclient_mac.mm

Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -221,16 +221,35 @@ -(void)windowTitleDidChange:(NSString*)title {
221221
#endif
222222
}
223223

224+
-(BOOL)isRunningOnYosemite {
225+
NSDictionary * dict = [NSDictionary dictionaryWithContentsOfFile:@"/System/Library/CoreServices/SystemVersion.plist"];
226+
NSString *version = [dict objectForKey:@"ProductVersion"];
227+
return ([version hasPrefix:@"10.10"]);
228+
}
229+
224230
- (BOOL)isFullScreenSupported {
225-
SInt32 version;
226-
Gestalt(gestaltSystemVersion, &version);
227-
return (version >= 0x1070);
231+
// Return False on Yosemite so we
232+
// don't draw our own full screen button
233+
// and handle full screen mode
234+
if (![self isRunningOnYosemite]) {
235+
SInt32 version;
236+
Gestalt(gestaltSystemVersion, &version);
237+
return (version >= 0x1070);
238+
}
239+
return false;
228240
}
229241

230242
-(BOOL)needsFullScreenActivateHack {
231-
SInt32 version;
232-
Gestalt(gestaltSystemVersion, &version);
233-
return (version >= 0x1090);
243+
if (![self isRunningOnYosemite]) {
244+
SInt32 version;
245+
Gestalt(gestaltSystemVersion, &version);
246+
return (version >= 0x1090);
247+
}
248+
return false;
249+
}
250+
251+
-(BOOL)useSystemTrafficLights {
252+
return [self isRunningOnYosemite];
234253
}
235254

236255
-(void)windowDidResize:(NSNotification *)notification
@@ -299,7 +318,7 @@ -(void)initUI:(NSWindow*)mainWindow {
299318
NSButton *windowButton = nil;
300319

301320
#ifdef CUSTOM_TRAFFIC_LIGHTS
302-
if (!trafficLightsView) {
321+
if (![self useSystemTrafficLights] && !trafficLightsView) {
303322
windowButton = [mainWindow standardWindowButton:NSWindowCloseButton];
304323
[windowButton setHidden:YES];
305324
windowButton = [mainWindow standardWindowButton:NSWindowMiniaturizeButton];

appshell/client_handler_mac.mm

Lines changed: 30 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -165,17 +165,37 @@ - (void)setIsReallyClosing {
165165
isReallyClosing = true;
166166
}
167167

168-
- (BOOL)isFullScreenSupported {
169-
SInt32 version;
170-
Gestalt(gestaltSystemVersion, &version);
171-
return (version >= 0x1070);
168+
//
169+
-(BOOL)isRunningOnYosemite {
170+
NSDictionary * dict = [NSDictionary dictionaryWithContentsOfFile:@"/System/Library/CoreServices/SystemVersion.plist"];
171+
NSString *version = [dict objectForKey:@"ProductVersion"];
172+
return ([version hasPrefix:@"10.10"]);
172173
}
173174

174175

176+
- (BOOL)isFullScreenSupported {
177+
// Return False on Yosemite so we
178+
// don't draw our own full screen button
179+
// and handle full screen mode
180+
if (![self isRunningOnYosemite]) {
181+
SInt32 version;
182+
Gestalt(gestaltSystemVersion, &version);
183+
return (version >= 0x1070);
184+
}
185+
return false;
186+
}
187+
175188
-(BOOL)needsFullScreenActivateHack {
176-
SInt32 version;
177-
Gestalt(gestaltSystemVersion, &version);
178-
return (version >= 0x1090);
189+
if (![self isRunningOnYosemite]) {
190+
SInt32 version;
191+
Gestalt(gestaltSystemVersion, &version);
192+
return (version >= 0x1090);
193+
}
194+
return false;
195+
}
196+
197+
-(BOOL)useSystemTrafficLights {
198+
return [self isRunningOnYosemite];
179199
}
180200

181201
-(void)setFullScreenButtonView:(NSView *)view {
@@ -186,6 +206,8 @@ -(void)setTrafficLightsView:(NSView *)view {
186206
trafficLightsView = view;
187207
}
188208

209+
210+
189211
-(void)windowTitleDidChange:(NSString*)title {
190212
#ifdef DARK_UI
191213
if (customTitlebar) {
@@ -237,7 +259,7 @@ - (void)initUI {
237259
NSButton* windowButton = nil;
238260

239261
#ifdef CUSTOM_TRAFFIC_LIGHTS
240-
if (!trafficLightsView) {
262+
if (![self useSystemTrafficLights] && !trafficLightsView) {
241263
windowButton = [theWin standardWindowButton:NSWindowCloseButton];
242264
[windowButton setHidden:YES];
243265
windowButton = [theWin standardWindowButton:NSWindowMiniaturizeButton];

0 commit comments

Comments
 (0)