few corrections in naming conventions

Author: Nitesh Kumar

src/extensions/default/OpenWithExternalEditor/main.js renamed to src/extensions/default/OpenWithExternalApplication/main.js

@@ -37,34 +37,36 @@ define(function (require, exports, module) {
      * @private
      * @type {string} fullPath of the OpenWithExternalEditor Domain implementation
      */
-    var _domainPath = ExtensionUtils.getModulePath(module, "node/OpenWithExternalEditorDomain");
+    var _domainPath = ExtensionUtils.getModulePath(module, "node/OpenWithExternalApplicationDomain");
 
     /**
      * @private
      * @type {NodeDomain}
      */
-    var _nodeDomain = new NodeDomain("OpenWithExternalEditor", _domainPath);
+    var _nodeDomain = new NodeDomain("OpenWithExternalApplication", _domainPath);
 
-    var extensionToExternalEditorMap = {};
+    var extensionToExtApplicationMap = {};
 
-    function _openInExternalEdior(event, path) {
+    function _openWithExternalApplication(event, path) {
         _nodeDomain.exec("open", {
             path: path,
-            app: extensionToExternalEditorMap[FileUtils.getFileExtension(path).toLowerCase()]
+            app: extensionToExtApplicationMap[FileUtils.getFileExtension(path).toLowerCase()]
         });
     }
 
-    PreferencesManager.definePreference("externalEditor", "object", {}, {
-        description: Strings.DESCRIPTION_EXTERNAL_EDITOR
+    PreferencesManager.definePreference("externalApplications", "object", {}, {
+        description: Strings.DESCRIPTION_EXTERNAL_APPLICATION_ASSOCIATE
     });
 
-    PreferencesManager.on("change", "externalEditor", function () {
-        extensionToExternalEditorMap = PreferencesManager.get("externalEditor");
+    PreferencesManager.on("change", "externalApplications", function () {
+        extensionToExtApplicationMap = PreferencesManager.get("externalApplications");
+        FileUtils.addExtensionToExternalAppList(Object.keys(extensionToExtApplicationMap));
     });
 
-    FileViewController.on("openInExternalEditor", _openInExternalEdior);
+    FileViewController.on("openWithExternalApplication", _openWithExternalApplication);
 
     AppInit.appReady(function () {
-        FileUtils.addExtensionToExternalAppList(Object.keys(extensionToExternalEditorMap));
+        extensionToExtApplicationMap = PreferencesManager.get("externalApplications");
+        FileUtils.addExtensionToExternalAppList(Object.keys(extensionToExtApplicationMap));
     });
 });

src/extensions/default/OpenWithExternalEditor/node/OpenWithExternalEditorDomain.js renamed to src/extensions/default/OpenWithExternalApplication/node/OpenWithExternalApplicationDomain.js

@@ -34,7 +34,7 @@ var _domainManager;
  *
  * @param {Object} params Object to use
  */
-function _OpenWithExternalEditor(params) {
+function _openWithExternalApplication(params) {
     var application =  "default" === params.app ? "": params.app;
     open(params.path, application);
 }
@@ -47,15 +47,15 @@ function _OpenWithExternalEditor(params) {
 function init(domainManager) {
     _domainManager = domainManager;
 
-    if (!domainManager.hasDomain("OpenWithExternalEditor")) {
-        domainManager.registerDomain("OpenWithExternalEditor", {major: 0, minor: 1});
+    if (!domainManager.hasDomain("OpenWithExternalApplication")) {
+        domainManager.registerDomain("OpenWithExternalApplication", {major: 0, minor: 1});
     }
     _domainManager.registerCommand(
-        "OpenWithExternalEditor",
+        "OpenWithExternalApplication",
         "open",
-        _OpenWithExternalEditor,
+        _openWithExternalApplication,
         true,
-        "open document with External Editor.",
+        "open document with External Application.",
         [{
             name: "params",
             type: "object",

src/extensions/default/OpenWithExternalEditor/node/package.json renamed to src/extensions/default/OpenWithExternalApplication/node/package.json

@@ -1,5 +1,5 @@
 {
-  "name": "brackets-open-external_editor",
+  "name": "brackets-open-external_application",
   "dependencies": {
     "open": "0.0.5"
   }

src/file/FileUtils.js

@@ -537,7 +537,7 @@ define(function (require, exports, module) {
      *
      */
     function shouldOpenInExternalApplication(ext) {
-        return !extListToBeOpenedInExtApp.includes(ext);
+        return extListToBeOpenedInExtApp.includes(ext);
     }
 
     /**
@@ -547,7 +547,7 @@ define(function (require, exports, module) {
     function addExtensionToExternalAppList(ext) {
 
         if(typeof ext !== 'string') {
-            extListToBeOpenedInExtApp.concat(ext);
+            extListToBeOpenedInExtApp = ext;
         } else {
             extListToBeOpenedInExtApp.push(ext);
         }

src/nls/root/strings.js

@@ -906,5 +906,5 @@ define({
     "REMOTE_DEBUGGING_PORT_INVALID"                  : "Cannot enable remote debugging on port {0}. Port numbers should be between {1} and {2}.",
 
     //Associate File Type to External App
-    "DESCRIPTION_EXTERNAL_EDITOR"                    : "Add File type association to external App here"
+    "DESCRIPTION_EXTERNAL_APPLICATION_ASSOCIATE"     : "Add File type association to external App here"
 });

src/project/FileTreeView.js

@@ -576,7 +576,7 @@ define(function (require, exports, module) {
                 if (FileUtils.shouldOpenInExternalApplication(
                         FileUtils.getFileExtension(this.myPath()).toLowerCase()
                       )) {
-                    this.props.actions.openInExternalEditor(this.myPath());
+                    this.props.actions.openWithExternalApplication(this.myPath());
                     return;
                 }
                 this.props.actions.selectInWorkingSet(this.myPath());

src/project/FileViewController.js

@@ -229,8 +229,8 @@ define(function (require, exports, module) {
     /**
      * Opens the specified document with its associated external editor,
      */
-    function openInExternalEditor(fullPath) {
-        exports.trigger("openInExternalEditor", fullPath);
+    function openWithExternalApplication(fullPath) {
+        exports.trigger("openWithExternalApplication", fullPath);
     }
 
     /**
@@ -282,5 +282,5 @@ define(function (require, exports, module) {
     exports.setFileViewFocus = setFileViewFocus;
     exports.WORKING_SET_VIEW = WORKING_SET_VIEW;
     exports.PROJECT_MANAGER = PROJECT_MANAGER;
-    exports.openInExternalEditor = openInExternalEditor;
+    exports.openWithExternalApplication = openWithExternalApplication;
 });

src/project/ProjectManager.js

@@ -281,10 +281,10 @@ define(function (require, exports, module) {
     };
 
     /**
-     * See `FileViewController.openInExternalEditor`
+     * See `FileViewController.openWithExternalApplication`
      */
-    ActionCreator.prototype.openInExternalEditor = function (path) {
-        FileViewController.openInExternalEditor(path);
+    ActionCreator.prototype.openWithExternalApplication = function (path) {
+        FileViewController.openWithExternalApplication(path);
     };