Addressing review comments

g-217 · g-217 · commit e0ea84ebb6c3 · 2019-12-06T14:29:01.000+05:30
diff --git a/src/brackets.config.dist.json b/src/brackets.config.dist.json
@@ -3,7 +3,7 @@
     "analyticsDataServerURL"  : "https://cc-api-data.adobe.io/ingest",
     "serviceKey"              : "brackets-service",
     "environment"             : "production",
-    "update_info_url"         : "https://getupdates.brackets.io/getupdates/",
+    "update_info_url"         : "https://getupdates.brackets.io/getupdates?locale=<locale>",
     "notification_info_url"   : "https://getupdates.brackets.io/getnotifications?locale=<locale>",
     "buildtype"               : "production"
 }
diff --git a/src/utils/UpdateNotification.js b/src/utils/UpdateNotification.js
@@ -115,7 +115,7 @@ define(function (require, exports, module) {
             locale = locale.substring(0, 2);
         }
 
-        return brackets.config.update_info_url + '?locale=' + locale;
+        return brackets.config.update_info_url.replace('<locale>', locale || 'en');
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`"analyticsDataServerURL" : "https://cc-api-data.adobe.io/ingest",`
`4`	`4`	`"serviceKey" : "brackets-service",`
`5`	`5`	`"environment" : "production",`
`6`		`- "update_info_url" : "https://getupdates.brackets.io/getupdates/",`
	`6`	`+ "update_info_url" : "https://getupdates.brackets.io/getupdates?locale=<locale>",`
`7`	`7`	`"notification_info_url" : "https://getupdates.brackets.io/getnotifications?locale=<locale>",`
`8`	`8`	`"buildtype" : "production"`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ define(function (require, exports, module) {`
`115`	`115`	`locale = locale.substring(0, 2);`
`116`	`116`	`}`
`117`	`117`
`118`		`- return brackets.config.update_info_url + '?locale=' + locale;`
	`118`	`+ return brackets.config.update_info_url.replace('<locale>', locale \|\| 'en');`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`/**`