fix: capture failing version requests (#220)

Author: kptdobe

package-lock.json

@@ -51,6 +51,7 @@
     "*.cjs": "eslint"
   },
   "dependencies": {
+    "@adobe/helix-shared-process-queue": "3.1.3",
     "@aws-sdk/client-s3": "3.726.1",
     "@aws-sdk/s3-request-presigner": "^3.468.0",
     "@cloudflare/workers-types": "4.20251126.0",

package.json

@@ -9,21 +9,36 @@
  * OF ANY KIND, either express or implied. See the License for the specific language
  * governing permissions and limitations under the License.
  */
+import processQueue from '@adobe/helix-shared-process-queue';
 import getObject from '../object/get.js';
 import listObjects from '../object/list.js';
 
+const MAX_VERSIONS = 500;
+const CONCURRENCY = 50;
+
 export async function listObjectVersions(env, { bucket, org, key }) {
   const current = await getObject(env, { bucket, org, key }, true);
   if (current.status === 404 || !current.metadata.id) {
     return 404;
   }
-  const resp = await listObjects(env, { bucket, org, key: `.da-versions/${current.metadata.id}` }, 500);
-  const promises = await Promise.all(JSON.parse(resp.body).map(async (entry) => {
+  const resp = await listObjects(env, { bucket, org, key: `.da-versions/${current.metadata.id}` }, MAX_VERSIONS);
+  if (resp.status !== 200) {
+    return resp;
+  }
+  const list = JSON.parse(resp.body);
+
+  const versions = await processQueue(list, async (entry) => {
     const entryResp = await getObject(env, {
       bucket,
       org,
       key: `.da-versions/${current.metadata.id}/${entry.name}.${entry.ext}`,
     }, true);
+
+    if (entryResp.status !== 200 || !entryResp.metadata) {
+      // Some requests might fail for unknown reasons (system busy, etc.)
+      return undefined;
+    }
+
     const timestamp = parseInt(entryResp.metadata.timestamp || '0', 10);
     const users = JSON.parse(entryResp.metadata.users || '[{"email":"anonymous"}]');
     const { label, path } = entryResp.metadata;
@@ -38,11 +53,14 @@ export async function listObjectVersions(env, { bucket, org, key }) {
       };
     }
     return { users, timestamp, path };
-  }));
+  }, CONCURRENCY);
+
+  // Filter out undefined entries (failed requests)
+  const filteredVersions = versions.filter((version) => version !== undefined);
 
   return {
     status: resp.status,
     contentType: resp.contentType,
-    body: JSON.stringify(promises),
+    body: JSON.stringify(filteredVersions),
   };
 }