Skip to content

Commit 2fb0db2

Browse files
author
Alexandru Meterez
committed
Update docker and reqs
1 parent 847d1e6 commit 2fb0db2

File tree

5 files changed

+5
-7
lines changed

5 files changed

+5
-7
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ If you just want to clone and run the software, we have provided a Dockerfile. T
1919
```
2020
git clone https://github.com/adobe/frontend-regression-validator.git
2121
cd frontend-regression-validator/docker
22-
docker build -t fred .
22+
docker build --no-cache -t fred .
2323
docker run -p 5000:5000 -m 8g --memory-reservation=8g --oom-kill-disable=True --memory-swap 8G fred
2424
```
2525
If you still encounter issues with out of memory errors, allocate more memory from the UI Docker app. Simply click the Docker icon in your toolbar, go to `Preferences`-`Advanced` and then pull the slider to around `8GB`.

docker/Dockerfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ FROM pytorch/pytorch
33
# Installing build dependencies
44
RUN apt-get update && apt-get install -y git curl unzip
55

6+
RUN apt-get install -y xorg
7+
68
# Prepare environment UTF-8
79
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y locales
810
RUN sed -i -e 's/# en_US.UTF-8 UTF-8/en_US.UTF-8 UTF-8/' /etc/locale.gen && \
@@ -22,8 +24,5 @@ RUN /opt/conda/bin/activate base && python3 -m pip install -r /work/frontend-reg
2224
# Extract the model files
2325
RUN cd /work/frontend-regression-validator/fred/inference && cat model_files.bz2.parta* > model_files.bz2 && tar xjf model_files.bz2
2426

25-
# Install JDK for proxy
26-
RUN apt-get install -y openjdk-8-jdk
27-
2827
# Start notebook
2928
CMD cd /work/frontend-regression-validator/fred && git pull && python3 run.py

fred/crawler/crawler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def set(self, source):
1414

1515

1616
async def get_page(test_page, url):
17-
browser = await launch()
17+
browser = await launch({'args': ['--disable-dev-shm-usage', '--no-sandbox']})
1818
page = await browser.newPage()
1919
await page.goto(url)
2020
out = await page.content()

fred/data/collect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ async def intercept_console(response):
1616

1717

1818
async def collect_msgs_and_screenshot(url, ss_path):
19-
browser = await launch()
19+
browser = await launch({'args': ['--disable-dev-shm-usage', '--no-sandbox']})
2020
page = await browser.newPage()
2121

2222
page.on('response', intercept_network_response)

requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,5 @@ torch==1.2.0
77
Flask_Cors==3.0.8
88
numpy==1.17.1
99
Pillow==6.1.0
10-
browsermob_proxy==0.8.0
1110
beautifulsoup4==4.8.0
1211
pyppeteer==0.0.25

0 commit comments

Comments
 (0)