fix: handle secret store race conditions and normalize names

- Add .toLowerCase() to Cloudflare worker and KV namespace names
- Add duplicate handling for Fastly secret store creation race condition
- Remove explicit package.name override from edge integration test

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Signed-off-by: Lars Trieloff <[email protected]>

Author: claude

src/CloudflareDeployer.js

@@ -38,13 +38,14 @@ export default class CloudflareDeployer extends BaseDeployer {
   get fullFunctionName() {
     return `${this.cfg.packageName}--${this.cfg.name}`
       .replace(/\./g, '_')
-      .replace('@', '_');
+      .replace('@', '_')
+      .toLowerCase();
   }
 
   async deploy() {
     const body = fs.readFileSync(this.cfg.edgeBundle);
     const settings = await this.getSettings();
-    const { id } = await this.createKVNamespace(`${this.cfg.packageName}--secrets`);
+    const { id } = await this.createKVNamespace(`${this.cfg.packageName}--secrets`.toLowerCase());
 
     const metadata = {
       body_part: 'script',

src/ComputeAtEdgeDeployer.js

@@ -123,10 +123,28 @@ service_id = ""
       this.log.debug('--: uploading package to fastly, service version', version);
       await this._fastly.writePackage(version, buf);
 
+      // Helper to get or create secret store with duplicate handling
+      const getOrCreateSecretStore = async (name) => {
+        try {
+          return await this._fastly.writeSecretStore(name);
+        } catch (error) {
+          if (error.message && error.message.includes('duplicate')) {
+            // Store was created between list and create, retry to get it
+            this.log.debug(`--: secret store ${name} already exists, fetching...`);
+            const stores = await this._fastly.readSecretStores();
+            const existing = stores.data?.data?.find((s) => s.name === name);
+            if (existing) {
+              return { data: existing };
+            }
+          }
+          throw error;
+        }
+      };
+
       // Get or create action secret store (for action-specific params)
       const actionStoreName = this.fullFunctionName;
       this.log.debug(`--: getting or creating action secret store: ${actionStoreName}`);
-      const actionStore = await this._fastly.writeSecretStore(actionStoreName);
+      const actionStore = await getOrCreateSecretStore(actionStoreName);
       const actionStoreId = actionStore.data.id;
       try {
         await this._fastly.writeResource(version, actionStoreId, 'action_secrets');
@@ -141,7 +159,7 @@ service_id = ""
       // Get or create package secret store (for package-wide params)
       const packageStoreName = this.cfg.packageName;
       this.log.debug(`--: getting or creating package secret store: ${packageStoreName}`);
-      const packageStore = await this._fastly.writeSecretStore(packageStoreName);
+      const packageStore = await getOrCreateSecretStore(packageStoreName);
       const packageStoreId = packageStore.data.id;
       try {
         await this._fastly.writeResource(version, packageStoreId, 'package_secrets');

test/edge-integration.test.js

@@ -71,7 +71,6 @@ describe('Edge Integration Test', () => {
         // Fastly config
         '--compute-service-id', fastlyServiceID,
         '--compute-test-domain', fastlyTestDomain,
-        '--package.name', 'Test',
         '--fastly-gateway', 'deploy-test.anywhere.run',
         '--fastly-service-id', '4u8SAdblhzzbXntBYCjhcK',
         // Shared config