Skip to content

Commit 04c224c

Browse files
Anuragtech02LFDanLusnowystinger
authored
removed e.stopPropagation() from onKeyDown (#2354)
* removed e.stopPropagation() from onKeyDown * added check if propgation has already been stopped * added test for isPropagationStopped * removed stopPropagation completely, also removed the test Co-authored-by: Daniel Lu <[email protected]> Co-authored-by: Robert Snow <[email protected]>
1 parent d6b4706 commit 04c224c

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

packages/@react-aria/menu/src/useMenuTrigger.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,10 @@ export function useMenuTrigger(props: MenuTriggerAriaProps, state: MenuTriggerSt
5656
case 'Enter':
5757
case ' ':
5858
e.preventDefault();
59-
e.stopPropagation();
6059
state.toggle('first');
6160
break;
6261
case 'ArrowUp':
6362
e.preventDefault();
64-
e.stopPropagation();
6563
state.toggle('last');
6664
break;
6765
}

packages/@react-aria/menu/test/useMenuTrigger.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ describe('useMenuTrigger', function () {
114114
expect(setOpen).toHaveBeenCalledTimes(0);
115115
expect(setFocusStrategy).toHaveBeenCalledTimes(0);
116116

117-
// triggers event if defaultPrevented is not true and it matches one of the keys
117+
// triggers event if defaultPrevented is not true and it matches one of the keys
118118
menuTriggerProps.onKeyDown({
119119
pointerType: 'not keyboard',
120120
defaultPrevented: false,

0 commit comments

Comments
 (0)