Skip to content

Commit 06cdad7

Browse files
unionalreidbarberyihuiliaosnowystinger
authored
docs: add contributing Q & A section (#6951)
* docs: add contributing Q & A section * Update CONTRIBUTING.md Try without specifying language * Apply suggestions from code review Co-authored-by: Robert Snow <[email protected]> --------- Co-authored-by: Reid Barber <[email protected]> Co-authored-by: Yihui Liao <[email protected]> Co-authored-by: Robert Snow <[email protected]>
1 parent 0d0e21b commit 06cdad7

File tree

1 file changed

+39
-0
lines changed

1 file changed

+39
-0
lines changed

CONTRIBUTING.md

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,45 @@ yarn start:docs
153153
```
154154
Then, open [http://localhost:1234](http://localhost:1234) in your browser.
155155

156+
### Q & A
157+
158+
> `yarn build` emits a bunch of type errors?
159+
160+
Here are a few examples:
161+
162+
```
163+
@parcel/transformer-typescript-types: Property 'style' does not exist on type 'Element'.
164+
@parcel/transformer-typescript-types: Property 'type' does not exist on type 'EventTarget'.
165+
@parcel/transformer-typescript-types: Property 'isContentEditable' does not exist on type 'EventTarget'
166+
```
167+
168+
Yes, [that's normal](https://github.com/adobe/react-spectrum/issues/6937#issuecomment-2311492647).
169+
It will complete successfully at the end.
170+
171+
> `yarn build` fails.
172+
173+
```
174+
parcel build packages/@react-{spectrum,aria,stately}/*/ packages/@internationalized/{message,string,date,number}/ packages/react-aria-components --no-optimize --config .parcelrc-build
175+
libc++abi: terminating due to uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument
176+
make: *** [build] Abort trap: 6
177+
parcel build packages/@react-{spectrum,aria,stately}/*/ packages/@internationalized/{message,string,date,number}/ packages/react-aria-components --no-optimize --config .parcelrc-build
178+
make: *** [build] Segmentation fault: 11
179+
```
180+
181+
It's likely that you are using a different version of Node.js. Please use Node.js 18. When changing the node version, delete `node_modules` and re-run `yarn install`
182+
183+
> `yarn start` fails.
184+
185+
For example:
186+
187+
```
188+
@parcel/core: packages/@react-aria/virtualizer/src/index.ts does not export 'useVirtualizer'
189+
```
190+
191+
You may have run `yarn build` before. Please run `make clean_all && yarn` to clean up the build artifacts.
192+
193+
It may also just be a stale cache, you can try deleting the `.parcel-cache`
194+
156195
## Contributor to committer
157196

158197
We love contributions from our community! If you'd like to go a step beyond contributor and become a committer with full write access and a say in the project, you must be invited. The existing committers employ an internal nomination process that must reach lazy consensus (silence is approval) before invitations are issued. If you feel you are qualified and want to get more deeply involved, feel free to reach out to existing committers to have a conversation.

0 commit comments

Comments
 (0)