Skip to content

Commit 087eed9

Browse files
committed
Merge branch 'upgrade-sb-8-2' into upgrade-sb-9
# Conflicts: # package.json # yarn.lock
2 parents 27aa046 + 576f0c4 commit 087eed9

File tree

26 files changed

+738
-170
lines changed

26 files changed

+738
-170
lines changed

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,12 @@
101101
"@react-spectrum/s2-icon-builder": "^0.2.0",
102102
"@spectrum-css/component-builder": "workspace:^",
103103
"@spectrum-css/vars": "^2.3.0",
104-
"@storybook/addon-a11y": "^9.0.0",
105-
"@storybook/addon-docs": "^9.0.0",
106-
"@storybook/addon-jest": "^9.0.0",
107-
"@storybook/addon-onboarding": "^9.0.0",
108-
"@storybook/addon-themes": "^9.0.0",
109-
"@storybook/react": "^9.0.0",
104+
"@storybook/addon-a11y": "^9.0.4",
105+
"@storybook/addon-docs": "^9.0.4",
106+
"@storybook/addon-jest": "^9.0.4",
107+
"@storybook/addon-onboarding": "^9.0.4",
108+
"@storybook/addon-themes": "^9.0.4",
109+
"@storybook/react": "^9.0.4",
110110
"@storybook/test-runner": "^0.22.0",
111111
"@stylistic/eslint-plugin-ts": "^2.9.0",
112112
"@swc/core": "^1.3.36",
@@ -188,7 +188,7 @@
188188
"rimraf": "^2.6.3",
189189
"sharp": "^0.33.5",
190190
"sinon": "^7.3.1",
191-
"storybook": "^9.0.0",
191+
"storybook": "^9.0.4",
192192
"storybook-dark-mode": "patch:storybook-dark-mode@npm%3A4.0.2#~/.yarn/patches/storybook-dark-mode-npm-4.0.2-1acb0927fb.patch",
193193
"storybook-react-parcel": "workspace:^",
194194
"tailwind-variants": "patch:tailwind-variants@npm%3A0.3.1#~/.yarn/patches/tailwind-variants-npm-0.3.1-48888516de.patch",

packages/@react-spectrum/s2/src/ContextualHelp.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ export interface ContextualHelpProps extends
4141

4242
const popover = style({
4343
fontFamily: 'sans',
44-
minWidth: 218,
45-
width: 218,
44+
minWidth: 268,
45+
width: 268,
4646
padding: 24
4747
});
4848

packages/@react-spectrum/s2/src/Tabs.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -213,24 +213,25 @@ function TabListInner<T extends object>(props: TabListProps<T>) {
213213
style={props.UNSAFE_style}
214214
className={(props.UNSAFE_className || '') + style({position: 'relative'}, getAllowedOverrides())(null, props.styles)}>
215215
{orientation === 'vertical' &&
216-
<TabLine disabledKeys={disabledKeys} isDisabled={isDisabled} selectedTab={selectedTab} orientation={orientation} density={density} />}
216+
<TabLine disabledKeys={disabledKeys} isDisabled={isDisabled} selectedTab={selectedTab} orientation={orientation} tabList={props} density={density} />}
217217
<RACTabList
218218
{...props}
219219
aria-label={ariaLabel}
220220
aria-labelledby={ariaLabelledBy}
221221
ref={tablistRef}
222222
className={renderProps => tablist({...renderProps, labelBehavior, density})} />
223223
{orientation === 'horizontal' &&
224-
<TabLine disabledKeys={disabledKeys} isDisabled={isDisabled} selectedTab={selectedTab} orientation={orientation} density={density} />}
224+
<TabLine disabledKeys={disabledKeys} isDisabled={isDisabled} selectedTab={selectedTab} orientation={orientation} tabList={props} density={density} />}
225225
</div>
226226
);
227227
}
228228

229-
interface TabLineProps {
229+
interface TabLineProps<T extends object> {
230230
disabledKeys: Iterable<Key> | undefined,
231231
isDisabled: boolean | undefined,
232232
selectedTab: HTMLElement | undefined,
233233
orientation?: Orientation,
234+
tabList: TabListProps<T>,
234235
density?: 'compact' | 'regular'
235236
}
236237

@@ -265,12 +266,13 @@ const selectedIndicator = style<{isDisabled: boolean, orientation?: Orientation}
265266
transitionTimingFunction: 'in-out'
266267
});
267268

268-
function TabLine(props: TabLineProps) {
269+
function TabLine<T extends object>(props: TabLineProps<T>) {
269270
let {
270271
disabledKeys,
271272
isDisabled: isTabsDisabled,
272273
selectedTab,
273274
orientation,
275+
tabList,
274276
density
275277
} = props;
276278
let {direction} = useLocale();
@@ -314,7 +316,7 @@ function TabLine(props: TabLineProps) {
314316

315317
useLayoutEffect(() => {
316318
onResize();
317-
}, [onResize, state?.selectedItem?.key, density, direction, orientation]);
319+
}, [onResize, state?.selectedItem?.key, density, direction, orientation, tabList]);
318320

319321
return (
320322
<div style={{...style}} className={selectedIndicator({isDisabled, orientation})} />

0 commit comments

Comments
 (0)