fix conditional useHref call (#7032)

Co-authored-by: Abel John <[email protected]>
Co-authored-by: Robert Snow <[email protected]>
Co-authored-by: Daniel Lu <[email protected]>

Author: 3 people

packages/@react-aria/utils/src/openLink.tsx

@@ -148,8 +148,9 @@ function openSyntheticLink(target: Element, modifiers: Modifiers) {
 
 export function useSyntheticLinkProps(props: LinkDOMProps) {
   let router = useRouter();
+  const href = router.useHref(props.href ?? '');
   return {
-    'data-href': props.href ? router.useHref(props.href) : undefined,
+    'data-href': props.href ? href : undefined,
     'data-target': props.target,
     'data-rel': props.rel,
     'data-download': props.download,
@@ -172,8 +173,9 @@ export function getSyntheticLinkProps(props: LinkDOMProps) {
 
 export function useLinkProps(props: LinkDOMProps) {
   let router = useRouter();
+  const href = router.useHref(props?.href ?? '');
   return {
-    href: props?.href ? router.useHref(props?.href) : undefined,
+    href: props?.href ? href : undefined,
     target: props?.target,
     rel: props?.rel,
     download: props?.download,