Fix Combobox HCM non-disabled (#4493)

snowystinger · web-flow · commit 0b384e61ad6d · 2023-05-08T16:28:27.000-07:00
* Fix Combobox HCM non-disabled &amp; quiet field buttons
diff --git a/packages/@adobe/spectrum-css-temp/components/inputgroup/index.css b/packages/@adobe/spectrum-css-temp/components/inputgroup/index.css
@@ -140,7 +140,6 @@ governing permissions and limitations under the License.
 
   &.is-disabled {
     .spectrum-FieldButton {
-      border-bottom-width: 1px;
       border-radius: 0;
     }
   }
diff --git a/packages/@adobe/spectrum-css-temp/components/inputgroup/skin.css b/packages/@adobe/spectrum-css-temp/components/inputgroup/skin.css
@@ -66,7 +66,7 @@ governing permissions and limitations under the License.
     }
   }
 
-  &.is-disabled {
+  &.is-disabled:not(.spectrum-InputGroup--quiet) {
     .spectrum-FieldButton {
       &:before {
         border-color: transparent;
@@ -125,7 +125,17 @@ governing permissions and limitations under the License.
 
     &:disabled,
     &:disabled:hover {
-      border-color: var(--spectrum-textfield-quiet-border-color-disabled);
+      &:before {
+        border-color: var(--spectrum-textfield-quiet-border-color-disabled);
+      }
+    }
+  }
+
+  &.is-disabled {
+    .spectrum-FieldButton {
+      &:before {
+        border-color: var(--spectrum-textfield-quiet-border-color-disabled);
+      }
     }
   }
 
diff --git a/packages/@adobe/spectrum-css-temp/components/textfield/skin.css b/packages/@adobe/spectrum-css-temp/components/textfield/skin.css
@@ -171,6 +171,7 @@ governing permissions and limitations under the License.
 }
 @media (forced-colors: active) {
   .spectrum-Textfield-input {
+    --spectrum-textfield-border-color: CanvasText;
     --spectrum-textfield-text-color-disabled: GrayText;
     --spectrum-textfield-border-color-disabled: GrayText;
     --spectrum-textfield-quiet-border-color-disabled: GrayText;

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,6 @@ governing permissions and limitations under the License.`
`140`	`140`
`141`	`141`	`&.is-disabled {`
`142`	`142`	`.spectrum-FieldButton {`
`143`		`- border-bottom-width: 1px;`
`144`	`143`	`border-radius: 0;`
`145`	`144`	`}`
`146`	`145`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ governing permissions and limitations under the License.`
`66`	`66`	`}`
`67`	`67`	`}`
`68`	`68`
`69`		`- &.is-disabled {`
	`69`	`+ &.is-disabled:not(.spectrum-InputGroup--quiet) {`
`70`	`70`	`.spectrum-FieldButton {`
`71`	`71`	`&:before {`
`72`	`72`	`border-color: transparent;`
`@@ -125,7 +125,17 @@ governing permissions and limitations under the License.`
`125`	`125`
`126`	`126`	`&:disabled,`
`127`	`127`	`&:disabled:hover {`
`128`		`- border-color: var(--spectrum-textfield-quiet-border-color-disabled);`
	`128`	`+ &:before {`
	`129`	`+ border-color: var(--spectrum-textfield-quiet-border-color-disabled);`
	`130`	`+ }`
	`131`	`+ }`
	`132`	`+ }`
	`133`	`+`
	`134`	`+ &.is-disabled {`
	`135`	`+ .spectrum-FieldButton {`
	`136`	`+ &:before {`
	`137`	`+ border-color: var(--spectrum-textfield-quiet-border-color-disabled);`
	`138`	`+ }`
`129`	`139`	`}`
`130`	`140`	`}`
`131`	`141`
Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,7 @@ governing permissions and limitations under the License.`
`171`	`171`	`}`
`172`	`172`	`@media (forced-colors: active) {`
`173`	`173`	`.spectrum-Textfield-input {`
	`174`	`+ --spectrum-textfield-border-color: CanvasText;`
`174`	`175`	`--spectrum-textfield-text-color-disabled: GrayText;`
`175`	`176`	`--spectrum-textfield-border-color-disabled: GrayText;`
`176`	`177`	`--spectrum-textfield-quiet-border-color-disabled: GrayText;`