Skip to content

Commit 10acc69

Browse files
authored
chore: propagate user provided dependecies for S2 Combobox and Picker (#8340)
1 parent 842a44d commit 10acc69

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

packages/@react-spectrum/s2/src/ComboBox.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export interface ComboBoxProps<T extends object> extends
8181
StyleProps,
8282
SpectrumLabelableProps,
8383
HelpTextProps,
84-
Pick<ListBoxProps<T>, 'items'>,
84+
Pick<ListBoxProps<T>, 'items' | 'dependencies'>,
8585
Pick<AriaPopoverProps, 'shouldFlip'>,
8686
Pick<AsyncLoadable, 'onLoadMore'> {
8787
/** The contents of the collection. */
@@ -559,7 +559,7 @@ const ComboboxInner = forwardRef(function ComboboxInner(props: ComboBoxProps<any
559559
if (typeof children === 'function') {
560560
renderer = (
561561
<>
562-
<Collection items={items ?? defaultItems}>
562+
<Collection items={items ?? defaultItems} dependencies={props.dependencies}>
563563
{children}
564564
</Collection>
565565
{listBoxLoadingCircle}
@@ -681,6 +681,7 @@ const ComboboxInner = forwardRef(function ComboboxInner(props: ComboBoxProps<any
681681
loaderHeight: LOADER_ROW_HEIGHTS[size][scale]
682682
}}>
683683
<ListBox
684+
dependencies={props.dependencies}
684685
renderEmptyState={() => (
685686
<span className={emptyStateText({size})}>
686687
{loadingState === 'loading' ? stringFormatter.format('table.loading') : stringFormatter.format('combobox.noResults')}

packages/@react-spectrum/s2/src/Picker.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export interface PickerProps<T extends object> extends
9797
StyleProps,
9898
SpectrumLabelableProps,
9999
HelpTextProps,
100-
Pick<ListBoxProps<T>, 'items'>,
100+
Pick<ListBoxProps<T>, 'items' | 'dependencies'>,
101101
Pick<AriaPopoverProps, 'shouldFlip'>,
102102
Pick<AsyncLoadable, 'onLoadMore'> {
103103
/** The contents of the collection. */
@@ -319,7 +319,7 @@ export const Picker = /*#__PURE__*/ (forwardRef as forwardRefType)(function Pick
319319
if (typeof children === 'function' && items) {
320320
renderer = (
321321
<>
322-
<Collection items={items}>
322+
<Collection items={items} dependencies={props.dependencies}>
323323
{children}
324324
</Collection>
325325
{listBoxLoadingCircle}
@@ -425,6 +425,7 @@ export const Picker = /*#__PURE__*/ (forwardRef as forwardRefType)(function Pick
425425
}]
426426
]}>
427427
<ListBox
428+
dependencies={props.dependencies}
428429
items={items}
429430
className={listbox({size})}>
430431
{renderer}

0 commit comments

Comments
 (0)