Skip to content

Commit 139a72d

Browse files
Expand dependency version support in Icon Transformer (#7133)
* Expand dependency version support in Icon Transformer * add test for icon builder to verdaccio build * fix the range for the builder since we're pre-release * fix yarn lock * update verdaccio script to handle packages which are in pre-release without a major version * update yarn lock * turn off verdaccio again * turn back on verdaccio * turn verdaccio back off * Fix parcel plugin version --------- Co-authored-by: Devon Govett <[email protected]>
1 parent df6e3c0 commit 139a72d

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

packages/dev/parcel-transformer-s2-icon/package.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@
33
"version": "0.1.1",
44
"main": "IconTransformer.js",
55
"engines": {
6-
"parcel": "2.0.0-dev.1599"
6+
"parcel": "^2.0.0"
77
},
88
"dependencies": {
99
"@adobe/spectrum-tokens": "^13.0.0-beta.46",
10-
"@parcel/plugin": "2.0.0-dev.1601",
11-
"@svgr/core": "^6.2.0"
10+
"@parcel/plugin": "^2.0.0",
11+
"@svgr/core": "^6.2.0",
12+
"@svgr/plugin-jsx": "^6.2.0",
13+
"@svgr/plugin-svgo": "^6.2.0"
1214
},
1315
"rsp": {
1416
"type": "cli"

scripts/verdaccio.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ then
6565
fi
6666

6767
# Bump all package versions (allow publish from current branch but don't push tags or commit)
68-
yarn workspaces foreach --all --no-private version minor --deferred
68+
yarn workspaces foreach --all --no-private version patch --deferred
6969
yarn version apply --all
7070

7171
commit_to_revert="HEAD~0"
@@ -161,6 +161,12 @@ then
161161
yarn build
162162
mv dist ../../$verdaccio_path/s2-webpack-5-example
163163

164+
echo 'test icon builder'
165+
cd ../../examples/s2-webpack-5-example
166+
mkdir icon-test
167+
cp ../../packages/@react-spectrum/s2/s2wf-icons/S2_Icon_3D_20_N.svg icon-test/S2_Icon_3D_20_N.svg
168+
npx @react-spectrum/s2-icon-builder -i ./icon-test/S2_Icon_3D_20_N.svg -o ./icon-dist
169+
164170
cd ../..
165171

166172
echo 'get size of each package published to verdaccio'

yarn.lock

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7450,8 +7450,10 @@ __metadata:
74507450
resolution: "@react-spectrum/parcel-transformer-s2-icon@workspace:packages/dev/parcel-transformer-s2-icon"
74517451
dependencies:
74527452
"@adobe/spectrum-tokens": "npm:^13.0.0-beta.46"
7453-
"@parcel/plugin": "npm:2.0.0-dev.1601"
7453+
"@parcel/plugin": "npm:^2.0.0"
74547454
"@svgr/core": "npm:^6.2.0"
7455+
"@svgr/plugin-jsx": "npm:^6.2.0"
7456+
"@svgr/plugin-svgo": "npm:^6.2.0"
74557457
languageName: unknown
74567458
linkType: soft
74577459

0 commit comments

Comments
 (0)