Skip to content

Commit 2842ff5

Browse files
snowystingervadlakundannify
authored
action group button missing border (#2710)
* fix: actiongroup button missing its right norder * use z-index to show the right borders Co-authored-by: vadlakun <[email protected]> Co-authored-by: Danni <[email protected]>
1 parent 1d14dbf commit 2842ff5

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

packages/@adobe/spectrum-css-temp/components/actiongroup/index.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ governing permissions and limitations under the License.
4242

4343

4444
.spectrum-ActionGroup {
45+
isolation: isolate;
4546
display: flex;
4647
flex-wrap: wrap;
4748
--column-gap: var(--spectrum-actionbuttongroup-text-button-gap-x);
@@ -111,6 +112,10 @@ governing permissions and limitations under the License.
111112
border-end-end-radius: var(--spectrum-actionbutton-border-radius);
112113
}
113114

115+
&.spectrum-ActionGroup-item--isDisabled {
116+
z-index: -1;
117+
}
118+
114119
&.is-selected {
115120
z-index: 1;
116121
}

packages/@react-spectrum/actiongroup/src/ActionGroup.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,8 @@ function ActionGroupItem<T>({item, state, isDisabled, isEmphasized, staticColor,
309309
{
310310
'is-selected': isSelected,
311311
'is-hovered': isHovered,
312-
'spectrum-ActionGroup-item--iconOnly': hideButtonText
312+
'spectrum-ActionGroup-item--iconOnly': hideButtonText,
313+
'spectrum-ActionGroup-item--isDisabled': isDisabled
313314
},
314315
classNames(
315316
buttonStyles,

0 commit comments

Comments
 (0)