Skip to content

Commit 38834cb

Browse files
authored
Remove "use client" and mark packages as client-only instead (#5826)
1 parent 754bb55 commit 38834cb

File tree

9 files changed

+17
-63
lines changed

9 files changed

+17
-63
lines changed

.parcelrc-build

Lines changed: 0 additions & 17 deletions
This file was deleted.

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ publish-nightly: build
9292
yarn publish:nightly
9393

9494
build:
95-
parcel build packages/@react-{spectrum,aria,stately}/*/ packages/@internationalized/{message,string,date,number}/ packages/react-aria-components --no-optimize --config .parcelrc-build
95+
parcel build packages/@react-{spectrum,aria,stately}/*/ packages/@internationalized/{message,string,date,number}/ packages/react-aria-components --no-optimize
9696
yarn lerna run prepublishOnly
9797
for pkg in packages/@react-{spectrum,aria,stately}/*/ packages/@internationalized/{message,string,date,number}/ packages/@adobe/react-spectrum/ packages/react-aria/ packages/react-stately/ packages/react-aria-components/; \
9898
do node scripts/buildEsm.js $$pkg; \

packages/@adobe/react-spectrum/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
],
3131
"sideEffects": false,
3232
"scripts": {
33-
"prepublishOnly": "mkdir -p dist; cp src/index.ts dist/types.d.ts; sed -i.bak 's/'\\''use client'\\'';//' dist/types.d.ts; rm dist/types.d.ts.bak; grep -v '^export type' src/index.ts > dist/module.js; babel --root-mode upward src/index.ts -o dist/main.js"
33+
"prepublishOnly": "mkdir -p dist; cp src/index.ts dist/types.d.ts; grep -v '^export type' src/index.ts > dist/module.js; babel --root-mode upward src/index.ts -o dist/main.js"
3434
},
3535
"repository": {
3636
"type": "git",
@@ -92,7 +92,8 @@
9292
"@react-spectrum/well": "^3.4.9",
9393
"@react-stately/collections": "^3.10.4",
9494
"@react-stately/data": "^3.11.0",
95-
"@react-types/shared": "^3.22.0"
95+
"@react-types/shared": "^3.22.0",
96+
"client-only": "^0.0.1"
9697
},
9798
"publishConfig": {
9899
"access": "public"

packages/@adobe/react-spectrum/src/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@
1010
* governing permissions and limitations under the License.
1111
*/
1212

13-
'use client';
13+
// Mark as a client only package. This will cause a build time error if you try
14+
// to import it from a React Server Component in a framework like Next.js.
15+
import 'client-only';
1416

1517
export {ActionGroup} from '@react-spectrum/actiongroup';
1618
export {Badge} from '@react-spectrum/badge';

packages/dev/parcel-optimizer-react-client/ReactClientOptimizer.js

Lines changed: 0 additions & 30 deletions
This file was deleted.

packages/dev/parcel-optimizer-react-client/package.json

Lines changed: 0 additions & 12 deletions
This file was deleted.

packages/react-aria-components/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
"@react-types/shared": "^3.22.0",
5353
"@react-types/table": "^3.9.2",
5454
"@swc/helpers": "^0.5.0",
55+
"client-only": "^0.0.1",
5556
"react-aria": "^3.31.1",
5657
"react-stately": "^3.29.1",
5758
"use-sync-external-store": "^1.2.0"

packages/react-aria-components/src/index.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
* governing permissions and limitations under the License.
1111
*/
1212

13+
// Mark as a client only package. This will cause a build time error if you try
14+
// to import it from a React Server Component in a framework like Next.js.
15+
import 'client-only';
16+
1317
export {Breadcrumbs, BreadcrumbsContext, Breadcrumb} from './Breadcrumbs';
1418
export {Button, ButtonContext} from './Button';
1519
export {Calendar, CalendarGrid, CalendarGridHeader, CalendarGridBody, CalendarHeaderCell, CalendarCell, RangeCalendar, CalendarContext, RangeCalendarContext, CalendarStateContext, RangeCalendarStateContext} from './Calendar';

yarn.lock

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9165,6 +9165,11 @@ cli-width@^2.0.0:
91659165
resolved "https://registry.yarnpkg.com/cli-width/-/cli-width-2.2.0.tgz#ff19ede8a9a5e579324147b0c11f0fbcbabed639"
91669166
integrity sha1-/xnt6Kml5XkyQUewwR8PvLq+1jk=
91679167

9168+
client-only@^0.0.1:
9169+
version "0.0.1"
9170+
resolved "https://registry.yarnpkg.com/client-only/-/client-only-0.0.1.tgz#38bba5d403c41ab150bff64a95c85013cf73bca1"
9171+
integrity sha512-IV3Ou0jSMzZrd3pZ48nLkT9DA7Ag1pnPzaiQhpW7c3RbcqqzvzzVu+L8gfqMp/8IM2MQtSiqaCxrrcfu8I8rMA==
9172+
91689173
91699174
version "3.1.0"
91709175
resolved "https://registry.yarnpkg.com/clipanion/-/clipanion-3.1.0.tgz#3e217dd6476bb9236638b07eb4673f7309839819"

0 commit comments

Comments
 (0)