addressing more review comments

Author: LFDanLu

packages/@react-aria/autocomplete/src/useAutocomplete.ts

@@ -50,15 +50,15 @@ export interface AriaAutocompleteOptions extends Omit<AriaAutocompleteProps, 'ch
   collectionRef: RefObject<HTMLElement | null>
 }
 
-export interface AutocompleteAria {
+export interface AutocompleteAria<T> {
   /** Props for the autocomplete textfield/searchfield element. These should be passed to the textfield/searchfield aria hooks respectively. */
   textFieldProps: AriaTextFieldProps,
   /** Props for the collection, to be passed to collection's respective aria hook (e.g. useMenu). */
   collectionProps: CollectionOptions,
   /** Ref to attach to the wrapped collection. */
   collectionRef: RefObject<HTMLElement | null>,
   /** A filter function that returns if the provided collection node should be filtered out of the collection. */
-  filter?: (nodeTextValue: string, node: Node<unknown>) => boolean
+  filter?: (nodeTextValue: string, node: Node<T>) => boolean
 }
 
 /**
@@ -67,7 +67,7 @@ export interface AutocompleteAria {
  * @param props - Props for the autocomplete.
  * @param state - State for the autocomplete, as returned by `useAutocompleteState`.
  */
-export function useAutocomplete(props: AriaAutocompleteOptions, state: AutocompleteState): AutocompleteAria {
+export function useAutocomplete<T>(props: AriaAutocompleteOptions, state: AutocompleteState): AutocompleteAria<T> {
   let {
     inputRef,
     collectionRef,

packages/@react-aria/collections/src/Document.ts

@@ -259,15 +259,15 @@ export class ElementNode<T> extends BaseNode<T> {
   nodeType = 8; // COMMENT_NODE (we'd use ELEMENT_NODE but React DevTools will fail to get its dimensions)
   // TODO: running with assumption that setProps will be called before any other calls to node are made so theoretically
   // node will be defined
-  node: CollectionNode<T> | null;
+  private _node: CollectionNode<T> | null;
   isMutated = true;
   private _index: number = 0;
   hasSetProps = false;
   isHidden = false;
 
   constructor(type: string, ownerDocument: Document<T, any>) {
     super(ownerDocument);
-    this.node = null;
+    this._node = null;
   }
 
   get index(): number {
@@ -287,6 +287,17 @@ export class ElementNode<T> extends BaseNode<T> {
     return 0;
   }
 
+  get node(): CollectionNode<T> | null {
+    if (this._node == null && process.env.NODE_ENV !== 'production') {
+      console.error('Attempted to access node before it was defined. Check if setProps wasn\'t called before attempting to access the node.');
+    }
+    return this._node;
+  }
+
+  set node(node: CollectionNode<T>) {
+    this._node = node;
+  }
+
   /**
    * Lazily gets a mutable instance of a Node. If the node has already
    * been cloned during this update cycle, it just returns the existing one.