fix(#2486): PaginationInput throws parsing error due to improperly formatted localization strings (#2487)

Michael Jordan · LFDanLu · web-flow · commit 7893f939914d · 2021-10-28T16:12:01.000-07:00
Also, correct direction of Chevron icon on Previous or Next buttons for `rtl` locales.

Co-authored-by: Daniel Lu &lt;dlu@livefyre.com&gt;
diff --git a/packages/@react-spectrum/pagination/intl/ar-AE.json b/packages/@react-spectrum/pagination/intl/ar-AE.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "من {n, plural, =one{# صفحة} other{# من الصفحات}}"
+  "page_count": "من {n, plural, one{# صفحة} other{# من الصفحات}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/bg-BG.json b/packages/@react-spectrum/pagination/intl/bg-BG.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "на {n, plural, =one{# страници} other{# страници}}"
+  "page_count": "на {n, plural, one{# страници} other{# страници}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/cs-CZ.json b/packages/@react-spectrum/pagination/intl/cs-CZ.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "z {n, plural, =one{# stránky} other{# stránek}}"
+  "page_count": "z {n, plural, one{# stránky} other{# stránek}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/da-DK.json b/packages/@react-spectrum/pagination/intl/da-DK.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "af {n, plural, =one{# side} other{# sider}}"
+  "page_count": "af {n, plural, one{# side} other{# sider}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/de-DE.json b/packages/@react-spectrum/pagination/intl/de-DE.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "von {n, plural, =one{# Seite} other{# Seiten}}"
+  "page_count": "von {n, plural, one{# Seite} other{# Seiten}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/el-GR.json b/packages/@react-spectrum/pagination/intl/el-GR.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "από {n, plural, =one{# σελίδα} other{# σελίδες}}"
+  "page_count": "από {n, plural, one{# σελίδα} other{# σελίδες}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/en-US.json b/packages/@react-spectrum/pagination/intl/en-US.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "of {n, plural, =one{# page} other{# pages}}"
+  "page_count": "of {n, plural, one{# page} other{# pages}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/es-ES.json b/packages/@react-spectrum/pagination/intl/es-ES.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "de {n, plural, =one{# página} other{# páginas}}"
+  "page_count": "de {n, plural, one{# página} other{# páginas}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/et-EE.json b/packages/@react-spectrum/pagination/intl/et-EE.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "/ {n, plural, =one{# lk} other{# lk}}"
+  "page_count": "/ {n, plural, one{# lk} other{# lk}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/fi-FI.json b/packages/@react-spectrum/pagination/intl/fi-FI.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "/ {n, plural, =one{# sivu} other{# sivua}}"
+  "page_count": "/ {n, plural, one{# sivu} other{# sivua}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/fr-FR.json b/packages/@react-spectrum/pagination/intl/fr-FR.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "sur {n, plural, =one{# page} other{# pages}}"
+  "page_count": "sur {n, plural, one{# page} other{# pages}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/he-IL.json b/packages/@react-spectrum/pagination/intl/he-IL.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "מתוך {n‏, plural‏, =one{דף #} other{# דפים}}"
+  "page_count": "מתוך {n, plural, one{דף #} other{דפים #}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/hr-HR.json b/packages/@react-spectrum/pagination/intl/hr-HR.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "od {n, plural, =one{# stranica} other{# stranica}}"
+  "page_count": "od {n, plural, one{# stranica} other{# stranica}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/hu-HU.json b/packages/@react-spectrum/pagination/intl/hu-HU.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "/ {n, plural, =one{# oldal} other{# oldal}}"
+  "page_count": "/ {n, plural, one{# oldal} other{# oldal}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/index.js b/packages/@react-spectrum/pagination/intl/index.js
diff --git a/packages/@react-spectrum/pagination/intl/it-IT.json b/packages/@react-spectrum/pagination/intl/it-IT.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "di {n, plural, =one{# pagina} other{# pagine}}"
+  "page_count": "di {n, plural, one{# pagina} other{# pagine}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/ja-JP.json b/packages/@react-spectrum/pagination/intl/ja-JP.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "／ {n, plural, =one{# ページ} other{# ページ}}"
+  "page_count": "／ {n, plural, one{# ページ} other{# ページ}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/ko-KR.json b/packages/@react-spectrum/pagination/intl/ko-KR.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "/ {n, plural, =one{# 페이지} other{# 페이지}}"
+  "page_count": "/ {n, plural, one{# 페이지} other{# 페이지}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/lt-LT.json b/packages/@react-spectrum/pagination/intl/lt-LT.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "iš {n, plural, =one{# psl.} other{# psl.}}"
+  "page_count": "iš {n, plural, one{# psl.} other{# psl.}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/lv-LV.json b/packages/@react-spectrum/pagination/intl/lv-LV.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "no {n, plural, =one{# lpp.} other{# lpp.}}"
+  "page_count": "no {n, plural, one{# lpp.} other{# lpp.}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/nb-NO.json b/packages/@react-spectrum/pagination/intl/nb-NO.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "av {n, plural, =one{# side} other{# sider}}"
+  "page_count": "av {n, plural, one{# side} other{# sider}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/nl-NL.json b/packages/@react-spectrum/pagination/intl/nl-NL.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "van {n, plural, =one{# pagina} other{# pagina's}}"
+  "page_count": "van {n, plural, one{# pagina} other{# pagina's}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/pl-PL.json b/packages/@react-spectrum/pagination/intl/pl-PL.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "z {n, plural, =one{# nr strony} other{# liczba stron}}"
+  "page_count": "z {n, plural, one{# nr strony} other{# liczba stron}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/pt-BR.json b/packages/@react-spectrum/pagination/intl/pt-BR.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "de {n, plural, =one{# página} other{# páginas}}"
+  "page_count": "de {n, plural, one{# página} other{# páginas}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/pt-PT.json b/packages/@react-spectrum/pagination/intl/pt-PT.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "de {n, várias, =uma{# página} outras{# páginas}}"
+  "page_count": "de {n, plural, one{# página} other{# páginas}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/ro-RO.json b/packages/@react-spectrum/pagination/intl/ro-RO.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "sau {n, plural, =one{# pagină} other{# pagini}}"
+  "page_count": "sau {n, plural, one{# pagină} other{# pagini}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/ru-RU.json b/packages/@react-spectrum/pagination/intl/ru-RU.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "из {n, plural, =one{# стр.} other{# стр.}}"
+  "page_count": "из {n, plural, one{# стр.} other{# стр.}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/sk-SK.json b/packages/@react-spectrum/pagination/intl/sk-SK.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "z {n, plural, =one{# strany} other{# strán}}"
+  "page_count": "z {n, plural, one{# strany} other{# strán}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/sl-SI.json b/packages/@react-spectrum/pagination/intl/sl-SI.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "od {n, plural, =one{# strani} other{# strani}}"
+  "page_count": "od {n, plural, one{# strani} other{# strani}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/sr-SP.json b/packages/@react-spectrum/pagination/intl/sr-SP.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "od {n, plural, =one{# strana} other{# strana}}"
+  "page_count": "od {n, plural, one{# strana} other{# strana}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/sv-SE.json b/packages/@react-spectrum/pagination/intl/sv-SE.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "av {n, plural, =one{# sida} other{# sidor}}"
+  "page_count": "av {n, plural, one{# sida} other{# sidor}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/tr-TR.json b/packages/@react-spectrum/pagination/intl/tr-TR.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "/ {n, plural, =one{# sayfa} other{# sayfa}}"
+  "page_count": "/ {n, plural, one{# sayfa} other{# sayfa}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/uk-UA.json b/packages/@react-spectrum/pagination/intl/uk-UA.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "із {n, plural, =one{# сторінки} other{# стор.}}"
+  "page_count": "із {n, plural, one{# сторінки} other{# стор.}}"
 }
diff --git a/packages/@react-spectrum/pagination/intl/zh-CN.json b/packages/@react-spectrum/pagination/intl/zh-CN.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "（共 {n, plural, =one{# 页} other{# 页}}）"
+  "page_count": "（共 {n, plural, one{# 页} other{# 页}}）"
 }
diff --git a/packages/@react-spectrum/pagination/intl/zh-TW.json b/packages/@react-spectrum/pagination/intl/zh-TW.json
@@ -1,3 +1,3 @@
 {
-  "page_count": "共 {n, plural, =one{# 頁} other{# 頁}}"
+  "page_count": "共 {n, plural, one{# 頁} other{# 頁}}"
 }
diff --git a/packages/@react-spectrum/pagination/src/Pagination.tsx b/packages/@react-spectrum/pagination/src/Pagination.tsx
@@ -14,13 +14,14 @@ import {ActionButton} from '@react-spectrum/button';
 import ChevronLeftMedium from '@spectrum-icons/ui/ChevronLeftMedium';
 import ChevronRightMedium from '@spectrum-icons/ui/ChevronRightMedium';
 import {classNames} from '@react-spectrum/utils';
-import intlMessages from '../intl';
+// @ts-ignore
+import intlMessages from '../intl/*.json';
 import {PaginationBase} from '@react-types/pagination';
 import React from 'react';
 import styles from '@adobe/spectrum-css-temp/components/pagination/vars.css';
 import {TextField} from '@react-spectrum/textfield';
 import typographyStyles from '@adobe/spectrum-css-temp/components/typography/vars.css';
-import {useMessageFormatter} from '@react-aria/i18n';
+import {useLocale, useMessageFormatter} from '@react-aria/i18n';
 import {usePagination} from '@react-aria/pagination';
 import {usePaginationState} from '@react-stately/pagination';
 import {useProviderProps} from '@react-spectrum/provider';
@@ -31,6 +32,7 @@ export function PaginationInput(props: PaginationBase) {
   let state = usePaginationState(props);
   let {prevButtonProps, nextButtonProps, textProps} = usePagination(props, state);
   let formatMessage = useMessageFormatter(intlMessages);
+  let {direction} = useLocale();
   const {maxValue} = props;
 
   return (
@@ -39,7 +41,7 @@ export function PaginationInput(props: PaginationBase) {
       <ActionButton
         {...prevButtonProps}
         isQuiet>
-        <ChevronLeftMedium />
+        {direction === 'rtl' ? <ChevronRightMedium /> : <ChevronLeftMedium />}
       </ActionButton>
       <TextField
         {...textProps}
@@ -53,7 +55,7 @@ export function PaginationInput(props: PaginationBase) {
       <ActionButton
         {...nextButtonProps}
         isQuiet>
-        <ChevronRightMedium />
+        {direction === 'rtl' ? <ChevronLeftMedium /> : <ChevronRightMedium />}
       </ActionButton>
     </nav>
   );

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "من {n, plural, =one{# صفحة} other{# من الصفحات}}"`
	`2`	`+ "page_count": "من {n, plural, one{# صفحة} other{# من الصفحات}}"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "на {n, plural, =one{# страници} other{# страници}}"`
	`2`	`+ "page_count": "на {n, plural, one{# страници} other{# страници}}"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "z {n, plural, =one{# stránky} other{# stránek}}"`
	`2`	`+ "page_count": "z {n, plural, one{# stránky} other{# stránek}}"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "af {n, plural, =one{# side} other{# sider}}"`
	`2`	`+ "page_count": "af {n, plural, one{# side} other{# sider}}"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "von {n, plural, =one{# Seite} other{# Seiten}}"`
	`2`	`+ "page_count": "von {n, plural, one{# Seite} other{# Seiten}}"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "από {n, plural, =one{# σελίδα} other{# σελίδες}}"`
	`2`	`+ "page_count": "από {n, plural, one{# σελίδα} other{# σελίδες}}"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "of {n, plural, =one{# page} other{# pages}}"`
	`2`	`+ "page_count": "of {n, plural, one{# page} other{# pages}}"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "de {n, plural, =one{# página} other{# páginas}}"`
	`2`	`+ "page_count": "de {n, plural, one{# página} other{# páginas}}"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "/ {n, plural, =one{# lk} other{# lk}}"`
	`2`	`+ "page_count": "/ {n, plural, one{# lk} other{# lk}}"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "page_count": "/ {n, plural, =one{# sivu} other{# sivua}}"`
	`2`	`+ "page_count": "/ {n, plural, one{# sivu} other{# sivua}}"`
`3`	`3`	`}`