Skip to content

Commit 80fd6f3

Browse files
authored
Remove SearchWithin from Form stories (#3852)
* remove SearchWithin from Form stories
1 parent 5b6ec5b commit 80fd6f3

File tree

5 files changed

+2
-76
lines changed

5 files changed

+2
-76
lines changed

packages/@react-spectrum/form/chromatic/Form.chromatic.tsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import {NumberField} from '@react-spectrum/numberfield';
2222
import {Radio, RadioGroup} from '@react-spectrum/radio';
2323
import React from 'react';
2424
import {SearchField} from '@react-spectrum/searchfield';
25-
import {SearchWithin} from '@react-spectrum/searchwithin';
2625
import {SpectrumFormProps} from '@react-types/form';
2726
import {TextArea, TextField} from '@react-spectrum/textfield';
2827

@@ -62,12 +61,6 @@ const Template = (): Story<SpectrumFormProps> => (args) => (
6261
<Radio value="dragons">Dragons</Radio>
6362
</RadioGroup>
6463
<SearchField label="Search" />
65-
<SearchWithin label="Search">
66-
<SearchField placeholder="Search" />
67-
<Picker label="State" placeholder="Select a state" items={flatOptions}>
68-
{item => <Item key={item.id}>{item.name}</Item>}
69-
</Picker>
70-
</SearchWithin>
7164
<TextArea label="Comments" placeholder="How do you feel?" />
7265
<TextField
7366
label="City"

packages/@react-spectrum/form/chromatic/FormLongLabel.chromatic.tsx

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import {NumberField} from '@react-spectrum/numberfield';
2020
import {Radio, RadioGroup} from '@react-spectrum/radio';
2121
import React from 'react';
2222
import {SearchField} from '@react-spectrum/searchfield';
23-
import {SearchWithin} from '@react-spectrum/searchwithin';
2423
import {SpectrumFormProps} from '@react-types/form';
2524
import {TextArea, TextField} from '@react-spectrum/textfield';
2625

@@ -62,15 +61,6 @@ const Template = (): Story<SpectrumFormProps> => (args) => (
6261
<Radio value="dragons">Ringu the five headed metallic dragon of gold, silver, bronze, copper, and brass</Radio>
6362
</RadioGroup>
6463
<SearchField label="Search for the entirety of knowledge on Creative Cloud Express" placeholder="Enter text" />
65-
<SearchWithin label="SearchWithin the depths of the human soul searching for what made us farm">
66-
<SearchField placeholder="Search" />
67-
<Picker defaultSelectedKey="all">
68-
<Item key="all">All</Item>
69-
<Item key="campaigns">Campaigns</Item>
70-
<Item key="audiences">Audiences</Item>
71-
<Item key="tags">Tags</Item>
72-
</Picker>
73-
</SearchWithin>
7464
<TextArea label="Please write an epic story of fact and fantasy in the epic sci-fi genre of dinosaurs" placeholder="How do you feel?" />
7565
<TextField label="Cities of past, present, and future" placeholder="San Francisco" />
7666
</Form>

packages/@react-spectrum/form/stories/Form.stories.tsx

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import {NumberField} from '@react-spectrum/numberfield';
2727
import {Radio, RadioGroup} from '@react-spectrum/radio';
2828
import React, {Key, useEffect, useState} from 'react';
2929
import {SearchField} from '@react-spectrum/searchfield';
30-
import {SearchWithin} from '@react-spectrum/searchwithin';
3130
import {StatusLight} from '@react-spectrum/statuslight';
3231
import {storiesOf} from '@storybook/react';
3332
import {Switch} from '@react-spectrum/switch';
@@ -254,12 +253,6 @@ function render(props: any = {}) {
254253
<Radio value="dragons">Dragons</Radio>
255254
</RadioGroup>
256255
<SearchField label="Search" />
257-
<SearchWithin label="Search cities">
258-
<SearchField />
259-
<Picker label="State" items={states}>
260-
{item => <Item key={item.abbr}>{item.name}</Item>}
261-
</Picker>
262-
</SearchWithin>
263256
<Switch>Low power mode</Switch>
264257
<TextArea label="Comments" description="Express yourself!" errorMessage="No wrong answers, except for this one." />
265258
<TextField
@@ -287,7 +280,6 @@ function FormWithControls(props: any = {}) {
287280
let [favoriteColor2, setFavoriteColor2] = useState('green' as Key);
288281
let [howIFeel2, setHowIFeel2] = useState('I feel good, o I feel so good!');
289282
let [preventDefault, setPreventDefault] = useState(true);
290-
let [favoriteColor3, setFavoriteColor3] = useState('green' as Key);
291283

292284
return (
293285
<Flex>
@@ -328,17 +320,6 @@ function FormWithControls(props: any = {}) {
328320
</Picker>
329321
<TextArea name="comments-controlled" label="Comments" value={howIFeel} onChange={setHowIFeel} />
330322
<TextArea name="comments-uncontrolled" label="Comments" defaultValue="hello" />
331-
<SearchWithin label="Search">
332-
<SearchField />
333-
<Picker name="favorite-color3" label="Favorite color searchwithin" selectedKey={favoriteColor3} onSelectionChange={setFavoriteColor3}>
334-
<Item key="red">Red</Item>
335-
<Item key="orange">Orange</Item>
336-
<Item key="yellow">Yellow</Item>
337-
<Item key="green">Green</Item>
338-
<Item key="blue">Blue</Item>
339-
<Item key="purple">Purple</Item>
340-
</Picker>
341-
</SearchWithin>
342323
<ComboBox label="Favorite Animal" name="favorite-animal">
343324
<Item key="red panda">Red Panda</Item>
344325
<Item key="aardvark">Aardvark</Item>
@@ -433,18 +414,6 @@ function FormWithControls(props: any = {}) {
433414
Comments default
434415
<textarea defaultValue="hello" />
435416
</label>
436-
<label>
437-
Favorite Color searchwithin
438-
<input type="text" />
439-
<select onChange={e => setFavoriteColor3(e.target.value)}>
440-
<option value="red" selected={favoriteColor3 === 'red'}>Red</option>
441-
<option value="orange" selected={favoriteColor3 === 'orange'}>Orange</option>
442-
<option value="yellow" selected={favoriteColor3 === 'yellow'}>Yellow</option>
443-
<option value="green" selected={favoriteColor3 === 'green'}>Green</option>
444-
<option value="blue" selected={favoriteColor3 === 'blue'}>Blue</option>
445-
<option value="purple" selected={favoriteColor3 === 'purple'}>Purple</option>
446-
</select>
447-
</label>
448417
<ButtonGroup>
449418
<Button variant="secondary" type="reset">Reset</Button>
450419
<Button variant="primary" type="submit">Submit</Button>

packages/@react-spectrum/provider/chromatic/Provider.chromatic.tsx

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,10 @@
1212

1313
import {Button} from '@react-spectrum/button';
1414
import {Checkbox, CheckboxGroup} from '@react-spectrum/checkbox';
15-
import {ComboBox} from '@react-spectrum/combobox';
15+
import {ComboBox, Item} from '@react-spectrum/combobox';
1616
import customTheme from './custom-theme.css';
1717
import {Flex} from '@react-spectrum/layout';
1818
import {Form} from '@react-spectrum/form';
19-
import {Item, Picker} from '@react-spectrum/picker';
2019
import {Meta, Story} from '@storybook/react';
2120
import {NumberField} from '@react-spectrum/numberfield';
2221
import {Provider} from '../';
@@ -26,7 +25,6 @@ import React from 'react';
2625
import scaleLarge from '@adobe/spectrum-css-temp/vars/spectrum-large.css';
2726
import scaleMedium from '@adobe/spectrum-css-temp/vars/spectrum-medium.css';
2827
import {SearchField} from '@react-spectrum/searchfield';
29-
import {SearchWithin} from '@react-spectrum/searchwithin';
3028
import {Switch} from '@react-spectrum/switch';
3129
import {TextField} from '@react-spectrum/textfield';
3230
import {useBreakpoint} from '@react-spectrum/utils';
@@ -68,17 +66,6 @@ const Template = (): Story<ProviderProps> => (args) => (
6866
<Radio value="horses">Horses</Radio>
6967
</RadioGroup>
7068
<SearchField label="Search" />
71-
<SearchWithin label="Search">
72-
<SearchField placeholder="Search" />
73-
<Picker name="favorite-color3" label="Favorite color searchwithin">
74-
<Item key="red">Red</Item>
75-
<Item key="orange">Orange</Item>
76-
<Item key="yellow">Yellow</Item>
77-
<Item key="green">Green</Item>
78-
<Item key="blue">Blue</Item>
79-
<Item key="purple">Purple</Item>
80-
</Picker>
81-
</SearchWithin>
8269
<Switch isSelected>Dogs!</Switch>
8370
<TextField
8471
label="A text field"

packages/@react-spectrum/provider/stories/Provider.stories.tsx

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,18 @@
1212

1313
import {Button} from '@react-spectrum/button';
1414
import {Checkbox, CheckboxGroup} from '@react-spectrum/checkbox';
15-
import {ComboBox} from '@react-spectrum/combobox';
15+
import {ComboBox, Item} from '@react-spectrum/combobox';
1616
import customTheme from './custom-theme.css';
1717
import {theme as expressTheme} from '@react-spectrum/theme-express';
1818
import {Flex} from '@react-spectrum/layout';
1919
import {Form} from '@react-spectrum/form';
20-
import {Item, Picker} from '@react-spectrum/picker';
2120
import {NumberField} from '@react-spectrum/numberfield';
2221
import {Provider} from '../';
2322
import {Radio, RadioGroup} from '@react-spectrum/radio';
2423
import React from 'react';
2524
import scaleLarge from '@adobe/spectrum-css-temp/vars/spectrum-large.css';
2625
import scaleMedium from '@adobe/spectrum-css-temp/vars/spectrum-medium.css';
2726
import {SearchField} from '@react-spectrum/searchfield';
28-
import {SearchWithin} from '@react-spectrum/searchwithin';
2927
import {storiesOf} from '@storybook/react';
3028
import {Switch} from '@react-spectrum/switch';
3129
import {TextField} from '@react-spectrum/textfield';
@@ -195,17 +193,6 @@ function render(props = {}) {
195193
<Radio value="horses">Horses</Radio>
196194
</RadioGroup>
197195
<SearchField label="Search" />
198-
<SearchWithin label="Search">
199-
<SearchField />
200-
<Picker name="favorite-color3" label="Favorite color searchwithin">
201-
<Item key="red">Red</Item>
202-
<Item key="orange">Orange</Item>
203-
<Item key="yellow">Yellow</Item>
204-
<Item key="green">Green</Item>
205-
<Item key="blue">Blue</Item>
206-
<Item key="purple">Purple</Item>
207-
</Picker>
208-
</SearchWithin>
209196
<Switch isSelected>Dogs!</Switch>
210197
<TextField
211198
label="A text field"

0 commit comments

Comments
 (0)