File tree Expand file tree Collapse file tree 3 files changed +5
-10
lines changed
@react-aria/collections/src
react-aria-components/src Expand file tree Collapse file tree 3 files changed +5
-10
lines changed Original file line number Diff line number Diff line change @@ -81,9 +81,8 @@ export class CollectionNode<T> implements Node<T> {
81
81
// TODO: naming, but essentially these nodes shouldn't be affected by filtering (BaseNode)?
82
82
// Perhaps this filter logic should be in CollectionNode instead and the current logic of CollectionNode's filter should move to Table
83
83
export class FilterLessNode < T > extends CollectionNode < T > {
84
- // TODO: resolve this
85
- // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-unused-vars
86
- filter ( _ , __ , ___ ) : FilterLessNode < T > | null {
84
+ // eslint-disable-next-line @typescript-eslint/no-unused-vars
85
+ filter ( collection : BaseCollection < T > , newCollection : BaseCollection < T > , filterFn : ( node : Node < T > ) => boolean ) : FilterLessNode < T > | null {
87
86
return this . clone ( ) ;
88
87
}
89
88
}
@@ -95,9 +94,7 @@ export class ItemNode<T> extends CollectionNode<T> {
95
94
super ( ItemNode . type , key ) ;
96
95
}
97
96
98
- // TODO: resolve this
99
- // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
100
- filter ( _ , __ , filterFn : ( node : Node < T > ) => boolean ) : ItemNode < T > | null {
97
+ filter ( collection : BaseCollection < T > , newCollection : BaseCollection < T > , filterFn : ( node : Node < T > ) => boolean ) : ItemNode < T > | null {
101
98
if ( filterFn ( this ) ) {
102
99
return this . clone ( ) ;
103
100
}
Original file line number Diff line number Diff line change @@ -28,9 +28,7 @@ export class SeparatorNode extends CollectionNode<any> {
28
28
super ( SeparatorNode . type , key ) ;
29
29
}
30
30
31
- // TODO: resolve this
32
- // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
33
- filter ( _ , newCollection : BaseCollection < any > ) : CollectionNode < any > | null {
31
+ filter ( collection : BaseCollection < any > , newCollection : BaseCollection < any > ) : CollectionNode < any > | null {
34
32
if ( newCollection . getItem ( this . prevKey ! ) ) {
35
33
return this . clone ( ) ;
36
34
}
Original file line number Diff line number Diff line change @@ -197,7 +197,7 @@ class TableCollection<T> extends BaseCollection<T> implements ITableCollection<T
197
197
return text . join ( ' ' ) ;
198
198
}
199
199
200
- filter ( filterFn : ( textValue : string ) => boolean ) : TableCollection < T > {
200
+ filter ( filterFn : ( node : Node < T > ) => boolean ) : TableCollection < T > {
201
201
let clone = this . clone ( ) ;
202
202
return super . filter ( filterFn , clone ) as TableCollection < T > ;
203
203
You can’t perform that action at this time.
0 commit comments