Skip to content

Commit 90c2056

Browse files
committed
fix lint
1 parent 1ead59b commit 90c2056

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

packages/@react-aria/collections/src/BaseCollection.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,8 @@ export class CollectionNode<T> implements Node<T> {
8181
// TODO: naming, but essentially these nodes shouldn't be affected by filtering (BaseNode)?
8282
// Perhaps this filter logic should be in CollectionNode instead and the current logic of CollectionNode's filter should move to Table
8383
export class FilterLessNode<T> extends CollectionNode<T> {
84-
// TODO: resolve this
85-
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-unused-vars
86-
filter(_, __, ___): FilterLessNode<T> | null {
84+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
85+
filter(collection: BaseCollection<T>, newCollection: BaseCollection<T>, filterFn: (node: Node<T>) => boolean): FilterLessNode<T> | null {
8786
return this.clone();
8887
}
8988
}
@@ -95,9 +94,7 @@ export class ItemNode<T> extends CollectionNode<T> {
9594
super(ItemNode.type, key);
9695
}
9796

98-
// TODO: resolve this
99-
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
100-
filter(_, __, filterFn: (node: Node<T>) => boolean): ItemNode<T> | null {
97+
filter(collection: BaseCollection<T>, newCollection: BaseCollection<T>, filterFn: (node: Node<T>) => boolean): ItemNode<T> | null {
10198
if (filterFn(this)) {
10299
return this.clone();
103100
}

packages/react-aria-components/src/Separator.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ export class SeparatorNode extends CollectionNode<any> {
2828
super(SeparatorNode.type, key);
2929
}
3030

31-
// TODO: resolve this
32-
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
33-
filter(_, newCollection: BaseCollection<any>): CollectionNode<any> | null {
31+
filter(collection: BaseCollection<any>, newCollection: BaseCollection<any>): CollectionNode<any> | null {
3432
if (newCollection.getItem(this.prevKey!)) {
3533
return this.clone();
3634
}

packages/react-aria-components/src/Table.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ class TableCollection<T> extends BaseCollection<T> implements ITableCollection<T
197197
return text.join(' ');
198198
}
199199

200-
filter(filterFn: (textValue: string) => boolean): TableCollection<T> {
200+
filter(filterFn: (node: Node<T>) => boolean): TableCollection<T> {
201201
let clone = this.clone();
202202
return super.filter(filterFn, clone) as TableCollection<T>;
203203

0 commit comments

Comments
 (0)