Skip to content

Commit a6b73ae

Browse files
Replace "start" with "flex-start" in CSS (#2695)
Currently when using react-spectrum eslint will show a warning about start having mixed support. ``` ./node_modules/@react-spectrum/breadcrumbs/dist/main.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./node_modules/@rea Warning (1:745) start value has mixed support, consider using flex-start instead ./node_modules/@react-spectrum/breadcrumbs/dist/main.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./node_modules/@rea Warning (1:83) start value has mixed support, consider using flex-start instead ``` This fixes those warnings. This takes over from #1793, which has been inactive since April 2021 and also borrows some changes from #686 that never got applied. A total of 5 files are modified: ``` $ git diff --stat main...HEAD packages/@adobe/spectrum-css-temp/components/breadcrumb/index.css | 4 ++-- packages/@adobe/spectrum-css-temp/components/coachmark/index.css | 2 +- packages/@adobe/spectrum-css-temp/components/dialog/index.css | 2 +- packages/@adobe/spectrum-css-temp/components/menu/index.css | 6 +++--- packages/@adobe/spectrum-css-temp/components/sidenav/index.css | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) ``` Co-authored-by: Robert Snow <[email protected]>
1 parent aa988c5 commit a6b73ae

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

packages/@adobe/spectrum-css-temp/components/breadcrumb/index.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ governing permissions and limitations under the License.
1414

1515
.spectrum-Breadcrumbs {
1616
display: flex;
17-
justify-content: start;
17+
justify-content: flex-start;
1818
list-style-type: none;
1919
flex-wrap: nowrap;
2020
flex-grow: 1;
@@ -46,7 +46,7 @@ governing permissions and limitations under the License.
4646
.spectrum-Breadcrumbs-item {
4747
display: inline-flex;
4848
align-items: center;
49-
justify-content: start;
49+
justify-content: flex-start;
5050

5151
box-sizing: border-box;
5252
height: var(--spectrum-breadcrumb-list-height);

packages/@adobe/spectrum-css-temp/components/coachmark/index.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ governing permissions and limitations under the License.
5959
}
6060

6161
.spectrum-CoachMarkPopover-step {
62-
align-self: start;
62+
align-self: flex-start;
6363

6464
font-size: var(--spectrum-coachmark-step-text-size);
6565
font-weight: var(--spectrum-coachmark-step-text-font-weight);

packages/@adobe/spectrum-css-temp/components/dialog/index.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ governing permissions and limitations under the License.
239239
.spectrum-Dialog.spectrum-Dialog--dismissable .spectrum-Dialog-closeButton {
240240
grid-area: closeButton;
241241
/* align and justify so it doesn't do the default 'stretch' and end up with forced height/width */
242-
align-self: start;
242+
align-self: flex-start;
243243
justify-self: end;
244244

245245
margin-inline-end: var(--spectrum-dialog-close-button-padding);

packages/@adobe/spectrum-css-temp/components/menu/index.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ governing permissions and limitations under the License.
121121

122122
.spectrum-Menu-checkmark {
123123
display: none;
124-
align-self: start;
124+
align-self: flex-start;
125125
justify-self: end;
126126
grid-area: checkmark;
127127
}
@@ -185,7 +185,7 @@ governing permissions and limitations under the License.
185185
.spectrum-Menu .spectrum-Menu-end {
186186
grid-area: end;
187187
justify-self: end;
188-
align-self: start;
188+
align-self: flex-start;
189189
padding-inline-start: var(--spectrum-global-dimension-size-125);
190190
}
191191
.spectrum-Menu-icon {
@@ -201,7 +201,7 @@ governing permissions and limitations under the License.
201201
}
202202
.spectrum-Menu-keyboard {
203203
grid-area: keyboard;
204-
align-self: start;
204+
align-self: flex-start;
205205
padding-inline-start: var(--spectrum-global-dimension-size-125);
206206
/* override default browser styling. */
207207
/* keyboard shortcuts are always ASCII, so use base font */

packages/@adobe/spectrum-css-temp/components/sidenav/index.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ governing permissions and limitations under the License.
3535
position: relative;
3636
display: inline-flex;
3737
align-items: center;
38-
justify-content: start;
38+
justify-content: flex-start;
3939
box-sizing: border-box;
4040

4141
inline-size: 100%;

0 commit comments

Comments
 (0)