Skip to content

Commit ac96fa1

Browse files
fix: Improve S2 docs bundle size (#8891)
* Update parcel to v2.16.0 * Remove card descriptions * Update SSGPackager matches changes in Parcel for ReactStaticPackager * refactor search menu to be code split * code split illustration types * Fix collections wrapped in suspense updating incorrectly * Only include english strings * Update packages/dev/parcel-packager-ssg/SSGPackager.js Co-authored-by: Robert Snow <[email protected]> --------- Co-authored-by: Robert Snow <[email protected]>
1 parent c12a3b4 commit ac96fa1

File tree

39 files changed

+1596
-1440
lines changed

39 files changed

+1596
-1440
lines changed

package.json

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -91,21 +91,22 @@
9191
"@faker-js/faker": "^8.4.1",
9292
"@jdb8/eslint-plugin-monorepo": "^1.0.1",
9393
"@octokit/rest": "*",
94-
"@parcel/bundler-library": "^2.15.4",
95-
"@parcel/config-default": "^2.15.4",
94+
"@parcel/bundler-library": "^2.16.0",
95+
"@parcel/config-default": "^2.16.0",
9696
"@parcel/config-storybook": ">=0.0.2",
97-
"@parcel/core": "^2.15.4",
98-
"@parcel/optimizer-data-url": "^2.15.4",
99-
"@parcel/optimizer-terser": "^2.15.4",
100-
"@parcel/packager-react-static": "^2.15.4",
101-
"@parcel/packager-ts": "^2.15.4",
102-
"@parcel/reporter-cli": "^2.15.4",
103-
"@parcel/resolver-glob": "^2.15.4",
104-
"@parcel/transformer-inline": "^2.15.4",
105-
"@parcel/transformer-inline-string": "^2.15.4",
106-
"@parcel/transformer-react-static": "^2.15.4",
107-
"@parcel/transformer-svg-react": "^2.15.4",
108-
"@parcel/transformer-typescript-types": "^2.15.4",
97+
"@parcel/core": "^2.16.0",
98+
"@parcel/optimizer-data-url": "^2.16.0",
99+
"@parcel/optimizer-terser": "^2.16.0",
100+
"@parcel/packager-react-static": "^2.16.0",
101+
"@parcel/packager-ts": "^2.16.0",
102+
"@parcel/reporter-bundle-analyzer": "^2.16.0",
103+
"@parcel/reporter-cli": "^2.16.0",
104+
"@parcel/resolver-glob": "^2.16.0",
105+
"@parcel/transformer-inline": "^2.16.0",
106+
"@parcel/transformer-inline-string": "^2.16.0",
107+
"@parcel/transformer-react-static": "^2.16.0",
108+
"@parcel/transformer-svg-react": "^2.16.0",
109+
"@parcel/transformer-typescript-types": "^2.16.0",
109110
"@react-spectrum/parcel-namer-s2": "^0.3.0",
110111
"@react-spectrum/s2-icon-builder": "^0.3.0",
111112
"@spectrum-css/component-builder": "workspace:^",
@@ -183,7 +184,7 @@
183184
"npm-cli-login": "^1.0.0",
184185
"nyc": "^10.2.0",
185186
"p-queue": "^6.2.1",
186-
"parcel": "^2.15.4",
187+
"parcel": "^2.16.0",
187188
"parcel-optimizer-strict-mode": "workspace:^",
188189
"patch-package": "^6.2.0",
189190
"playwright": "^1.45.3",
@@ -293,5 +294,8 @@
293294
]
294295
}
295296
]
296-
}
297+
},
298+
"locales": [
299+
"en-US"
300+
]
297301
}

packages/@react-aria/collections/src/CollectionBuilder.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import {forwardRefType, Key, Node} from '@react-types/shared';
1919
import {Hidden} from './Hidden';
2020
import React, {createContext, ForwardedRef, forwardRef, JSX, ReactElement, ReactNode, useCallback, useContext, useMemo, useRef, useState} from 'react';
2121
import {useIsSSR} from '@react-aria/ssr';
22-
import {useLayoutEffect} from '@react-aria/utils';
2322
import {useSyncExternalStore as useSyncExternalStoreShim} from 'use-sync-external-store/shim/index.js';
2423

2524
const ShallowRenderContext = createContext(false);
@@ -114,14 +113,6 @@ function useCollectionDocument<T extends object, C extends BaseCollection<T>>(cr
114113
return document.getCollection();
115114
}, [document]);
116115
let collection = useSyncExternalStore(subscribe, getSnapshot, getServerSnapshot);
117-
useLayoutEffect(() => {
118-
document.isMounted = true;
119-
return () => {
120-
// Mark unmounted so we can skip all of the collection updates caused by
121-
// React calling removeChild on every item in the collection.
122-
document.isMounted = false;
123-
};
124-
}, [document]);
125116
return {collection, document};
126117
}
127118

packages/@react-aria/collections/src/Document.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ export class BaseNode<T> {
179179
}
180180

181181
removeChild(child: ElementNode<T>): void {
182-
if (child.parentNode !== this || !this.ownerDocument.isMounted) {
182+
if (child.parentNode !== this) {
183183
return;
184184
}
185185

@@ -411,7 +411,6 @@ export class Document<T, C extends BaseCollection<T> = BaseCollection<T>> extend
411411
isSSR = false;
412412
nodeId = 0;
413413
nodesByProps: WeakMap<object, ElementNode<T>> = new WeakMap<object, ElementNode<T>>();
414-
isMounted = true;
415414
private collection: C;
416415
private nextCollection: C | null = null;
417416
private subscriptions: Set<() => void> = new Set();
@@ -426,7 +425,7 @@ export class Document<T, C extends BaseCollection<T> = BaseCollection<T>> extend
426425
}
427426

428427
get isConnected(): boolean {
429-
return this.isMounted;
428+
return true;
430429
}
431430

432431
createElement(type: string): ElementNode<T> {

packages/@react-spectrum/s2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@
141141
},
142142
"devDependencies": {
143143
"@adobe/spectrum-tokens": "^13.10.0",
144-
"@parcel/macros": "^2.15.4",
144+
"@parcel/macros": "^2.16.0",
145145
"@react-aria/test-utils": "^1.0.0-alpha.8",
146146
"@storybook/jest": "^0.2.3",
147147
"@testing-library/dom": "^10.1.0",

packages/dev/parcel-config-storybook/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
"access": "public"
1111
},
1212
"dependencies": {
13-
"@parcel/config-default": "^2.13.1",
14-
"@parcel/core": "^2.13.1",
13+
"@parcel/config-default": "^2.16.0",
14+
"@parcel/core": "^2.16.0",
1515
"@parcel/resolver-storybook": ">=0.0.0",
16-
"@parcel/transformer-js": "^2.13.1",
17-
"@parcel/transformer-react-refresh-wrap": "^2.13.1",
16+
"@parcel/transformer-js": "^2.16.0",
17+
"@parcel/transformer-react-refresh-wrap": "^2.16.0",
1818
"@parcel/transformer-storybook": ">=0.0.2"
1919
},
2020
"scripts": {

packages/dev/parcel-namer-docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
"parcel": "^2.0.0"
88
},
99
"dependencies": {
10-
"@parcel/plugin": "^2.15.4"
10+
"@parcel/plugin": "^2.16.0"
1111
}
1212
}

packages/dev/parcel-namer-intl/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
"parcel": "^2.0.0"
88
},
99
"dependencies": {
10-
"@parcel/plugin": "^2.15.4"
10+
"@parcel/plugin": "^2.16.0"
1111
}
1212
}

packages/dev/parcel-namer-s2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"parcel": "^2.0.0"
77
},
88
"dependencies": {
9-
"@parcel/plugin": "^2.15.4"
9+
"@parcel/plugin": "^2.16.0"
1010
},
1111
"rsp": {
1212
"type": "cli"

packages/dev/parcel-optimizer-strict-mode/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
"parcel": "^2.0.0"
88
},
99
"dependencies": {
10-
"@parcel/plugin": "^2.15.4"
10+
"@parcel/plugin": "^2.16.0"
1111
}
1212
}

packages/dev/parcel-packager-docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
"parcel": "^2.0.0"
88
},
99
"dependencies": {
10-
"@parcel/plugin": "^2.15.4"
10+
"@parcel/plugin": "^2.16.0"
1111
}
1212
}

0 commit comments

Comments
 (0)