Skip to content

Commit b075dc5

Browse files
authored
Update column resizing stately function property names (#4055)
* Update column resizing stately function property names
1 parent 5baa76f commit b075dc5

File tree

4 files changed

+21
-21
lines changed

4 files changed

+21
-21
lines changed

packages/@react-aria/table/src/useTableColumnResize.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,25 +77,25 @@ export function useTableColumnResize<T>(props: AriaTableColumnResizeProps<T>, st
7777

7878
let startResize = useCallback((item) => {
7979
if (!isResizing.current) {
80-
lastSize.current = state.onColumnResize(item.key, state.getColumnWidth(item.key));
81-
state.onColumnResizeStart(item.key);
80+
lastSize.current = state.updateResizedColumns(item.key, state.getColumnWidth(item.key));
81+
state.startResize(item.key);
8282
onResizeStart?.(lastSize.current);
8383
}
8484
isResizing.current = true;
8585
}, [isResizing, onResizeStart, state]);
8686

8787
let resize = useCallback((item, newWidth) => {
88-
let sizes = state.onColumnResize(item.key, newWidth);
88+
let sizes = state.updateResizedColumns(item.key, newWidth);
8989
onResize?.(sizes);
9090
lastSize.current = sizes;
9191
}, [onResize, state]);
9292

9393
let endResize = useCallback((item) => {
9494
if (lastSize.current == null) {
95-
lastSize.current = state.onColumnResize(item.key, state.getColumnWidth(item.key));
95+
lastSize.current = state.updateResizedColumns(item.key, state.getColumnWidth(item.key));
9696
}
9797
if (isResizing.current) {
98-
state.onColumnResizeEnd();
98+
state.endResize();
9999
onResizeEnd?.(lastSize.current);
100100
}
101101
isResizing.current = false;

packages/@react-spectrum/table/src/TableView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -732,7 +732,7 @@ function ResizableTableColumnHeader(props) {
732732
state.sort(column.key, 'descending');
733733
break;
734734
case 'resize':
735-
layout.onColumnResizeStart(column.key);
735+
layout.startResize(column.key);
736736
setIsInResizeMode(true);
737737
break;
738738
}

packages/@react-stately/layout/src/TableLayout.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,12 @@ export class TableLayout<T> extends ListLayout<T> {
9090
}
9191

9292
// outside, where this is called, should call props.onColumnResizeStart...
93-
onColumnResizeStart(key: Key): void {
93+
startResize(key: Key): void {
9494
this.resizingColumn = key;
9595
}
9696

9797
// only way to call props.onColumnResize with the new size outside of Layout is to send the result back
98-
onColumnResize(key: Key, width: number): Map<Key, ColumnSize> {
98+
updateResizedColumns(key: Key, width: number): Map<Key, ColumnSize> {
9999
let newControlled = new Map(Array.from(this.controlledColumns).map(([key, entry]) => [key, entry.props.width]));
100100
let newSizes = this.columnLayout.resizeColumnWidth(this.virtualizer.visibleRect.width, this.collection, newControlled, this.uncontrolledWidths, key, width);
101101

@@ -110,7 +110,7 @@ export class TableLayout<T> extends ListLayout<T> {
110110
return newSizes;
111111
}
112112

113-
onColumnResizeEnd(): void {
113+
endResize(): void {
114114
this.resizingColumn = null;
115115
}
116116

packages/@react-stately/table/src/useTableColumnResizeState.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ export interface TableColumnResizeState<T> {
3232
* Called to update the state that a resize event has occurred.
3333
* Returns the new widths for all columns based on the resized column.
3434
*/
35-
onColumnResize: (key: Key, width: number) => Map<Key, ColumnSize>,
35+
updateResizedColumns: (key: Key, width: number) => Map<Key, ColumnSize>,
3636
/** Callback for when onColumnResize has started. */
37-
onColumnResizeStart: (key: Key) => void,
37+
startResize: (key: Key) => void,
3838
/** Callback for when onColumnResize has ended. */
39-
onColumnResizeEnd: () => void,
39+
endResize: () => void,
4040
/** Gets the current width for the specified column. */
4141
getColumnWidth: (key: Key) => number,
4242
/** Gets the current minWidth for the specified column. */
@@ -87,11 +87,11 @@ export function useTableColumnResizeState<T>(props: TableColumnResizeStateProps<
8787
columnLayout.recombineColumns(state.collection.columns, uncontrolledWidths, uncontrolledColumns, controlledColumns)
8888
, [state.collection.columns, uncontrolledWidths, uncontrolledColumns, controlledColumns, columnLayout]);
8989

90-
let onColumnResizeStart = useCallback((key: Key) => {
90+
let startResize = useCallback((key: Key) => {
9191
setResizingColumn(key);
9292
}, [setResizingColumn]);
9393

94-
let onColumnResize = useCallback((key: Key, width: number): Map<Key, ColumnSize> => {
94+
let updateResizedColumns = useCallback((key: Key, width: number): Map<Key, ColumnSize> => {
9595
let newControlled = new Map(Array.from(controlledColumns).map(([key, entry]) => [key, entry.props.width]));
9696
let newSizes = columnLayout.resizeColumnWidth(tableWidth, state.collection, newControlled, uncontrolledWidths, key, width);
9797

@@ -101,7 +101,7 @@ export function useTableColumnResizeState<T>(props: TableColumnResizeStateProps<
101101
return newSizes;
102102
}, [controlledColumns, uncontrolledColumns, setUncontrolledWidths, tableWidth, columnLayout, state.collection, uncontrolledWidths]);
103103

104-
let onColumnResizeEnd = useCallback(() => {
104+
let endResize = useCallback(() => {
105105
setResizingColumn(null);
106106
}, [setResizingColumn]);
107107

@@ -111,9 +111,9 @@ export function useTableColumnResizeState<T>(props: TableColumnResizeStateProps<
111111

112112
return useMemo(() => ({
113113
resizingColumn,
114-
onColumnResize,
115-
onColumnResizeStart,
116-
onColumnResizeEnd,
114+
updateResizedColumns,
115+
startResize,
116+
endResize,
117117
getColumnWidth: (key: Key) =>
118118
columnLayout.getColumnWidth(key),
119119
getColumnMinWidth: (key: Key) =>
@@ -125,9 +125,9 @@ export function useTableColumnResizeState<T>(props: TableColumnResizeStateProps<
125125
}), [
126126
columnLayout,
127127
resizingColumn,
128-
onColumnResize,
129-
onColumnResizeStart,
130-
onColumnResizeEnd,
128+
updateResizedColumns,
129+
startResize,
130+
endResize,
131131
columnWidths,
132132
state
133133
]);

0 commit comments

Comments
 (0)