Skip to content

Commit be92ac0

Browse files
authored
Numberfield only change in response to vertical scrolling (#1530)
* Numberfield only change in response to vertical scrolling * fix test that was broken
1 parent 1b9d155 commit be92ac0

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

packages/@react-aria/numberfield/src/useNumberField.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ export function useNumberField(props: AriaNumberFieldProps, state: NumberFieldSt
123123

124124
if (e.deltaY > 0) {
125125
increment();
126-
} else {
126+
} else if (e.deltaY < 0) {
127127
decrement();
128128
}
129129
}, [isReadOnly, isDisabled, decrement, increment]);

packages/@react-spectrum/numberfield/test/NumberField.test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -392,8 +392,6 @@ describe('NumberField', function () {
392392
act(() => {textField.focus();});
393393
fireEvent.wheel(textField, {deltaY: -10});
394394
expect(onChangeSpy).toHaveBeenCalledWith(-1);
395-
fireEvent.wheel(textField, {deltaX: -10});
396-
expect(onChangeSpy).toHaveBeenLastCalledWith(-2);
397395
act(() => {textField.blur();});
398396
});
399397

0 commit comments

Comments
 (0)