Do not add random prefix to ids during tests in React 18 (#4869)

Author: devongovett

packages/@react-aria/ssr/package.json

@@ -29,5 +29,16 @@
   },
   "publishConfig": {
     "access": "public"
+  },
+  "engines": {
+    "node": ">= 12"
+  },
+  "targets": {
+    "main": {
+      "context": "node"
+    },
+    "module": {
+      "context": "node"
+    }
   }
 }

packages/@react-aria/ssr/src/SSRProvider.tsx

@@ -152,14 +152,15 @@ function useLegacySSRSafeId(defaultId?: string): string {
   }
 
   let counter = useCounter(!!defaultId);
-  return defaultId || `react-aria${ctx.prefix}-${counter}`;
+  let prefix = ctx === defaultContext && process.env.NODE_ENV === 'test' ? 'react-aria' : `react-aria${ctx.prefix}`;
+  return defaultId || `${prefix}-${counter}`;
 }
 
 function useModernSSRSafeId(defaultId?: string): string {
   // @ts-ignore
   let id = React.useId();
   let [didSSR] = useState(useIsSSR());
-  let prefix = didSSR ? 'react-aria' : `react-aria${defaultContext.prefix}`;
+  let prefix = didSSR || process.env.NODE_ENV === 'test' ? 'react-aria' : `react-aria${defaultContext.prefix}`;
   return defaultId || `${prefix}-${id}`;
 }
 

packages/@react-aria/ssr/test/SSRProvider.test.js

@@ -118,7 +118,18 @@ describe('SSRProvider', function () {
   });
 
   it('should generate a random prefix when not server rendered', function () {
+    let env = process.env.NODE_ENV;
+    process.env.NODE_ENV = 'production';
     let tree = render(<Test />);
     expect(/^react-aria\d+-/.test(tree.getByTestId('test').id)).toBe(true);
+    process.env.NODE_ENV = env;
+  });
+
+  it('should not generate a random prefix in tests', function () {
+    let env = process.env.NODE_ENV;
+    process.env.NODE_ENV = 'test';
+    let tree = render(<Test />);
+    expect(/^react-aria-/.test(tree.getByTestId('test').id)).toBe(true);
+    process.env.NODE_ENV = env;
   });
 });