Fix RAC submenu flipping (#5808)

* fix submenu flip positioning

we need to wait til the collection is computed, otherwise the overlay has a height of 0 and we get an inaccurate position due to a premature max height being applied

* updating the container padding for the submenu in RAC

if we let the default of 12 get applied, the positioning is slightly strange when submenu trigger is at the bottom of the boundary

* clear the max height on the overlay so we always get a proper position calculation on every render

* forgot to reset some changes

* adding a comment for posterity

* revert containerPadding set

Author: LFDanLu

packages/@react-aria/overlays/src/useOverlayPosition.ts

@@ -143,6 +143,12 @@ export function useOverlayPosition(props: AriaPositionProps): PositionAria {
       return;
     }
 
+    // Always reset the overlay's previous max height if not defined by the user so that we can compensate for
+    // RAC collections populating after a second render and properly set a correct max height + positioning when it populates.
+    if (!maxHeight && overlayRef.current) {
+      (overlayRef.current as HTMLElement).style.maxHeight = 'none';
+    }
+
     let position = calculatePosition({
       placement: translateRTL(placement, direction),
       overlayNode: overlayRef.current,

packages/react-aria-components/src/Menu.tsx

@@ -92,7 +92,7 @@ export interface SubmenuTriggerProps {
 
 /**
  * A submenu trigger is used to wrap a submenu's trigger item and the submenu itself.
- * 
+ *
  * @version alpha
  */
 export function SubmenuTrigger(props: SubmenuTriggerProps, ref: ForwardedRef<HTMLDivElement>): JSX.Element | null {
@@ -247,13 +247,13 @@ function MenuSection<T>({section, className, style, ...otherProps}: MenuSectionP
 export interface MenuItemRenderProps extends ItemRenderProps {
   /**
    * Whether the item has a submenu.
-   * 
+   *
    * @selector [data-has-submenu]
    */
   hasSubmenu: boolean,
   /**
    * Whether the item's submenu is open.
-   * 
+   *
    * @selector [data-open]
    */
   isOpen: boolean