Revert "Update useControlledState for StrictMode" (#2265)

Author: dkario

packages/@react-stately/utils/src/useControlledState.ts

@@ -43,10 +43,19 @@ export function useControlledState<T>(
 
     if (typeof value === 'function') {
       // this supports functional updates https://reactjs.org/docs/hooks-reference.html#functional-updates
-      let oldValue = stateRef.current;
-      let interceptedValue = value(oldValue);
-      setStateValue(!isControlled ? interceptedValue : oldValue);
-      onChangeCaller(interceptedValue, ...args);
+      // when someone using useControlledState calls setControlledState(myFunc)
+      // this will call our useState setState with a function as well which invokes myFunc and calls onChange with the value from myFunc
+      // if we're in an uncontrolled state, then we also return the value of myFunc which to setState looks as though it was just called with myFunc from the beginning
+      // otherwise we just return the controlled value, which won't cause a rerender because React knows to bail out when the value is the same
+      let updateFunction = (oldValue, ...functionArgs) => {
+        let interceptedValue = value(isControlled ? stateRef.current : oldValue, ...functionArgs);
+        onChangeCaller(interceptedValue, ...args);
+        if (!isControlled) {
+          return interceptedValue;
+        }
+        return oldValue;
+      };
+      setStateValue(updateFunction);
     } else {
       if (!isControlled) {
         setStateValue(value);