Skip to content

Commit e624164

Browse files
authored
fix(s2): Display checkmark on selected menu items that are links (#7532)
1 parent c8bcc04 commit e624164

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/@react-spectrum/s2/src/Menu.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -487,8 +487,8 @@ export function MenuItem(props: MenuItemProps) {
487487
[KeyboardContext, {styles: keyboard({size, isDisabled: renderProps.isDisabled})}],
488488
[ImageContext, {styles: image({size})}]
489489
]}>
490-
{renderProps.selectionMode === 'single' && !isLink && !renderProps.hasSubmenu && <CheckmarkIcon size={checkmarkIconSize[size]} className={checkmark({...renderProps, size})} />}
491-
{renderProps.selectionMode === 'multiple' && !isLink && !renderProps.hasSubmenu && (
490+
{renderProps.selectionMode === 'single' && !renderProps.hasSubmenu && <CheckmarkIcon size={checkmarkIconSize[size]} className={checkmark({...renderProps, size})} />}
491+
{renderProps.selectionMode === 'multiple' && !renderProps.hasSubmenu && (
492492
<div className={mergeStyles(checkbox, box(checkboxRenderProps))}>
493493
<CheckmarkIcon size={size} className={iconStyles} />
494494
</div>

packages/@react-spectrum/s2/stories/Menu.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ export const PublishAndExport: Story = {
152152
},
153153
args: {
154154
selectionMode: 'none',
155-
selectedKeys: ['quick-export'],
155+
selectedKeys: ['share'],
156156
disabledKeys: ['livestream']
157157
}
158158
};

0 commit comments

Comments
 (0)