Skip to content

Commit f759517

Browse files
authored
fix: icon builder ci (#8374)
* fix: verdaccio icon builder test * turn on verdaccio * loosen another range * one more * add debugging statements * more debugging * revert and change the versioning * fix lock file * add parcel-namer-s2 * try adding dependency directly * now that we have patches, move back to npx * reset file * Revert "turn on verdaccio" This reverts commit 5d4025e.
1 parent 8573562 commit f759517

File tree

4 files changed

+8
-25
lines changed

4 files changed

+8
-25
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
"@parcel/transformer-svg-react": "^2.14.0",
100100
"@parcel/transformer-typescript-types": "^2.14.0",
101101
"@react-spectrum/parcel-namer-s2": "^0.3.0",
102-
"@react-spectrum/s2-icon-builder": "^0.2.0",
102+
"@react-spectrum/s2-icon-builder": "^0.3.0",
103103
"@spectrum-css/component-builder": "workspace:^",
104104
"@spectrum-css/vars": "^2.3.0",
105105
"@storybook/addon-a11y": "patch:@storybook/addon-a11y@npm%3A^7.6.19#~/.yarn/patches/@storybook-addon-a11y-npm-7.6.19-04b470eae0.patch",

scripts/verdaccio-build-icon-builder.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ output="output.out"
66

77
set -e
88

9-
echo "Building docs with verdaccio"
9+
echo "Building icons with verdaccio"
1010

1111
# Wait for verdaccio to start
1212
grep -q 'http address' <(tail -f $output)
@@ -39,7 +39,9 @@ cd examples/s2-webpack-5-example
3939
mkdir icon-test
4040
cp ../../packages/@react-spectrum/s2/s2wf-icons/S2_Icon_3D_20_N.svg icon-test/S2_Icon_3D_20_N.svg
4141
npx @react-spectrum/s2-icon-builder -i ./icon-test/S2_Icon_3D_20_N.svg -o ./icon-dist
42+
echo 'concluded icon builder'
4243

44+
echo 'testing icon builder library'
4345
mkdir icon-library-test
4446
touch icon-library-test/package.json
4547
cat > icon-library-test/package.json << EOF
@@ -65,7 +67,7 @@ cat > icon-library-test/package.json << EOF
6567
"react-dom": "^18.0.0 || ^19.0.0-rc.1"
6668
},
6769
"devDependencies": {
68-
"@react-spectrum/s2-icon-builder": ">=0.2.3",
70+
"@react-spectrum/s2-icon-builder": "latest",
6971
"@react-spectrum/s2": "latest",
7072
"react": "^19.0.0",
7173
"react-dom": "^19.0.0"

scripts/verdaccio-generate-versions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ process.stdin.on('end', () => {
2727
const packageName = location.split('/').pop();
2828
// Only include specific dev tools
2929
if (['optimize-locales-plugin', 'parcel-resolver-optimize-locales', 'codemods',
30-
'parcel-transformer-s2-icon', 's2-icon-builder', 'ts-plugin'].includes(packageName)) {
30+
'parcel-transformer-s2-icon', 's2-icon-builder', 'ts-plugin', 'parcel-namer-s2'].includes(packageName)) {
3131
acc[workspace.name] = 'patch';
3232
}
3333
return acc;

yarn.lock

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7940,26 +7940,7 @@ __metadata:
79407940
languageName: unknown
79417941
linkType: soft
79427942

7943-
"@react-spectrum/s2-icon-builder@npm:^0.2.0":
7944-
version: 0.2.4
7945-
resolution: "@react-spectrum/s2-icon-builder@npm:0.2.4"
7946-
dependencies:
7947-
"@parcel/bundler-library": "npm:^2.14.0"
7948-
"@parcel/compressor-raw": "npm:^2.14.0"
7949-
"@parcel/core": "npm:^2.14.0"
7950-
"@parcel/namer-default": "npm:^2.14.0"
7951-
"@parcel/packager-raw": "npm:^2.14.0"
7952-
"@parcel/reporter-cli": "npm:^2.14.0"
7953-
"@parcel/resolver-default": "npm:^2.14.0"
7954-
"@parcel/transformer-raw": "npm:^2.14.0"
7955-
"@react-spectrum/parcel-transformer-s2-icon": "npm:^0.3.0"
7956-
bin:
7957-
transform-icons: index.js
7958-
checksum: 10c0/f24669f8351700d547dffe0a1f5030db4ce24f3d952958dcdef8d9d64c11705ab448bbdcc24e864ecd712609b13d31fa1070474b7abed5bca5de986f7515a447
7959-
languageName: node
7960-
linkType: hard
7961-
7962-
"@react-spectrum/s2-icon-builder@workspace:packages/dev/s2-icon-builder":
7943+
"@react-spectrum/s2-icon-builder@npm:^0.3.0, @react-spectrum/s2-icon-builder@workspace:packages/dev/s2-icon-builder":
79637944
version: 0.0.0-use.local
79647945
resolution: "@react-spectrum/s2-icon-builder@workspace:packages/dev/s2-icon-builder"
79657946
dependencies:
@@ -27750,7 +27731,7 @@ __metadata:
2775027731
"@parcel/transformer-svg-react": "npm:^2.14.0"
2775127732
"@parcel/transformer-typescript-types": "npm:^2.14.0"
2775227733
"@react-spectrum/parcel-namer-s2": "npm:^0.3.0"
27753-
"@react-spectrum/s2-icon-builder": "npm:^0.2.0"
27734+
"@react-spectrum/s2-icon-builder": "npm:^0.3.0"
2775427735
"@spectrum-css/component-builder": "workspace:^"
2775527736
"@spectrum-css/vars": "npm:^2.3.0"
2775627737
"@storybook/addon-a11y": "patch:@storybook/addon-a11y@npm%3A^7.6.19#~/.yarn/patches/@storybook-addon-a11y-npm-7.6.19-04b470eae0.patch"

0 commit comments

Comments
 (0)