Skip to content

Commit f77299e

Browse files
ktaborsdannify
andauthored
Fixing disabled checkbox active state in Firefox (#2582)
* adding specificity for disabled and active for Firefox * adding some stories to better test disabled checked checkboxes Co-authored-by: Danni <[email protected]>
1 parent e9562b2 commit f77299e

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

packages/@adobe/spectrum-css-temp/components/checkbox/skin.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,8 @@ governing permissions and limitations under the License.
8989

9090
.spectrum-Checkbox .spectrum-Checkbox-input,
9191
.spectrum-Checkbox .spectrum-Checkbox-input:checked {
92-
&:disabled + .spectrum-Checkbox-box {
92+
&:disabled + .spectrum-Checkbox-box,
93+
&:disabled:active + .spectrum-Checkbox-box {
9394
&:before {
9495
border-color: var(--spectrum-checkbox-emphasized-box-border-color-disabled);
9596
background-color: var(--spectrum-checkbox-emphasized-box-background-color-disabled);

packages/@react-spectrum/checkbox/stories/CheckboxGroup.stories.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,14 @@ storiesOf('CheckboxGroup', module)
5858
'isDisabled on one checkbox',
5959
() => render({}, [{}, {isDisabled: true}, {}])
6060
)
61+
.add(
62+
'isDisabled two checkboxes and one checked',
63+
() => render({defaultValue: ['dragons']}, [{}, {isDisabled: true}, {isDisabled: true}])
64+
)
65+
.add(
66+
'isEmphasized, isDisabled two checkboxes and one checked',
67+
() => render({isEmphasized: true, defaultValue: ['dragons']}, [{}, {isDisabled: true}, {isDisabled: true}])
68+
)
6169
.add(
6270
'isDisabled on one checkbox horizontal',
6371
() => render({orientation: 'horizontal'}, [{}, {isDisabled: true}, {}])

0 commit comments

Comments
 (0)