Skip to content

Commit fdf48d2

Browse files
authored
chore: Reduce production bundle sizes (#7977)
1 parent a45c71c commit fdf48d2

File tree

45 files changed

+95
-65
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+95
-65
lines changed

packages/@react-aria/interactions/src/PressResponder.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,12 @@ export const PressResponder = React.forwardRef(({children, ...props}: PressRespo
3939

4040
useEffect(() => {
4141
if (!isRegistered.current) {
42-
console.warn(
43-
'A PressResponder was rendered without a pressable child. ' +
44-
'Either call the usePress hook, or wrap your DOM node with <Pressable> component.'
45-
);
42+
if (process.env.NODE_ENV !== 'production') {
43+
console.warn(
44+
'A PressResponder was rendered without a pressable child. ' +
45+
'Either call the usePress hook, or wrap your DOM node with <Pressable> component.'
46+
);
47+
}
4648
isRegistered.current = true; // only warn once in strict mode.
4749
}
4850
}, []);

packages/@react-aria/interactions/src/Pressable.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ export const Pressable = React.forwardRef(({children, ...props}: PressableProps,
2727
let child = React.Children.only(children);
2828

2929
useEffect(() => {
30+
if (process.env.NODE_ENV === 'production') {
31+
return;
32+
}
33+
3034
let el = ref.current;
3135
if (!el || !(el instanceof getOwnerWindow(el).Element)) {
3236
console.error('<Pressable> child must forward its ref to a DOM element.');

packages/@react-aria/interactions/src/createEventHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export function createEventHandler<T extends SyntheticEvent>(handler?: (e: BaseE
3232
return e.isDefaultPrevented();
3333
},
3434
stopPropagation() {
35-
if (shouldStopPropagation) {
35+
if (shouldStopPropagation && process.env.NODE_ENV !== 'production') {
3636
console.error('stopPropagation is now the default behavior for events in React Spectrum. You can use continuePropagation() to revert this behavior.');
3737
} else {
3838
shouldStopPropagation = true;

packages/@react-aria/interactions/src/useFocusVisible.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ function setupGlobalFocusEvents(element?: HTMLElement | null) {
153153
documentObject.addEventListener('pointerdown', handlePointerEvent, true);
154154
documentObject.addEventListener('pointermove', handlePointerEvent, true);
155155
documentObject.addEventListener('pointerup', handlePointerEvent, true);
156-
} else {
156+
} else if (process.env.NODE_ENV === 'test') {
157157
documentObject.addEventListener('mousedown', handlePointerEvent, true);
158158
documentObject.addEventListener('mousemove', handlePointerEvent, true);
159159
documentObject.addEventListener('mouseup', handlePointerEvent, true);
@@ -189,7 +189,7 @@ const tearDownWindowFocusTracking = (element, loadListener?: () => void) => {
189189
documentObject.removeEventListener('pointerdown', handlePointerEvent, true);
190190
documentObject.removeEventListener('pointermove', handlePointerEvent, true);
191191
documentObject.removeEventListener('pointerup', handlePointerEvent, true);
192-
} else {
192+
} else if (process.env.NODE_ENV === 'test') {
193193
documentObject.removeEventListener('mousedown', handlePointerEvent, true);
194194
documentObject.removeEventListener('mousemove', handlePointerEvent, true);
195195
documentObject.removeEventListener('mouseup', handlePointerEvent, true);

packages/@react-aria/interactions/src/useFocusable.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ export const Focusable = forwardRef(({children, ...props}: FocusableComponentPro
112112
let child = React.Children.only(children);
113113

114114
useEffect(() => {
115+
if (process.env.NODE_ENV === 'production') {
116+
return;
117+
}
118+
115119
let el = ref.current;
116120
if (!el || !(el instanceof getOwnerWindow(el).Element)) {
117121
console.error('<Focusable> child must forward its ref to a DOM element.');

packages/@react-aria/interactions/src/useHover.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ function setupGlobalTouchEvents() {
6161

6262
if (typeof PointerEvent !== 'undefined') {
6363
document.addEventListener('pointerup', handleGlobalPointerEvent);
64-
} else {
64+
} else if (process.env.NODE_ENV === 'test') {
6565
document.addEventListener('touchend', setGlobalIgnoreEmulatedMouseEvents);
6666
}
6767

@@ -74,7 +74,7 @@ function setupGlobalTouchEvents() {
7474

7575
if (typeof PointerEvent !== 'undefined') {
7676
document.removeEventListener('pointerup', handleGlobalPointerEvent);
77-
} else {
77+
} else if (process.env.NODE_ENV === 'test') {
7878
document.removeEventListener('touchend', setGlobalIgnoreEmulatedMouseEvents);
7979
}
8080
};
@@ -182,7 +182,7 @@ export function useHover(props: HoverProps): HoverResult {
182182
triggerHoverEnd(e, e.pointerType);
183183
}
184184
};
185-
} else {
185+
} else if (process.env.NODE_ENV === 'test') {
186186
hoverProps.onTouchStart = () => {
187187
state.ignoreEmulatedMouseEvents = true;
188188
};

packages/@react-aria/interactions/src/useInteractOutside.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export function useInteractOutside(props: InteractOutsideProps): void {
7979
documentObject.removeEventListener('pointerdown', onPointerDown, true);
8080
documentObject.removeEventListener('pointerup', onPointerUp, true);
8181
};
82-
} else {
82+
} else if (process.env.NODE_ENV === 'test') {
8383
let onMouseUp = (e) => {
8484
if (state.ignoreEmulatedMouseEvents) {
8585
state.ignoreEmulatedMouseEvents = false;

packages/@react-aria/interactions/src/useMove.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ export function useMove(props: MoveEvents): MoveResult {
151151
addGlobalListener(window, 'touchend', onTouchEnd, false);
152152
addGlobalListener(window, 'touchcancel', onTouchEnd, false);
153153
};
154-
} else {
154+
} else if (process.env.NODE_ENV === 'test') {
155155
let onPointerMove = (e: PointerEvent) => {
156156
if (e.pointerId === state.current.id) {
157157
let pointerType = (e.pointerType || 'mouse') as PointerType;

packages/@react-aria/interactions/src/usePress.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -576,8 +576,8 @@ export function usePress(props: PressHookProps): PressResult {
576576
// Safari does not call onPointerCancel when a drag starts, whereas Chrome and Firefox do.
577577
cancel(e);
578578
};
579-
} else {
580-
// NOTE: this fallback branch is almost entirely used by unit tests.
579+
} else if (process.env.NODE_ENV === 'test') {
580+
// NOTE: this fallback branch is entirely used by unit tests.
581581
// All browsers now support pointer events, but JSDOM still does not.
582582

583583
pressProps.onMouseDown = (e) => {

packages/@react-aria/label/src/useLabel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export function useLabel(props: LabelAriaProps): LabelAria {
5252
id: labelId,
5353
htmlFor: labelElementType === 'label' ? id : undefined
5454
};
55-
} else if (!ariaLabelledby && !ariaLabel) {
55+
} else if (!ariaLabelledby && !ariaLabel && process.env.NODE_ENV !== 'production') {
5656
console.warn('If you do not provide a visible label, you must specify an aria-label or aria-labelledby attribute for accessibility');
5757
}
5858

0 commit comments

Comments
 (0)