docs: remove smooth behavior from SideNav autoscroll#9828
Open
reidbarber wants to merge 3 commits intomainfrom
Open
docs: remove smooth behavior from SideNav autoscroll#9828reidbarber wants to merge 3 commits intomainfrom
reidbarber wants to merge 3 commits intomainfrom
Conversation
|
Build successful! 🎉 |
devongovett
reviewed
Mar 23, 2026
| } | ||
|
|
||
| link.scrollIntoView({block: 'start', behavior: 'smooth'}); | ||
| link.scrollIntoView({block: 'start'}); |
Member
There was a problem hiding this comment.
I noticed that it scrolls even when you click on a link in the sidebar. For example scroll down and then click a link near the top, it will move when you click it. Maybe we should only do this on the initial page load?
Contributor
There was a problem hiding this comment.
If I understand what you mean correctly, this should be fixed when using our shim here instead, as that implements the equivalent of scrollIntoViewIfNeeded.
|
Build successful! 🎉 |
snowystinger
approved these changes
Mar 27, 2026
LFDanLu
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes smooth behavior from SideNav auto-scroll.
✅ Pull Request Checklist:
📝 Test Instructions:
Open a page like Testing and confirm that auto-scrolling is no longer smooth.
🧢 Your Project: