fix(data-access): support both snake_case and camelCase in BROKEN_BAC… (#1336)

…KLINKS schema

- Add support for both url_from/urlFrom and url_to/urlTo
- Use Joi .or() validation to require at least one naming convention
- Update minimal projection to include all field name variants
- Ensures compatibility with both Ahrefs API (snake_case) and internal
data (camelCase)

Please ensure your pull request adheres to the following guidelines:
- [ ] make sure to link the related issues in this description
- [ ] when merging / squashing, make sure the fixed issue references are
visible in the commits, for easy compilation of release notes

## Related Issues


Thanks for contributing!

---------

Co-authored-by: Kanishka <kanishka@adobe.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

Author: 3 people

packages/spacecat-shared-data-access/src/models/suggestion/suggestion.data-schemas.js

@@ -350,35 +350,46 @@ export const DATA_SCHEMAS = {
   },
   [OPPORTUNITY_TYPES.BROKEN_BACKLINKS]: {
     schema: Joi.object({
-      url_from: Joi.string().uri().required(),
-      url_to: Joi.string().uri().required(),
+      url_from: Joi.string().uri().optional(),
+      urlFrom: Joi.string().uri().optional(),
+      url_to: Joi.string().uri().optional(),
+      urlTo: Joi.string().uri().optional(),
       title: Joi.string().optional(),
       traffic_domain: Joi.number().optional(),
       aiRationale: Joi.string().optional(),
       urlsSuggested: Joi.array().items(Joi.string().uri()).optional(),
       aggregationKey: Joi.string().allow(null).optional(),
-    }).unknown(true),
+    })
+      .or('url_from', 'urlFrom') // At least one of these must be present
+      .or('url_to', 'urlTo') // At least one of these must be present
+      .unknown(true),
     projections: {
       minimal: {
-        fields: ['url_from', 'url_to'],
+        fields: ['url_from', 'url_to', 'urlFrom', 'urlTo'],
         transformers: {},
       },
     },
   },
   [OPPORTUNITY_TYPES.BROKEN_INTERNAL_LINKS]: {
     schema: Joi.object({
-      urlFrom: Joi.string().uri().required(),
-      urlTo: Joi.string().uri().required(),
+      // Support both naming conventions (snake_case and camelCase)
+      url_from: Joi.string().uri().optional(),
+      urlFrom: Joi.string().uri().optional(),
+      url_to: Joi.string().uri().optional(),
+      urlTo: Joi.string().uri().optional(),
       title: Joi.string().optional(),
       urlsSuggested: Joi.array().items(Joi.string().uri()).optional(),
       aiRationale: Joi.string().optional(),
       trafficDomain: Joi.number().optional(),
       priority: Joi.string().optional(),
       aggregationKey: Joi.string().allow(null).optional(),
-    }).unknown(true),
+    })
+      .or('url_from', 'urlFrom') // At least one of these must be present
+      .or('url_to', 'urlTo') // At least one of these must be present
+      .unknown(true),
     projections: {
       minimal: {
-        fields: ['urlFrom', 'urlTo'],
+        fields: ['url_from', 'url_to', 'urlFrom', 'urlTo'],
         transformers: {},
       },
     },

packages/spacecat-shared-data-access/src/models/suggestion/suggestion.projection-utils.js

@@ -104,6 +104,7 @@ export const FALLBACK_PROJECTION = {
       'path',
       'sourceUrl',
       'destinationUrl',
+      'trendData', // Web Performance Trends: [{ date, good, needsImprovement, poor }] for header cards
     ],
     transformers: {},
   },

packages/spacecat-shared-data-access/test/unit/models/suggestion/suggestion.projection-utils.test.js

@@ -157,8 +157,9 @@ describe('Suggestion Projection Utils', () => {
       expect(fields).to.not.include('issues');
     });
 
-    it('has exactly 14 URL-related fields', () => {
-      expect(FALLBACK_PROJECTION.minimal.fields).to.have.lengthOf(14);
+    it('has expected URL-related and trend fields', () => {
+      expect(FALLBACK_PROJECTION.minimal.fields).to.have.lengthOf(15);
+      expect(FALLBACK_PROJECTION.minimal.fields).to.include('trendData');
     });
   });
 });