fix(data-access): surface PG error details in logs and stop leaking credentials

#logAndThrowError was passing `this` (the entire BaseCollection instance
including JWT headers) as DataAccessError details, leaking credentials to
logs. PG error fields (code, message, details, hint) were never surfaced
in the log string — only visible in Coralogix deep serialization.

- Rewrite #logAndThrowError to read code/message/details/hint directly
  from the PostgrestError cause and log a human-readable string
- Pass { entityName, tableName } instead of `this` as DataAccessError details
- Fix updateByKeys and batchGetByKeys to use #logAndThrowError for
  consistent error logging instead of direct throw

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: ekremney

packages/spacecat-shared-data-access/src/models/base/base.collection.js

@@ -104,21 +104,29 @@ class BaseCollection {
   #isInvalidInputError(error) {
     let current = error;
     while (current) {
-      if (current?.code === '22P02') {
-        return true;
-      }
+      if (current?.code === '22P02') return true;
       current = current.cause;
     }
     return false;
   }
 
   #logAndThrowError(message, cause) {
-    const error = new DataAccessError(message, this, cause);
-    this.log.error(`Base Collection Error [${this.entityName}]`, error);
-    if (isNonEmptyArray(error.cause?.fields)) {
-      this.log.error(`Validation errors: ${JSON.stringify(error.cause.fields)}`);
+    const parts = [message];
+    if (cause?.code) parts.push(`[${cause.code}] ${cause.message}`);
+    if (cause?.details) parts.push(cause.details);
+    if (cause?.hint) parts.push(`hint: ${cause.hint}`);
+
+    this.log.error(`[${this.entityName}] ${parts.join(' - ')}`);
+
+    if (isNonEmptyArray(cause?.fields)) {
+      this.log.error(`Validation errors: ${JSON.stringify(cause.fields)}`);
     }
-    throw error;
+
+    throw new DataAccessError(
+      message,
+      { entityName: this.entityName, tableName: this.tableName },
+      cause,
+    );
   }
 
   #initializeCollectionMethods() {
@@ -601,6 +609,7 @@ class BaseCollection {
     return isNonEmptyObject(item);
   }
 
+  // eslint-disable-next-line consistent-return
   async batchGetByKeys(keys, options = {}) {
     guardArray('keys', keys, this.entityName, 'any');
 
@@ -677,8 +686,11 @@ class BaseCollection {
         unprocessed: [],
       };
     } catch (error) {
-      this.log.error(`Failed to batch get by keys [${this.entityName}]`, error);
-      throw new DataAccessError('Failed to batch get by keys', this, error);
+      /* c8 ignore next 3 -- re-throw guard for already-wrapped errors */
+      if (error instanceof DataAccessError) {
+        throw error;
+      }
+      this.#logAndThrowError('Failed to batch get by keys', error);
     }
   }
 
@@ -856,7 +868,7 @@ class BaseCollection {
 
     const { error } = await query.select().maybeSingle();
     if (error) {
-      throw new DataAccessError('Failed to update entity', this, error);
+      this.#logAndThrowError('Failed to update entity', error);
     }
   }
 

packages/spacecat-shared-data-access/test/unit/models/base/base.collection.test.js

@@ -1191,7 +1191,9 @@ describe('BaseCollection', () => {
       });
 
       await expect(baseCollectionInstance.batchGetByKeys(keys)).to.be.rejectedWith(DataAccessError);
-      expect(mockLogger.error).to.have.been.calledWith('Failed to batch get by keys [mockEntityModel]', error);
+      expect(mockLogger.error).to.have.been.calledWith(
+        sinon.match('[mockEntityModel] Failed to batch get by keys'),
+      );
     });
 
     it('should handle null records in results', async () => {
@@ -1410,10 +1412,9 @@ describe('BaseCollection', () => {
       await expect(baseCollectionInstance.removeByIndexKeys(keys))
         .to.be.rejectedWith(DataAccessError, 'Failed to remove by index keys');
 
-      // The error logging uses the format "Base Collection Error [entityName]"
+      // The error logging surfaces the error message with entity context
       expect(mockLogger.error).to.have.been.calledWith(
-        'Base Collection Error [mockEntityModel]',
-        sinon.match.instanceOf(DataAccessError),
+        sinon.match('[mockEntityModel] Failed to remove by index keys'),
       );
     });