Skip to content

Commit 1d415bf

Browse files
authored
docs(textfield,stepper): storybook - allow ids for textfield and stepper (#2271)
* docs(textfield): add arg to storybook for input id Add ability to pass in an ID for the Text field input. Needed for components such as Label that can refer to this ID. * docs(stepper): storybook - use an id on its input Also set an ID on the input created by Stepper when an ID is passed in.
1 parent 5eb391c commit 1d415bf

File tree

2 files changed

+39
-31
lines changed

2 files changed

+39
-31
lines changed

components/stepper/stories/template.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { html } from "lit";
22
import { classMap } from "lit/directives/class-map.js";
3-
import { styleMap } from "lit/directives/style-map.js";
43
import { ifDefined } from "lit/directives/if-defined.js";
4+
import { styleMap } from "lit/directives/style-map.js";
55

6-
import { Template as Textfield } from "@spectrum-css/textfield/stories/template.js";
76
import { Template as InfieldButton } from "@spectrum-css/infieldbutton/stories/template.js";
7+
import { Template as Textfield } from "@spectrum-css/textfield/stories/template.js";
88

99
import "../index.css";
1010

@@ -74,6 +74,7 @@ export const Template = ({
7474
value: "0",
7575
isDisabled,
7676
isQuiet,
77+
id: id ? `${id}-input` : undefined,
7778
customClasses: [`${rootClass}-textfield`],
7879
customInputClasses: [`${rootClass}-input`],
7980
})}

components/textfield/stories/template.js

Lines changed: 36 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,11 @@ export const Template = ({
2828
isReadOnly = false,
2929
isKeyboardFocused = false,
3030
isLoading = false,
31+
iconName,
3132
pattern,
3233
placeholder,
3334
name,
34-
iconName,
35+
id,
3536
value,
3637
type = "text",
3738
autocomplete = true,
@@ -83,6 +84,7 @@ export const Template = ({
8384
: { isFocused: false };
8485
updateArgs(focusClass);
8586
}}
87+
id=${ifDefined(id)}
8688
>
8789
${when(iconName, () => Icon({
8890
...globals,
@@ -95,34 +97,39 @@ export const Template = ({
9597
...customIconClasses,
9698
],
9799
}))}
98-
${when(multiline, () => html`<textarea
99-
placeholder=${ifDefined(placeholder)}
100-
name=${ifDefined(name)}
101-
.value=${ifDefined(value)}
102-
autocomplete=${autocomplete ? undefined : "off"}
103-
?required=${isRequired}
104-
?disabled=${isDisabled}
105-
?readonly=${ifDefined(isReadOnly)}
106-
pattern=${ifDefined(pattern)}
107-
class=${classMap({
108-
[`${rootClass}-input`]: true,
109-
...customInputClasses.reduce((a, c) => ({ ...a, [c]: true }), {}),
110-
})}
111-
/>`, () => html` <input
112-
type=${ifDefined(type)}
113-
placeholder=${ifDefined(placeholder)}
114-
name=${ifDefined(name)}
115-
value=${ifDefined(value)}
116-
autocomplete=${autocomplete ? undefined : "off"}
117-
?required=${isRequired}
118-
?disabled=${isDisabled}
119-
readonly=${ifDefined(isReadOnly ? "readonly" : undefined)}
120-
pattern=${ifDefined(pattern)}
121-
class=${classMap({
122-
[`${rootClass}-input`]: true,
123-
...customInputClasses.reduce((a, c) => ({ ...a, [c]: true }), {}),
124-
})}
125-
/>`)}
100+
${when(multiline,
101+
() => html`<textarea
102+
placeholder=${ifDefined(placeholder)}
103+
name=${ifDefined(name)}
104+
id=${ifDefined(id ? `${id}-input` : undefined)}
105+
.value=${ifDefined(value)}
106+
autocomplete=${autocomplete ? undefined : "off"}
107+
?required=${isRequired}
108+
?disabled=${isDisabled}
109+
?readonly=${ifDefined(isReadOnly)}
110+
pattern=${ifDefined(pattern)}
111+
class=${classMap({
112+
[`${rootClass}-input`]: true,
113+
...customInputClasses.reduce((a, c) => ({ ...a, [c]: true }), {}),
114+
})}
115+
/>`,
116+
() => html`<input
117+
type=${ifDefined(type)}
118+
placeholder=${ifDefined(placeholder)}
119+
name=${ifDefined(name)}
120+
id=${ifDefined(id ? `${id}-input` : undefined)}
121+
.value=${ifDefined(value)}
122+
autocomplete=${autocomplete ? undefined : "off"}
123+
?required=${isRequired}
124+
?disabled=${isDisabled}
125+
?readonly=${ifDefined(isReadOnly)}
126+
pattern=${ifDefined(pattern)}
127+
class=${classMap({
128+
[`${rootClass}-input`]: true,
129+
...customInputClasses.reduce((a, c) => ({ ...a, [c]: true }), {}),
130+
})}
131+
/>`
132+
)}
126133
${when(isLoading, () => ProgressCircle({
127134
isIndeterminate: true,
128135
size: "s",

0 commit comments

Comments
 (0)