Skip to content

Commit 3d5c39a

Browse files
authored
chore(stylelint): remove custom properties; add todo to description (#3286)
1 parent c6205bb commit 3d5c39a

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

.changeset/nine-humans-notice.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@spectrum-css/dial": patch
3+
---
4+
5+
Resolves lint violations for dial by removing unused properties and moving todo comment into stylelint-disable description.

components/dial/index.css

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,15 @@
1414
.spectrum-Dial {
1515
--spectrum-dial-background-color-default: var(--spectrum-gray-100);
1616

17-
--spectrum-dial-handle-marker-color-disabled: var(--spectrum-gray-300);
18-
--spectrum-dial-border-color-disabled: var(--spectrum-gray-300);
19-
2017
--spectrum-dial-handle-marker-color: var(--spectrum-gray-700);
2118
--spectrum-dial-border-color: var(--spectrum-gray-700);
2219

23-
--spectrum-dial-handle-marker-color-down: var(--spectrum-gray-800);
24-
--spectrum-dial-border-color-down: var(--spectrum-gray-800);
2520
--spectrum-dial-handle-marker-color-hover: var(--spectrum-gray-800);
2621
--spectrum-dial-border-color-hover: var(--spectrum-gray-800);
2722

2823
--spectrum-dial-handle-marker-color-key-focus: var(--spectrum-gray-50);
29-
--spectrum-dial-border-color-key-focus: var(--spectrum-gray-50);
3024

3125
--spectrum-dial-handle-marker-color-mouse-focus: var(--spectrum-gray-700);
32-
--spectrum-dial-border-color-mouse-focus: var(--spectrum-gray-700);
3326

3427
--spectrum-dial-min-max-tick-color: var(--spectrum-gray-600);
3528

@@ -237,7 +230,7 @@
237230
padding: 0;
238231
position: absolute;
239232
overflow: hidden;
240-
/* @todo Look into replacing with opacity 0. The tiny opacity value appears to be a workaround for a ChromeVox legacy bug (circa 2018). */
233+
/* stylelint-disable-next-line number-max-precision -- @todo Look into replacing with opacity 0. The tiny opacity value appears to be a workaround for a ChromeVox legacy bug (circa 2018). */
241234
opacity: 0.000001;
242235
cursor: default;
243236
appearance: none;

components/dial/metadata/metadata.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,7 @@
7575
"component": [
7676
"--spectrum-dial-background-color-default",
7777
"--spectrum-dial-border-color",
78-
"--spectrum-dial-border-color-disabled",
79-
"--spectrum-dial-border-color-down",
8078
"--spectrum-dial-border-color-hover",
81-
"--spectrum-dial-border-color-key-focus",
82-
"--spectrum-dial-border-color-mouse-focus",
8379
"--spectrum-dial-border-radius",
8480
"--spectrum-dial-container-width",
8581
"--spectrum-dial-controls-margin",
@@ -90,8 +86,6 @@
9086
"--spectrum-dial-handle-inline-margin",
9187
"--spectrum-dial-handle-marker-border-radius",
9288
"--spectrum-dial-handle-marker-color",
93-
"--spectrum-dial-handle-marker-color-disabled",
94-
"--spectrum-dial-handle-marker-color-down",
9589
"--spectrum-dial-handle-marker-color-hover",
9690
"--spectrum-dial-handle-marker-color-key-focus",
9791
"--spectrum-dial-handle-marker-color-mouse-focus",
@@ -115,7 +109,6 @@
115109
"--spectrum-border-width-200",
116110
"--spectrum-font-size-75",
117111
"--spectrum-gray-100",
118-
"--spectrum-gray-300",
119112
"--spectrum-gray-400",
120113
"--spectrum-gray-50",
121114
"--spectrum-gray-600",

0 commit comments

Comments
 (0)