Skip to content

Commit 4498790

Browse files
authored
chore(accordion, actionbar, actionbutton, actiongroup): apply minor linting fixes (#2612)
1 parent fdd7502 commit 4498790

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

components/accordion/index.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ governing permissions and limitations under the License.
210210
--spectrum-accordion-item-header-bottom-to-text-space: var(
211211
--spectrum-accordion-bottom-to-text-spacious-medium
212212
);
213+
213214
&.spectrum-Accordion--sizeS {
214215
--spectrum-accordion-item-header-line-height: 1.25;
215216
--spectrum-accordion-item-header-top-to-text-space: var(
@@ -382,6 +383,7 @@ governing permissions and limitations under the License.
382383
) / 2
383384
)
384385
);
386+
385387
[dir="rtl"] & {
386388
transform: scaleX(-1);
387389
}
@@ -491,7 +493,9 @@ governing permissions and limitations under the License.
491493
);
492494

493495
/* reset styling if button element is used */
496+
/* stylelint-disable-next-line property-no-vendor-prefix -- todo may no longer be needed */
494497
-webkit-appearance: none;
498+
/* stylelint-disable-next-line property-no-vendor-prefix -- todo may no longer be needed */
495499
-moz-appearance: none;
496500
appearance: none;
497501
border: 0;

components/actionbar/index.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,12 @@ governing permissions and limitations under the License.
8484

8585
/* Take up no space and be invisible when not open */
8686
block-size: 0;
87-
opacity: 0;
87+
opacity: 0%;
8888

8989
&.is-open {
9090
/* add ActionBar bottom margin to height for correct spacing even when sticky */
9191
block-size: calc(var(--mod-actionbar-spacing-outer-edge, var(--spectrum-actionbar-spacing-outer-edge)) + var(--mod-actionbar-height, var(--spectrum-actionbar-height)));
92-
opacity: 1;
92+
opacity: 100%;
9393
}
9494

9595
.spectrum-ActionBar-popover {
@@ -150,6 +150,7 @@ governing permissions and limitations under the License.
150150
.spectrum-ActionGroup {
151151
margin-inline-end: var(--mod-actionbar-spacing-action-group-end, var(--spectrum-actionbar-spacing-action-group-end));
152152
margin-block-start: var(--mod-actionbar-spacing-action-group-top, var(--spectrum-actionbar-spacing-action-group-top));
153+
153154
/* align to end by default */
154155
margin-inline-start: auto;
155156
}
@@ -159,6 +160,7 @@ governing permissions and limitations under the License.
159160
.spectrum-ActionBar-popover {
160161
filter: none;
161162
background-color: var(--mod-actionbar-emphasized-background-color, var(--spectrum-actionbar-emphasized-background-color));
163+
162164
/* border transparent instead of none so WHCM will have visible border */
163165
border-color: transparent;
164166
}

components/actionbutton/stories/template.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ export const Template = ({
3939
try {
4040
if (!express) import(/* webpackPrefetch: true */ "../themes/spectrum.css");
4141
else import(/* webpackPrefetch: true */ "../themes/express.css");
42-
} catch (e) {
42+
}
43+
catch (e) {
4344
console.warn(e);
4445
}
4546

@@ -56,8 +57,8 @@ export const Template = ({
5657
[`${rootClass}--emphasized`]: isEmphasized,
5758
[`${rootClass}--static${capitalize(lowerCase(staticColor))}`]:
5859
typeof staticColor !== "undefined",
59-
[`is-disabled`]: isDisabled,
60-
[`is-selected`]: isSelected,
60+
["is-disabled"]: isDisabled,
61+
["is-selected"]: isSelected,
6162
...customClasses.reduce((a, c) => ({ ...a, [c]: true }), {}),
6263
})}
6364
id=${ifDefined(id)}

components/actiongroup/stories/template.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ export const Template = ({
2323
try {
2424
if (!express) import(/* webpackPrefetch: true */ "../themes/spectrum.css");
2525
else import(/* webpackPrefetch: true */ "../themes/express.css");
26-
} catch (e) {
26+
}
27+
catch (e) {
2728
console.warn(e);
2829
}
2930

0 commit comments

Comments
 (0)