Skip to content

Commit 58871bd

Browse files
Melissa Thompsoncastastrophe
authored andcommitted
feat(tooltip): s2 migration (#2743)
1 parent c3e565f commit 58871bd

File tree

13 files changed

+84
-168
lines changed

13 files changed

+84
-168
lines changed

.changeset/light-years-speak.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
---
2+
"@spectrum-css/tooltip": major
3+
---
4+
5+
feat(tooltip): Spectrum 2 migration
6+
7+
This migration includes updated colors, rounding, a bigger tip, and the removal of variants (only neutral is available in Spectrum 2). As a result of the deprecation of variants, icons have also been removed.
8+
9+
The redesign of the tip, specifically the rounding, required a reworking of how we use clip-path and transform.
10+
11+
Some custom property mods have been removed:
12+
13+
- `--mod-tooltip-background-color-informative`
14+
- `--mod-tooltip-background-color-negative`
15+
- `--mod-tooltip-background-color-positive`
16+
- `--mod-tooltip-icon-spacing-block-start`
17+
- `--mod-tooltip-icon-spacing-inline-end`
18+
- `--mod-tooltip-icon-spacing-inline-start`
19+
- `--mod-tooltip-icon-width`
20+
21+
And one mod has been added:
22+
23+
- `--mod-tooltip-tip-corner-radius`

components/tooltip/dist/metadata.json

Lines changed: 8 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535
".spectrum-Tooltip--end-top.is-open:dir(rtl)",
3636
".spectrum-Tooltip--end.is-open",
3737
".spectrum-Tooltip--end.is-open:dir(rtl)",
38-
".spectrum-Tooltip--info",
39-
".spectrum-Tooltip--info .spectrum-Tooltip-tip",
4038
".spectrum-Tooltip--left",
4139
".spectrum-Tooltip--left .spectrum-Tooltip-tip",
4240
".spectrum-Tooltip--left .spectrum-Tooltip-tip:dir(rtl)",
@@ -49,10 +47,6 @@
4947
".spectrum-Tooltip--left-top .spectrum-Tooltip-tip:dir(rtl)",
5048
".spectrum-Tooltip--left-top.is-open",
5149
".spectrum-Tooltip--left.is-open",
52-
".spectrum-Tooltip--negative",
53-
".spectrum-Tooltip--negative .spectrum-Tooltip-tip",
54-
".spectrum-Tooltip--positive",
55-
".spectrum-Tooltip--positive .spectrum-Tooltip-tip",
5650
".spectrum-Tooltip--right",
5751
".spectrum-Tooltip--right .spectrum-Tooltip-tip",
5852
".spectrum-Tooltip--right .spectrum-Tooltip-tip:dir(rtl)",
@@ -99,7 +93,6 @@
9993
".spectrum-Tooltip--top.is-open",
10094
".spectrum-Tooltip-label",
10195
".spectrum-Tooltip-tip",
102-
".spectrum-Tooltip-typeIcon",
10396
".spectrum-Tooltip.is-open",
10497
".spectrum-Tooltip:lang(ja)",
10598
".spectrum-Tooltip:lang(ko)",
@@ -309,20 +302,12 @@
309302
"--mod-overlay-animation-duration-opened",
310303
"--mod-tooltip-animation-distance",
311304
"--mod-tooltip-background-color-default",
312-
"--mod-tooltip-background-color-informative",
313-
"--mod-tooltip-background-color-negative",
314-
"--mod-tooltip-background-color-positive",
315305
"--mod-tooltip-border-radius",
316306
"--mod-tooltip-cjk-line-height",
317307
"--mod-tooltip-content-color",
318308
"--mod-tooltip-font-size",
319309
"--mod-tooltip-font-weight",
320310
"--mod-tooltip-height",
321-
"--mod-tooltip-icon-height",
322-
"--mod-tooltip-icon-spacing-block-start",
323-
"--mod-tooltip-icon-spacing-inline-end",
324-
"--mod-tooltip-icon-spacing-inline-start",
325-
"--mod-tooltip-icon-width",
326311
"--mod-tooltip-line-height",
327312
"--mod-tooltip-margin",
328313
"--mod-tooltip-max-inline-size",
@@ -332,28 +317,20 @@
332317
"--mod-tooltip-spacing-inline",
333318
"--mod-tooltip-tip-antialiasing-inset",
334319
"--mod-tooltip-tip-block-size",
320+
"--mod-tooltip-tip-corner-radius",
335321
"--mod-tooltip-tip-height-percentage",
336322
"--mod-tooltip-tip-square-size"
337323
],
338324
"component": [
339325
"--spectrum-tooltip-animation-distance",
340326
"--spectrum-tooltip-animation-duration",
341-
"--spectrum-tooltip-backgound-color-default-neutral",
342327
"--spectrum-tooltip-background-color-default",
343-
"--spectrum-tooltip-background-color-informative",
344-
"--spectrum-tooltip-background-color-negative",
345-
"--spectrum-tooltip-background-color-positive",
346328
"--spectrum-tooltip-border-radius",
347329
"--spectrum-tooltip-cjk-line-height",
348330
"--spectrum-tooltip-content-color",
349331
"--spectrum-tooltip-font-size",
350332
"--spectrum-tooltip-font-weight",
351333
"--spectrum-tooltip-height",
352-
"--spectrum-tooltip-icon-height",
353-
"--spectrum-tooltip-icon-spacing-block-start",
354-
"--spectrum-tooltip-icon-spacing-inline-end",
355-
"--spectrum-tooltip-icon-spacing-inline-start",
356-
"--spectrum-tooltip-icon-width",
357334
"--spectrum-tooltip-line-height",
358335
"--spectrum-tooltip-margin",
359336
"--spectrum-tooltip-max-inline-size",
@@ -364,11 +341,10 @@
364341
"--spectrum-tooltip-spacing-inline",
365342
"--spectrum-tooltip-tip-antialiasing-inset",
366343
"--spectrum-tooltip-tip-block-size",
344+
"--spectrum-tooltip-tip-corner-radius",
367345
"--spectrum-tooltip-tip-height",
368346
"--spectrum-tooltip-tip-height-percentage",
369-
"--spectrum-tooltip-tip-inline-size",
370-
"--spectrum-tooltip-tip-square-size",
371-
"--spectrum-tooltip-tip-width"
347+
"--spectrum-tooltip-tip-square-size"
372348
],
373349
"global": [
374350
"--spectrum-animation-duration-0",
@@ -378,24 +354,17 @@
378354
"--spectrum-component-edge-to-text-75",
379355
"--spectrum-component-height-75",
380356
"--spectrum-component-top-to-text-75",
381-
"--spectrum-component-top-to-workflow-icon-75",
382-
"--spectrum-corner-radius-100",
357+
"--spectrum-corner-radius-400",
383358
"--spectrum-font-size-75",
384-
"--spectrum-informative-background-color-default",
385-
"--spectrum-line-height-100",
386-
"--spectrum-negative-background-color-default",
387-
"--spectrum-positive-background-color-default",
359+
"--spectrum-gray-25",
360+
"--spectrum-neutral-background-color-default",
388361
"--spectrum-regular-font-weight",
389-
"--spectrum-text-to-visual-75",
390-
"--spectrum-white",
391-
"--spectrum-workflow-icon-size-50"
362+
"--spectrum-spacing-75"
392363
],
393364
"system-theme": [],
394365
"passthroughs": [],
395366
"high-contrast": [
396367
"--highcontrast-tooltip-background-color-default",
397-
"--highcontrast-tooltip-background-color-informative",
398-
"--highcontrast-tooltip-background-color-negative",
399-
"--highcontrast-tooltip-background-color-positive"
368+
"--highcontrast-tooltip-border-width"
400369
]
401370
}

0 commit comments

Comments
 (0)