Skip to content

Commit 5fae8ab

Browse files
5t3phcastastrophe
authored andcommitted
fix: restore undefined custom properties [part 5] (#3475)
1 parent 2a9cb4a commit 5fae8ab

File tree

11 files changed

+63
-4
lines changed

11 files changed

+63
-4
lines changed

.changeset/hip-spies-try.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"@spectrum-css/datepicker": patch
3+
"@spectrum-css/rating": patch
4+
"@spectrum-css/sidenav": patch
5+
"@spectrum-css/slider": patch
6+
"@spectrum-css/switch": patch
7+
---
8+
9+
Define undefined custom properties from themes directory.

components/datepicker/dist/metadata.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@
122122
"--spectrum-animation-duration-100",
123123
"--spectrum-border-width-100",
124124
"--spectrum-component-edge-to-text-100",
125+
"--spectrum-component-height-100",
125126
"--spectrum-corner-radius-100",
126127
"--spectrum-disabled-border-color",
127128
"--spectrum-disabled-content-color",

components/datepicker/index.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
--spectrum-datepicker-border-radius-quiet: var(--mod-datepicker-border-radius-quiet, 0);
1717
--spectrum-datepicker-border-width: var(--spectrum-border-width-100);
1818
--spectrum-datepicker-min-width: var(--mod-datepicker-min-width, var(--spectrum-field-width));
19+
--spectrum-datepicker-initial-height: var(--spectrum-component-height-100);
1920
--spectrum-datepicker-icon-size: var(--spectrum-workflow-icon-size-100);
2021

2122
/* button */

components/rating/dist/metadata.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,10 @@
9595
"--spectrum-focus-indicator-color",
9696
"--spectrum-focus-indicator-gap",
9797
"--spectrum-focus-indicator-thickness",
98+
"--spectrum-neutral-subdued-content-color-default",
99+
"--spectrum-neutral-subdued-content-color-down",
100+
"--spectrum-neutral-subdued-content-color-hover",
101+
"--spectrum-neutral-subdued-content-color-key-focus",
98102
"--spectrum-workflow-icon-size-100"
99103
],
100104
"passthroughs": [],

components/rating/index.css

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@
1515
/* Icon */
1616
--spectrum-rating-icon-height: var(--spectrum-workflow-icon-size-100);
1717
--spectrum-rating-icon-width: var(--spectrum-workflow-icon-size-100);
18+
--spectrum-rating-icon-color-default: var(--spectrum-neutral-subdued-content-color-default);
19+
--spectrum-rating-icon-color-hover: var(--spectrum-neutral-subdued-content-color-hover);
20+
--spectrum-rating-icon-color-down: var(--spectrum-neutral-subdued-content-color-down);
21+
--spectrum-rating-icon-color-key-focus: var(--spectrum-neutral-subdued-content-color-key-focus);
22+
23+
1824

1925
/* Focus ring */
2026
--spectrum-rating-border-radius: var(--spectrum-corner-radius-100);
@@ -25,8 +31,9 @@
2531
/* Spacing (top/bottom edge to icon) */
2632
--spectrum-rating-icon-spacing-vertical-top: var(--spectrum-component-top-to-workflow-icon-100);
2733

28-
/* Indicator height */
34+
/* Indicator */
2935
--spectrum-rating-indicator-height: var(--spectrum-border-width-200);
36+
--spectrum-rating-indicator-border-radius: 2px;
3037

3138
/* Colors */
3239
/* selected + emphasized */

components/sidenav/dist/metadata.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,8 @@
166166
"--spectrum-focus-indicator-thickness",
167167
"--spectrum-font-size-100",
168168
"--spectrum-font-size-75",
169+
"--spectrum-gray-100",
170+
"--spectrum-gray-200",
169171
"--spectrum-gray-600",
170172
"--spectrum-line-height-100",
171173
"--spectrum-medium-font-weight",

components/sidenav/index.css

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,13 @@
7676
/* color - background */
7777
--spectrum-sidenav-background-disabled: transparent;
7878
--spectrum-sidenav-background-default: transparent;
79+
--spectrum-sidenav-background-hover: var(--spectrum-gray-100);
80+
--spectrum-sidenav-item-background-down: var(--spectrum-gray-200);
81+
--spectrum-sidenav-background-key-focus: var(--spectrum-gray-100);
82+
--spectrum-sidenav-item-background-default-selected: var(--spectrum-gray-100);
83+
--spectrum-sidenav-background-hover-selected: var(--spectrum-gray-200);
84+
--spectrum-sidenav-item-background-down-selected: var(--spectrum-gray-200);
85+
--spectrum-sidenav-background-key-focus-selected: var(--spectrum-gray-100);
7986

8087
/* color font */
8188
--spectrum-sidenav-header-color: var(--spectrum-gray-600);

components/slider/dist/metadata.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,15 +230,22 @@
230230
"--spectrum-component-top-to-text-100",
231231
"--spectrum-component-top-to-text-200",
232232
"--spectrum-component-top-to-text-75",
233+
"--spectrum-corner-radius-500",
233234
"--spectrum-disabled-background-color",
234235
"--spectrum-disabled-border-color",
235236
"--spectrum-disabled-content-color",
237+
"--spectrum-focus-indicator-color",
236238
"--spectrum-focus-indicator-gap",
237239
"--spectrum-focus-indicator-thickness",
238240
"--spectrum-font-size-100",
239241
"--spectrum-font-size-200",
240242
"--spectrum-font-size-75",
241243
"--spectrum-gray-100",
244+
"--spectrum-gray-200",
245+
"--spectrum-gray-400",
246+
"--spectrum-gray-700",
247+
"--spectrum-gray-75",
248+
"--spectrum-gray-800",
242249
"--spectrum-line-height-100",
243250
"--spectrum-logical-rotation",
244251
"--spectrum-neutral-content-color-default",

components/slider/index.css

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@
4141
--spectrum-slider-tick-handle-background-color: var(--spectrum-gray-100);
4242

4343
/* colors */
44+
--spectrum-slider-track-color: var(--spectrum-gray-200);
45+
--spectrum-slider-track-fill-color: var(--spectrum-gray-700);
46+
--spectrum-slider-ramp-track-color: var(--spectrum-gray-400);
47+
--spectrum-slider-ramp-track-color-disabled: var(--spectrum-gray-100);
4448
--spectrum-slider-track-color-disabled: var(--spectrum-disabled-background-color);
4549
--spectrum-slider-track-fill-color-disabled: var(--spectrum-disabled-background-color);
4650
--spectrum-slider-handle-border-color-disabled: var(--spectrum-disabled-border-color);
@@ -49,13 +53,30 @@
4953
--spectrum-slider-label-text-color-disabled: var(--spectrum-disabled-content-color);
5054
--spectrum-slider-tick-mark-color-disabled: var(--spectrum-disabled-background-color);
5155
--spectrum-slider-ramp-handle-border-color-active: var(--spectrum-gray-100);
56+
--spectrum-slider-handle-background-color: transparent;
57+
--spectrum-slider-handle-background-color-disabled: transparent;
58+
--spectrum-slider-ramp-handle-background-color: var(--spectrum-gray-75);
59+
--spectrum-slider-ticks-handle-background-color: var(--spectrum-gray-75);
60+
--spectrum-slider-handle-border-color: var(--spectrum-gray-700);
61+
--spectrum-slider-handle-disabled-background-color: var(--spectrum-gray-75);
62+
--spectrum-slider-tick-mark-color: var(--spectrum-gray-200);
63+
64+
65+
--spectrum-slider-handle-border-color-hover: var(--spectrum-gray-800);
66+
--spectrum-slider-handle-border-color-down: var(--spectrum-gray-800);
67+
--spectrum-slider-handle-border-color-key-focus: var(--spectrum-gray-800);
68+
--spectrum-slider-handle-focus-ring-color-key-focus: var(--spectrum-focus-indicator-color);
5269

5370
/* values */
5471
--spectrum-slider-input-left: calc(var(--spectrum-slider-handle-margin-left) / 4);
5572
--spectrum-slider-track-handleoffset: var(--spectrum-slider-handle-gap);
5673

5774
--spectrum-slider-range-track-reset: 0;
5875

76+
--spectrum-slider-track-corner-radius: 2px;
77+
78+
--spectrum-slider-handle-border-radius: var(--spectrum-corner-radius-500);
79+
5980
position: relative;
6081

6182
/* Don't let z-index'd child elements float above other things on the page */
@@ -83,6 +104,7 @@
83104
--spectrum-slider-label-top-to-text: var(--spectrum-component-top-to-text-75);
84105
--spectrum-slider-control-to-field-label: var(--spectrum-slider-control-to-field-label-small);
85106
--spectrum-slider-value-side-padding-inline: var(--spectrum-spacing-100);
107+
--spectrum-slider-handle-border-radius: var(--spectrum-corner-radius-500);
86108
}
87109

88110
.spectrum-Slider--sizeL {
@@ -93,6 +115,7 @@
93115
--spectrum-slider-label-top-to-text: var(--spectrum-component-top-to-text-100);
94116
--spectrum-slider-control-to-field-label: var(--spectrum-slider-control-to-field-label-large);
95117
--spectrum-slider-value-side-padding-inline: var(--spectrum-spacing-200);
118+
--spectrum-slider-handle-border-radius: calc(var(--spectrum-corner-radius-500) * 4);
96119

97120
/* TODO: placeholder value for sideLabel variant value width */
98121
--spectrum-slider-value-inline-size: 18px;
@@ -106,6 +129,7 @@
106129
--spectrum-slider-label-top-to-text: var(--spectrum-component-top-to-text-200);
107130
--spectrum-slider-control-to-field-label: var(--spectrum-slider-control-to-field-label-extra-large);
108131
--spectrum-slider-value-side-padding-inline: var(--spectrum-spacing-200);
132+
--spectrum-slider-handle-border-radius: calc(var(--spectrum-corner-radius-500) * 4);
109133

110134
/* TODO: placeholder value for sideLabel variant value width */
111135
--spectrum-slider-value-inline-size: 22px;

components/switch/dist/metadata.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@
241241
"--highcontrast-switch-border-color-selected-focus",
242242
"--highcontrast-switch-border-color-selected-hover",
243243
"--highcontrast-switch-focus-indicator-color",
244-
"--highcontrast-switch-handle-background-color",
245244
"--highcontrast-switch-handle-background-color-default",
246245
"--highcontrast-switch-handle-background-color-disabled",
247246
"--highcontrast-switch-handle-background-color-down",

0 commit comments

Comments
 (0)