Skip to content

Commit 828fec1

Browse files
committed
build: remove theme processing, site package; add reporter
1 parent 1415f76 commit 828fec1

File tree

210 files changed

+515
-7727
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

210 files changed

+515
-7727
lines changed

.changeset/pre.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,18 +89,13 @@
8989
"@spectrum-css/well": "4.1.5-next.2",
9090
"@spectrum-css/generator": "3.0.0",
9191
"conventional-changelog-spectrum": "1.0.2",
92-
"postcss-combininator": "2.0.0",
93-
"postcss-custom-properties-mapping": "2.0.0",
9492
"@spectrum-tools/stylelint-no-missing-var": "1.3.1",
9593
"@spectrum-tools/stylelint-no-unknown-custom-properties": "1.3.2",
9694
"@spectrum-tools/stylelint-no-unused-custom-properties": "1.3.1",
9795
"@spectrum-tools/documentation": "1.0.0",
9896
"@spectrum-css/tokens": "14.0.0-next.6",
9997
"@spectrum-css/ui-icons": "1.1.2",
100-
"@spectrum-tools/postcss-add-theming-layer": "0.0.0",
101-
"@spectrum-tools/postcss-property-rollup": "0.0.0",
102-
"@spectrum-tools/postcss-rgb-mapping": "3.0.0-s2-foundations.0",
103-
"@spectrum-tools/theme-alignment": "1.1.0"
98+
"@spectrum-tools/postcss-rgb-mapping": "3.0.0-s2-foundations.0"
10499
},
105100
"changesets": [
106101
"chilly-peaches-sniff",

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ jobs:
9090
filter_mode: diff_context
9191
level: error
9292
reporter: github-pr-review
93-
# stylelint_input: "components/*/index.css
93+
# stylelint_input: "components/*/index.css"
9494
stylelint_input: "${{ inputs.styles_added_files }} ${{ inputs.styles_modified_files }}"
9595
stylelint_config: stylelint.config.js
9696

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
dist
22
!tokens/dist/index.css
3-
!tokens/dist/css/*.css
43

54
# Not committing the map assets, these are dev-only
65
*.map

.storybook/guides/develop.mdx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,19 +35,18 @@ Each component has the following files:
3535
- `stories/*.stories.js` - The storybook file that defines the component's stories and the available knobs for the component.
3636
- `stories/template.js` - The template function that generates the component's mark-up based on the provided settings.
3737
- `stories/*.test.js` - The testing grid for visual regression testing in Chromatic.
38-
- `stories/*.mdx` - This asset generates the component-specific documentation and is rendered in Storybook as the Docs page.
3938

4039
Each component outputs the following assets to `dist`:
4140

42-
- `index.css`: This asset includes the base CSS.
41+
- `index.css`: This asset includes the CSS for the component and is meant to be loaded in conjunction with the tokens for your desired color context and scales.
4342

4443
## Adding a new component
4544

4645
1. Generate a new component using the `yarn new component` command. The generator will prompt you to answer questions about your component.
4746
2. Edit the `dependencies` within the `package.json` file to use only the dependencies your component needs. All components rely on `@spectrum-css/tokens`, and most rely on `@spectrum-css/icon`.
4847
3. Once your folder has been generated, you can run `yarn start` in the root of the project to begin developing.
49-
4. The `index.css` file is where all of your styles will be added.
50-
5. Inside the `stories` directory you will find a `template.js`, `*.stories.js`, and `*.mdx` file.
48+
4. The `index.css` file is where all of your styles should be added.
49+
5. Inside the `stories` directory you will find a `template.js` and `*.stories.js` file.
5150
- In the `*.stories.js` file, define the available knobs and properties for your component, as well as any standard variations you want to surface in [Storybook](https://storybook.js.org/docs/react/writing-stories/introduction).
5251
- Update the `template.js` file with the markup, using [lit-html syntax](https://lit.dev/docs/templates/overview/) to adjust results based on the provided settings from the Storybook knobs.
5352

.storybook/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default {
2222
},
2323
{
2424
directory: "./foundations",
25-
files: "*/*.mdx",
25+
files: "*/*.@(stories.js|mdx)",
2626
titlePrefix: "Foundations",
2727
},
2828
{

.storybook/manager.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
import "@spectrum-css/tokens/dist/index.css";
2+
23
import { addons } from "@storybook/manager-api";
34
import { create } from "@storybook/theming";
4-
import "./assets/index.css";
5+
56
import logo from "./assets/logo.svg";
67
import pkg from "./package.json";
78

9+
import "./assets/index.css";
10+
811
const root = document.body ?? document.documentElement;
912
if (root) root.classList.add("spectrum", "spectrum--light", "spectrum--medium");
1013

@@ -63,8 +66,5 @@ addons.setConfig({
6366
}),
6467
sidebar: {
6568
showRoots: false,
66-
filters: {
67-
patterns: (item) => !item.id.includes('forced-colors') && ['is-hidden-story'].every((tag) => !item.tags.includes(tag)),
68-
},
6969
},
7070
});

.storybook/modes/index.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,12 @@
1212
*/
1313

1414
const modes = {
15-
Light: {
15+
"Light | LTR": {
1616
color: "light",
17+
textDirection: "ltr",
1718
},
18-
Dark: {
19+
"Dark | RTL": {
1920
color: "dark",
20-
},
21-
RTL: {
2221
textDirection: "rtl",
2322
},
2423
};

.storybook/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
},
3030
"dependencies": {
3131
"@adobe/spectrum-css-workflow-icons": "^1.5.4",
32-
"@adobe/spectrum-tokens": "13.0.0-beta.52",
32+
"@adobe/spectrum-tokens": "13.0.0-beta.55",
3333
"@spectrum-css/actionbutton": "workspace:^",
3434
"@spectrum-css/button": "workspace:^",
3535
"@spectrum-css/table": "workspace:^",

components/accordion/metadata/metadata.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@
198198
"--spectrum-neutral-content-color-key-focus",
199199
"--spectrum-sans-font-family-stack"
200200
],
201-
"system-theme": [],
202201
"passthroughs": [],
203202
"high-contrast": []
204203
}

components/accordion/metadata/mods.md

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)