Skip to content

Commit 8d44673

Browse files
authored
refactor(opacitycheckerboard): address concerns about inclusion order (#2382)
* refactor(opacitycheckerboard): simplfy css * docs(opacitycheckerboard): improve docs * fix(opacitycheckerboard): display in storybook with updated CSS * fix(opacitycheckerboard): only apply inline-size properties to storybook for opacitycheckerboard * docs(opacitycheckerboard): remove new sb heading
1 parent 174d386 commit 8d44673

File tree

5 files changed

+20
-12
lines changed

5 files changed

+20
-12
lines changed

components/opacitycheckerboard/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# @spectrum-css/opacitycheckerboard
22

3-
> Opacity checkerboard
3+
> Opacity checkerboard is a class used to highlight background color opacity.
4+
45

56
This package is part of the [Spectrum CSS project](https://github.com/adobe/spectrum-css).
67

components/opacitycheckerboard/index.css

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ permissions and limitations under the License. */
2121
}
2222

2323
.spectrum-OpacityCheckerboard {
24-
inline-size: 100%;
25-
block-size: 100%;
2624
background: repeating-conic-gradient(
2725
var(
2826
--mod-opacity-checkerboard-light,
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
name: Opacity Checkerboard
2-
description: Opacity checkerboard is used with other components to highlight opacity.
1+
name: Opacity checkerboard
2+
description: Opacity checkerboard is a class used to highlight background color opacity.
33
examples:
44
- id: opacity-checkerboard
5-
name: Opacity Checkerboard
5+
name: Opacity checkerboard
66
markup: |
77
<div style="inline-size: 100px; block-size: 100px;">
8-
<div class="spectrum-OpacityCheckerboard">
8+
<div class="spectrum-OpacityCheckerboard" style="inline-size: 100%; block-size: 100%;">
99
</div>
1010
</div>
1111
- id: opacity-checkerboard
12-
name: Opacity Checkerboard with color overlay
12+
name: Opacity checkerboard with color overlay
1313
markup: |
1414
<div style="inline-size: 100px; block-size: 100px;">
15-
<div class="spectrum-OpacityCheckerboard"></div>
15+
<div class="spectrum-OpacityCheckerboard" style="inline-size: 100%; block-size: 100%;"></div>
1616
<div style="background-color: rgba(255, 0, 0, 0.5); inline-size: 100%; block-size: 100%; position: relative; inset-block: -100%"></div>
1717
</div>

components/opacitycheckerboard/stories/opacitycheckerboard.stories.js

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default {
2222
},
2323
args: {
2424
rootClass: "spectrum-OpacityCheckerboard",
25-
backgroundPosition: "top left"
25+
backgroundPosition: "left top"
2626
},
2727
parameters: {
2828
actions: {
@@ -39,11 +39,20 @@ export default {
3939
],
4040
};
4141
export const Default = Template.bind({});
42-
Default.args = {};
42+
Default.args = {
43+
customStyles: {
44+
"inline-size": "100%",
45+
"block-size": "100%"
46+
}
47+
};
4348

4449
export const CheckerboardPosition = Template.bind({});
4550
CheckerboardPosition.args = {
4651
backgroundPosition: 'center center',
52+
customStyles: {
53+
"inline-size": "100%",
54+
"block-size": "100%"
55+
}
4756
};
4857
CheckerboardPosition.parameters = {
4958
docs: {

components/opacitycheckerboard/stories/template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import "../index.css";
77

88
export const Template = ({
99
rootClass = "spectrum-OpacityCheckerboard",
10-
backgroundPosition = "top left",
10+
backgroundPosition,
1111
customClasses = [],
1212
customStyles = {},
1313
id,

0 commit comments

Comments
 (0)