Skip to content

Commit 9386219

Browse files
cdransfcastastrophe
authored andcommitted
fix(combobox): corrects cases where open combobx stories and testing previews could overlap adjacent components (#3568)
1 parent 5ce164c commit 9386219

File tree

4 files changed

+18
-5
lines changed

4 files changed

+18
-5
lines changed

components/combobox/stories/combobox.stories.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,11 @@ DefaultGroup.args = Default.args;
171171
DefaultGroup.tags = ["!dev"];
172172
DefaultGroup.parameters = {
173173
chromatic: { disableSnapshot: true },
174+
docs: {
175+
story: {
176+
height: "360px",
177+
},
178+
},
174179
};
175180

176181
export const QuietGroup = VariantGroup.bind({});
@@ -182,6 +187,11 @@ QuietGroup.args = {
182187
QuietGroup.tags = ["!dev"];
183188
QuietGroup.parameters = {
184189
chromatic: { disableSnapshot: true },
190+
docs: {
191+
story: {
192+
height: "360px",
193+
},
194+
},
185195
};
186196

187197
/**

components/combobox/stories/combobox.test.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ import { Template } from "./template.js";
44
export const ComboBoxGroup = Variants({
55
Template,
66
sizeDirection: "row",
7-
wrapperStyles: {
8-
"align-items": "flex-start",
9-
},
107
testData: [
118
{
129
testHeading: "Default",
@@ -20,11 +17,17 @@ export const ComboBoxGroup = Variants({
2017
{
2118
testHeading: "Open",
2219
isOpen: true,
20+
wrapperStyles: {
21+
"min-block-size": "250px",
22+
},
2323
},
2424
{
2525
testHeading: "Quiet + open",
2626
isQuiet: true,
2727
isOpen: true,
28+
wrapperStyles: {
29+
"min-block-size": "250px",
30+
},
2831
},
2932
{
3033
testHeading: "With field label top",

components/infieldprogresscircle/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"@spectrum-css/tokens": ">=16"
2929
},
3030
"devDependencies": {
31-
"@spectrum-css/tokens": "16.0.0"
31+
"@spectrum-css/tokens": "16.0.1"
3232
},
3333
"keywords": [
3434
"design-system",

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4652,7 +4652,7 @@ __metadata:
46524652
version: 0.0.0-use.local
46534653
resolution: "@spectrum-css/infieldprogresscircle@workspace:components/infieldprogresscircle"
46544654
dependencies:
4655-
"@spectrum-css/tokens": "npm:16.0.0"
4655+
"@spectrum-css/tokens": "npm:16.0.1"
46564656
peerDependencies:
46574657
"@spectrum-css/tokens": ">=16"
46584658
peerDependenciesMeta:

0 commit comments

Comments
 (0)