Skip to content

Commit 9c49505

Browse files
castastrophecastastrophe
authored
fix: remove storybook assets from shipped output (#3369)
1 parent 5358f5a commit 9c49505

File tree

85 files changed

+194
-251
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

85 files changed

+194
-251
lines changed

‎.changeset/fifty-bottles-teach.md

Lines changed: 86 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
1+
---
2+
"@spectrum-css/floatingactionbutton": minor
3+
"@spectrum-css/opacitycheckerboard": minor
4+
"@spectrum-css/illustratedmessage": minor
5+
"@spectrum-css/coachindicator": minor
6+
"@spectrum-css/contextualhelp": minor
7+
"@spectrum-css/progresscircle": minor
8+
"@spectrum-css/dropindicator": minor
9+
"@spectrum-css/infieldbutton": minor
10+
"@spectrum-css/actionbutton": minor
11+
"@spectrum-css/pickerbutton": minor
12+
"@spectrum-css/actiongroup": minor
13+
"@spectrum-css/alertbanner": minor
14+
"@spectrum-css/alertdialog": minor
15+
"@spectrum-css/buttongroup": minor
16+
"@spectrum-css/clearbutton": minor
17+
"@spectrum-css/closebutton": minor
18+
"@spectrum-css/colorhandle": minor
19+
"@spectrum-css/colorslider": minor
20+
"@spectrum-css/inlinealert": minor
21+
"@spectrum-css/logicbutton": minor
22+
"@spectrum-css/progressbar": minor
23+
"@spectrum-css/statuslight": minor
24+
"@spectrum-css/swatchgroup": minor
25+
"@spectrum-css/actionmenu": minor
26+
"@spectrum-css/breadcrumb": minor
27+
"@spectrum-css/colorloupe": minor
28+
"@spectrum-css/colorwheel": minor
29+
"@spectrum-css/datepicker": minor
30+
"@spectrum-css/fieldgroup": minor
31+
"@spectrum-css/fieldlabel": minor
32+
"@spectrum-css/pagination": minor
33+
"@spectrum-css/typography": minor
34+
"@spectrum-css/accordion": minor
35+
"@spectrum-css/actionbar": minor
36+
"@spectrum-css/assetcard": minor
37+
"@spectrum-css/assetlist": minor
38+
"@spectrum-css/coachmark": minor
39+
"@spectrum-css/colorarea": minor
40+
"@spectrum-css/splitview": minor
41+
"@spectrum-css/textfield": minor
42+
"@spectrum-css/thumbnail": minor
43+
"@spectrum-css/calendar": minor
44+
"@spectrum-css/checkbox": minor
45+
"@spectrum-css/combobox": minor
46+
"@spectrum-css/dropzone": minor
47+
"@spectrum-css/helptext": minor
48+
"@spectrum-css/steplist": minor
49+
"@spectrum-css/taggroup": minor
50+
"@spectrum-css/treeview": minor
51+
"@spectrum-css/underlay": minor
52+
"@spectrum-css/divider": minor
53+
"@spectrum-css/popover": minor
54+
"@spectrum-css/sidenav": minor
55+
"@spectrum-css/stepper": minor
56+
"@spectrum-css/tooltip": minor
57+
"@spectrum-css/avatar": minor
58+
"@spectrum-css/button": minor
59+
"@spectrum-css/dialog": minor
60+
"@spectrum-css/miller": minor
61+
"@spectrum-css/picker": minor
62+
"@spectrum-css/rating": minor
63+
"@spectrum-css/search": minor
64+
"@spectrum-css/slider": minor
65+
"@spectrum-css/swatch": minor
66+
"@spectrum-css/switch": minor
67+
"@spectrum-css/asset": minor
68+
"@spectrum-css/badge": minor
69+
"@spectrum-css/modal": minor
70+
"@spectrum-css/radio": minor
71+
"@spectrum-css/table": minor
72+
"@spectrum-css/toast": minor
73+
"@spectrum-css/card": minor
74+
"@spectrum-css/dial": minor
75+
"@spectrum-css/icon": minor
76+
"@spectrum-css/link": minor
77+
"@spectrum-css/menu": minor
78+
"@spectrum-css/page": minor
79+
"@spectrum-css/site": minor
80+
"@spectrum-css/tabs": minor
81+
"@spectrum-css/tray": minor
82+
"@spectrum-css/well": minor
83+
"@spectrum-css/tag": minor
84+
---
85+
86+
Remove the storybook assets from the shipped output for components

‎.storybook/blocks/PropertiesTable.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import "@spectrum-css/table";
1+
import "@spectrum-css/table/dist/index.css";
22

33
import { DocsContext, useOf } from "@storybook/blocks";
4-
import { ResetWrapper } from "@storybook/components";
54
import { NAVIGATE_URL } from "@storybook/core-events";
65
import { styled } from "@storybook/theming";
76
import React, { useContext } from 'react';
7+
import { ThemeContainer } from "./ThemeContainer.jsx";
88
import { Body, Code, LinkableHeading } from "./Typography.jsx";
99

1010
export const Table = styled.table`
@@ -32,7 +32,7 @@ export const PropertiesTable = () => {
3232
if (!metadata?.modifiers || !metadata?.modifiers.length) return;
3333

3434
return (
35-
<ResetWrapper>
35+
<ThemeContainer color="light" display="contents">
3636
<LinkableHeading id="modifiable-properties" size="m">
3737
<a aria-hidden="true" href="#modifiable-properties" tabIndex="-1" target="_self" onClick={() => {
3838
context.channel.emit(NAVIGATE_URL, "#modifiable-properties");
@@ -61,6 +61,6 @@ export const PropertiesTable = () => {
6161
))}
6262
</tbody>
6363
</Table>
64-
</ResetWrapper>
64+
</ThemeContainer>
6565
);
6666
};

‎.storybook/blocks/ThemeContainer.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import "@spectrum-css/tokens/dist/index.css";
77
const Container = styled.section`
88
color: var(--spectrum-neutral-content-color-default);
99
background-color: var(--spectrum-background-layer-1-color);
10-
display: flex;
10+
display: ${props => props.display ?? "flex" };
1111
padding-inline: 48px 24px;
1212
padding-block: 60px;
1313
flex-direction: column;

‎.storybook/main.js

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
import fs from "fs";
2+
import path from "path";
3+
4+
// Get a list of all the folders in the components directory
5+
const componentDir = path.resolve(__dirname, "../components");
6+
const components = fs.readdirSync(componentDir, { withFileTypes: true })
7+
.filter(dirent => dirent.isDirectory() && fs.existsSync(path.resolve(componentDir, dirent.name, "package.json")))
8+
.map(dirent => dirent.name);
9+
110
export default {
211
stories: [
312
{
@@ -17,7 +26,7 @@ export default {
1726
},
1827
],
1928
rootDir: "../",
20-
staticDirs: ["../assets", "./assets/images"],
29+
staticDirs: ["./assets"],
2130
addons: [
2231
{
2332
name: "@storybook/addon-essentials",
@@ -27,9 +36,16 @@ export default {
2736
viewport: false,
2837
// Don't need backgrounds b/c this is handled by the color contexts.
2938
backgrounds: false,
39+
// Configure separately
40+
docs: false,
41+
},
42+
},
43+
{
44+
name: "@storybook/addon-docs",
45+
options: {
3046
// Enables JSX support in MDX for projects that aren't configured to handle the format.
3147
configureJSX: true,
32-
// Support markdown in MDX files.
48+
// Support markdown in MDX files
3349
transcludeMarkdown: true,
3450
},
3551
},
@@ -55,7 +71,7 @@ export default {
5571
const { mergeConfig } = await import("vite");
5672

5773
return mergeConfig(config, {
58-
publicDir: "../assets",
74+
publicDir: "./assets",
5975
build: {
6076
sourcemap: configType === "DEVELOPMENT",
6177
manifest: true,
@@ -64,6 +80,9 @@ export default {
6480
css: {
6581
devSourcemap: configType === "DEVELOPMENT",
6682
},
83+
resolve: {
84+
alias: components.map(component => ({ find: `@spectrum-css/${component}`, replacement: path.resolve(__dirname, `../components/${component}`) })),
85+
}
6786
});
6887
},
6988
framework: {

‎components/accordion/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@
2121
"./index.css": "./dist/index.css",
2222
"./metadata.json": "./metadata/metadata.json",
2323
"./metadata/*": "./metadata/*",
24-
"./package.json": "./package.json",
25-
"./stories/*": "./stories/*"
24+
"./package.json": "./package.json"
2625
},
2726
"main": "dist/index.css",
2827
"files": [
2928
"dist/*",
3029
"*.md",
3130
"package.json",
32-
"stories/*",
3331
"metadata/*"
3432
],
3533
"peerDependencies": {

‎components/actionbar/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@
2121
"./index.css": "./dist/index.css",
2222
"./metadata.json": "./metadata/metadata.json",
2323
"./metadata/*": "./metadata/*",
24-
"./package.json": "./package.json",
25-
"./stories/*": "./stories/*"
24+
"./package.json": "./package.json"
2625
},
2726
"main": "dist/index.css",
2827
"files": [
2928
"dist/*",
3029
"*.md",
3130
"package.json",
32-
"stories/*",
3331
"metadata/*"
3432
],
3533
"peerDependencies": {

‎components/actionbutton/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@
2121
"./index.css": "./dist/index.css",
2222
"./metadata.json": "./metadata/metadata.json",
2323
"./metadata/*": "./metadata/*",
24-
"./package.json": "./package.json",
25-
"./stories/*": "./stories/*"
24+
"./package.json": "./package.json"
2625
},
2726
"main": "dist/index.css",
2827
"files": [
2928
"dist/*",
3029
"*.md",
3130
"package.json",
32-
"stories/*",
3331
"metadata/*"
3432
],
3533
"peerDependencies": {

‎components/actiongroup/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@
2121
"./index.css": "./dist/index.css",
2222
"./metadata.json": "./metadata/metadata.json",
2323
"./metadata/*": "./metadata/*",
24-
"./package.json": "./package.json",
25-
"./stories/*": "./stories/*"
24+
"./package.json": "./package.json"
2625
},
2726
"main": "dist/index.css",
2827
"files": [
2928
"dist/*",
3029
"*.md",
3130
"package.json",
32-
"stories/*",
3331
"metadata/*"
3432
],
3533
"peerDependencies": {

‎components/actionmenu/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@
2121
"./index.css": "./dist/index.css",
2222
"./metadata.json": "./metadata/metadata.json",
2323
"./metadata/*": "./metadata/*",
24-
"./package.json": "./package.json",
25-
"./stories/*": "./stories/*"
24+
"./package.json": "./package.json"
2625
},
2726
"main": "dist/index.css",
2827
"files": [
2928
"dist/*",
3029
"*.md",
3130
"package.json",
32-
"stories/*",
3331
"metadata/*"
3432
],
3533
"peerDependencies": {

‎components/alertbanner/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@
2121
"./index.css": "./dist/index.css",
2222
"./metadata.json": "./metadata/metadata.json",
2323
"./metadata/*": "./metadata/*",
24-
"./package.json": "./package.json",
25-
"./stories/*": "./stories/*"
24+
"./package.json": "./package.json"
2625
},
2726
"main": "dist/index.css",
2827
"files": [
2928
"dist/*",
3029
"*.md",
3130
"package.json",
32-
"stories/*",
3331
"metadata/*"
3432
],
3533
"peerDependencies": {

0 commit comments

Comments
 (0)