Skip to content

Commit b693726

Browse files
committed
feat(storybook): display custom properties
1 parent 215b85c commit b693726

File tree

203 files changed

+45081
-9145
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

203 files changed

+45081
-9145
lines changed

.changeset/eleven-plants-grow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@spectrum-css/generator": patch
3+
---
4+
5+
Update story templates to include the cssprops imports

.changeset/new-bulldogs-add.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@spectrum-css/preview": minor
3+
---
4+
5+
New feature: Custom properties panel added to the development preview showing a list of modifiable custom properties as loaded from the metadata/metadata.json resource in each component.

.eslintrc

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@
88
"parserOptions": {
99
"sourceType": "module"
1010
},
11+
"settings": {
12+
"react": {
13+
"version": "detect"
14+
}
15+
},
1116
"extends": "eslint:recommended",
1217
"rules": {
1318
"brace-style": ["warn", "stroustrup", { "allowSingleLine": true }],
@@ -17,7 +22,8 @@
1722
"no-console": ["warn", { "allow": ["warn", "error"] }],
1823
"quotes": ["warn", "double"],
1924
"semi": ["warn", "always"],
20-
"space-before-blocks": ["warn", "always"]
25+
"space-before-blocks": ["warn", "always"],
26+
"react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }]
2127
},
2228
"overrides": [
2329
{
@@ -174,6 +180,7 @@
174180
".storybook/*.js",
175181
".storybook/**/*.js"
176182
],
183+
"extends": ["plugin:react/recommended", "plugin:react/jsx-runtime"],
177184
"parserOptions": {
178185
"ecmaVersion": "latest",
179186
"sourceType": "module",

.storybook/main.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ export default {
6868
name: "@storybook/addon-actions",
6969
options: {},
7070
},
71+
// https://github.com/ljcl/storybook-addon-cssprops
72+
"@ljcl/storybook-addon-cssprops",
7173
// https://www.npmjs.com/package/@whitespace/storybook-addon-html
7274
"@whitespace/storybook-addon-html",
7375
// https://github.com/storybookjs/storybook/tree/next/code/addons/a11y

.storybook/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
"@babel/core": "^7.28.3",
4949
"@chromatic-com/storybook": "^3.2.7",
5050
"@etchteam/storybook-addon-status": "^5.0.0",
51+
"@ljcl/storybook-addon-cssprops": "4.0.0",
5152
"@storybook/addon-a11y": "8.4.7",
5253
"@storybook/addon-actions": "8.4.7",
5354
"@storybook/addon-designs": "^8.2.1",
@@ -60,7 +61,7 @@
6061
"@storybook/core-events": "8.4.7",
6162
"@storybook/manager-api": "8.4.7",
6263
"@storybook/preview-api": "8.4.7",
63-
"@storybook/test-runner": "^0.22.0",
64+
"@storybook/test-runner": "^0.23.0",
6465
"@storybook/theming": "8.4.7",
6566
"@storybook/web-components-vite": "8.4.7",
6667
"@whitespace/storybook-addon-html": "^7.0.0",

.storybook/preview.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import DocumentationTemplate from "./templates/DocumentationTemplate.mdx";
1515
import { argTypes, globalTypes } from "./types";
1616

1717
// Import the custom base styles
18+
import "@spectrum-css/bundle/dist/index.css";
1819
import "./assets/base.css";
1920

2021
/** @type import('@storybook/types').StorybookParameters & import('@storybook/types').API_Layout */

components/accordion/dist/metadata.json

Lines changed: 1151 additions & 210 deletions
Large diffs are not rendered by default.

components/accordion/index.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@
8787
&:lang(ja),
8888
&:lang(zh),
8989
&:lang(ko) {
90+
/* @description When the language is CJK, update line-height values to prevent cut off diacritics */
9091
--spectrum-accordion-item-header-line-height: var(--spectrum-cjk-line-height-100);
9192
--spectrum-accordion-item-content-line-height: var(--spectrum-cjk-line-height-100);
9293
}

components/accordion/stories/accordion.stories.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@ import { default as IconStories } from "@spectrum-css/icon/stories/icon.stories.
22
import { Sizes } from "@spectrum-css/preview/decorators";
33
import { disableDefaultModes } from "@spectrum-css/preview/modes";
44
import { isQuiet, size } from "@spectrum-css/preview/types";
5-
import metadata from "../dist/metadata.json";
6-
import packageJson from "../package.json";
75
import { AccordionGroup, testsContent as accordionContent, directActionsContent, longerContent } from "./accordion.test.js";
86
import { Template } from "./template.js";
97

8+
// Local assets to render the component styles and structure
9+
import metadata from "../dist/metadata.json";
10+
import packageJson from "../package.json";
11+
1012
/**
1113
* The accordion element contains a list of items that can be expanded or collapsed to reveal
1214
* additional content or information associated with each item. There can be zero expanded items,
@@ -118,6 +120,10 @@ export default {
118120
status: {
119121
type: "migrated",
120122
},
123+
cssprops: {
124+
...metadata.modifiers,
125+
...metadata.component,
126+
},
121127
},
122128
tags: ["migrated"],
123129
};

0 commit comments

Comments
 (0)