chore(deps): bump actions/download-artifact from 3 to 4 (#2389)

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: dependabot[bot]

.github/workflows/build.yml

@@ -41,6 +41,8 @@ on:
                 type: string
                 default: ${{ github.head_ref }}
         outputs:
+            artifact-id:
+                value: ${{ jobs.build.outputs.artifact-id }}
             head-sha:
                 value: ${{ jobs.build.outputs.head-sha }}
             base-sha:
@@ -65,6 +67,7 @@ jobs:
         outputs:
             head-sha: ${{ steps.set-SHAs.outputs.head }}
             base-sha: ${{ steps.set-SHAs.outputs.base }}
+            artifact-id: ${{ steps.upload.outputs.artifact-id }}
         name: Build
         steps:
             - name: Check out code
@@ -105,27 +108,15 @@ jobs:
               run: yarn cache:clean
 
             ## --- BUILD --- ##
-            - name: Check for cached build assets
-              continue-on-error: true
-              id: cache-build
-              uses: actions/cache@v3
-              with:
-                  path: |
-                      components/*/dist/**
-                      tokens/dist/**
-                      ui-icons/dist/**
-                  key: ${{ matrix.system }}-node${{ matrix.node-version }}-compiled-assets-${{ steps.set-SHAs.outputs.head }}
-
             - name: Build components
-              if: ${{ steps.cache-build.outputs.cache-hit != 'true' }}
               shell: bash
               run: yarn build
 
             ## --- UPLOAD (only ubuntu-latest at the moment) --- ##
             - name: Upload compiled assets & NX performance profile
               id: upload
               if: ${{ matrix.system == 'ubuntu-latest' }}
-              uses: actions/upload-artifact@v3
+              uses: actions/upload-artifact@v4
               with:
                   path: |
                       ${{ github.workspace }}/components/*/dist/**

.github/workflows/compare-results.yml

@@ -20,6 +20,10 @@ on:
                 required: false
                 type: string
                 default: ${{ github.event.workflow_call.head.ref }}
+            artifact-id:
+                description: The artifact id to use for the build artifacts
+                required: false
+                type: string
         outputs:
             has-changed:
                 value: ${{ jobs.compare.outputs.has-changed }}
@@ -74,13 +78,13 @@ jobs:
               run: yarn install --frozen-lockfile --cache-folder .cache/yarn
 
             - name: Download build artifacts for head
-              uses: actions/download-artifact@v3
+              uses: actions/download-artifact@v4
               with:
                   name: ubuntu-latest-node18-compiled-assets-${{ inputs.head-sha }}
                   path: ${{ github.workspace }}/${{ inputs.head-sha }}
 
             - name: Download build artifacts for base
-              uses: actions/download-artifact@v3
+              uses: actions/download-artifact@v4
               with:
                   name: ubuntu-latest-node18-compiled-assets-${{ inputs.base-sha }}
                   path: ${{ github.workspace }}/${{ inputs.base-sha }}
@@ -115,7 +119,7 @@ jobs:
                   echo "key=ubuntu-latest-node18-compiled-assets-${{ matrix.branch }}" >> "$GITHUB_OUTPUT"
 
             - name: Check if build artifacts already exist
-              uses: actions/download-artifact@v3
+              uses: actions/download-artifact@v4
               id: artifact-found
               continue-on-error: true
               with:
@@ -158,25 +162,26 @@ jobs:
               run: yarn install --frozen-lockfile --cache-folder .cache/yarn
 
             ## --- BUILD --- ##
-            - name: Check for cached build assets
+            - name: Check for built assets
               continue-on-error: true
-              id: cache-build
-              uses: actions/cache@v3
+              id: download
+              uses: actions/download-artifact@v4
               with:
                   path: |
-                    components/*/dist/**
-                    tokens/dist/**
-                    ui-icons/dist/**
-                  key: ${{ steps.derive-key.outputs.key }}
+                    ${{ github.workspace }}/components/*/dist/**
+                    ${{ github.workspace }}/tokens/dist/**
+                    ${{ github.workspace }}/ui-icons/dist/**
+                  name: ${{ steps.derive-key.outputs.key }}
 
             - name: Build
-              if: ${{ steps.cache-build.outputs.cache-hit != 'true' }}
+              if: ${{ steps.download.outcome != 'success' }}
               shell: bash
               run: yarn build
 
             - name: Upload compiled assets
+              if: ${{ steps.download.outcome != 'success' }}
               id: upload
-              uses: actions/upload-artifact@v3
+              uses: actions/upload-artifact@v4
               with:
                   path: |
                     ${{ github.workspace }}/components/*/dist/**

.github/workflows/publish-site.yml

@@ -78,16 +78,16 @@ jobs:
               run: yarn cache:clean
 
             ## --- BUILD --- ##
-            - name: Check for cached build assets
+            - name: Check for built assets
               continue-on-error: true
-              id: cache-build
-              uses: actions/cache@v3
+              id: download
+              uses: actions/download-artifact@v4
               with:
                   path: |
-                      components/*/dist/**
-                      tokens/dist/**
-                      ui-icons/dist/**
-                  key: ubuntu-latest-node18-compiled-assets-${{ steps.set-SHAs.outputs.head }}
+                    components/*/dist/**
+                    tokens/dist/**
+                    ui-icons/dist/**
+                  name: ubuntu-latest-node18-compiled-assets-${{ steps.set-SHAs.outputs.head }}
 
             - name: Build storybook site
               if: ${{ inputs.storybook-url == '' }}