Skip to content

Commit d7fb5e9

Browse files
committed
chore(s2): grabbing new changes
2 parents 6cd85dd + 7bbc448 commit d7fb5e9

File tree

20 files changed

+471
-733
lines changed

20 files changed

+471
-733
lines changed

.changeset/clever-otters-mix.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
---
2+
"@spectrum-css/infieldbutton": minor
3+
"@spectrum-css/logicbutton": minor
4+
"@spectrum-css/progressbar": minor
5+
"@spectrum-css/colorwheel": minor
6+
"@spectrum-css/assetcard": minor
7+
"@spectrum-css/colorarea": minor
8+
"@spectrum-css/calendar": minor
9+
"@spectrum-css/checkbox": minor
10+
"@spectrum-css/underlay": minor
11+
"@spectrum-css/stepper": minor
12+
"@spectrum-css/button": minor
13+
"@spectrum-css/modal": minor
14+
"@spectrum-css/radio": minor
15+
"@spectrum-css/table": minor
16+
"@spectrum-css/card": minor
17+
"@spectrum-css/site": minor
18+
"@spectrum-css/tokens": minor
19+
---
20+
21+
This resolves our remaining stylelint issues around undefined tokens, rule order, unused values and color syntax.
22+
23+
- Updates invalid color syntax from `rgba(N, N, N, N)` to `rgba(N N N / N)`.
24+
- In cases of duplicate properties, preserves the property that would be applied given current code structure.
25+
- Updates misnamed tokens to use valid tokens (`table/index.css`).

.changeset/itchy-kids-travel.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
---
2+
"@spectrum-css/progresscircle": major
3+
---
4+
5+
## Progress circle S2 migration
6+
7+
This is the S2 migration of the progress circle. The original markup has changed to an svg and circle element to allow CSS styles such as `stroke-linecap`. This was necessary to match the design. The `--small/--medium/--large` sizing classes have been deprecated in favor of t-shirt classes `--sizeS/--sizeM/--sizeL`
8+
9+
### Animation
10+
11+
`@keyframes spectrum-dashoffset-animation`:
12+
This animation was created by React Spectrum and used to keep the same speed and bezier curve.
13+
14+
### Added tokens
15+
16+
### Removed styles & mods
17+
18+
`--spectrum-progress-circle-track-border-color-over-background`
19+
`--spectrum-progress-circle-fill-border-color-over-background`
20+
`--spectrum-progress-circle-track-border-style`
21+
`--spectrum-progress-circle-track-border-style`
22+
`--highcontrast-progress-circle-track-border-style`
23+
`--mod-progress-circle-track-border-style`
24+
`--spectrum-progress-circle-track-border-style`

.changeset/strong-actors-warn.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@spectrum-css/textfield": patch
3+
---
4+
5+
Updated the textfield border radius and background-color and added the respective `--mod` property.

.github/workflows/lint.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ jobs:
9292
reporter: github-pr-review
9393
# stylelint_input: "components/*/index.css"
9494
stylelint_input: "${{ inputs.styles_added_files }} ${{ inputs.styles_modified_files }}"
95-
stylelint_config: stylelint.config.js
95+
stylelint_config: "${{ github.workspace }}/stylelint.config.js"
96+
packages: 'stylelint-header stylelint-config-standard stylelint-selector-bem-pattern stylelint-order stylelint-use-logical'
9697

9798
- name: Run eslint on packages and stories
9899
uses: reviewdog/action-eslint@v1.33.0

.github/workflows/vrt.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
exitOnceUploaded: true
7474
onlyChanged: true
7575
traceChanged: true
76-
untraced: ".github/actions/*/package.json generator/package.json"
76+
untraced: ".github/* plugins/stylelint-*/* tools/* .changeset/*"
7777
diagnostics: true
7878
autoAcceptChanges: "main"
7979
# Lets VRT pass without running so as not to waste snapshots

components/button/CHANGELOG.md

Lines changed: 41 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,47 @@ The following `--mod` custom properties have been renamed:
8282
- `--mod-animation-duration-100` has been renamed to `--mod-button-animation-duration`
8383
- `--mod-bold-font-weight` has been renamed to `--mod-button-font-weight`
8484

85-
## 14.0.0-next.5
85+
## 13.1.3
86+
87+
### Patch Changes
88+
89+
- [#3107](https://github.com/adobe/spectrum-css/pull/3107) [`83d5a17`](https://github.com/adobe/spectrum-css/commit/83d5a171bd850df693707611203ecce21f22e7d2) Thanks [@castastrophe](https://github.com/castastrophe)! - Incorporate glob export for the dist directory in all component packages as well as glob markdown exports (to include both CHANGELOG and READMEs).
90+
91+
Sort keys in the package.json assets.
92+
93+
- Updated dependencies [[`83d5a17`](https://github.com/adobe/spectrum-css/commit/83d5a171bd850df693707611203ecce21f22e7d2)]:
94+
- @spectrum-css/progresscircle@3.1.4
95+
- @spectrum-css/icon@7.1.4
96+
97+
## 13.1.2
98+
99+
### Patch Changes
100+
101+
- [#3045](https://github.com/adobe/spectrum-css/pull/3045) [`5d6e03f`](https://github.com/adobe/spectrum-css/commit/5d6e03f30891f9171f1a600b06d534ee85719277) Thanks [@castastrophe](https://github.com/castastrophe)! - Improve changeset suggestions by using exports instead of files in component packages
102+
103+
- Updated dependencies [[`5d6e03f`](https://github.com/adobe/spectrum-css/commit/5d6e03f30891f9171f1a600b06d534ee85719277)]:
104+
- @spectrum-css/progresscircle@3.1.3
105+
- @spectrum-css/icon@7.1.3
106+
107+
## 13.1.1
108+
109+
### Patch Changes
110+
111+
- [#2677](https://github.com/adobe/spectrum-css/pull/2677) [`d83200c`](https://github.com/adobe/spectrum-css/commit/d83200ca70a959aa70329e71de0c4383de157855) Thanks [@castastrophe](https://github.com/castastrophe)! - Leveral local workspace versioning to prevent misalignment
112+
113+
- Updated dependencies [[`d83200c`](https://github.com/adobe/spectrum-css/commit/d83200ca70a959aa70329e71de0c4383de157855)]:
114+
- @spectrum-css/progresscircle@3.1.1
115+
- @spectrum-css/icon@7.1.1
116+
117+
## 13.1.0
118+
119+
### Minor Changes
120+
121+
- [#2616](https://github.com/adobe/spectrum-css/pull/2616) [`7f45ea9`](https://github.com/adobe/spectrum-css/commit/7f45ea95d3d31addf29b0720de8623b0f3f0431d) Thanks [@castastrophe](https://github.com/castastrophe)!
122+
123+
#### Build optmizations to support minification
124+
125+
Output for all component CSS files is now being run through a lightweight optimizer (cssnano) which significantly reduces unnecessary whitespace. These changes reduce file size but should not have any impact on the rendering of the component. By removing unnecessary whitespace from var functions, we are making it easier to effectively minify our provided CSS assets.
86126

87127
<a name="13.0.0"></a>
88128

components/checkbox/index.css

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,8 +448,8 @@
448448
}
449449

450450
.spectrum-Checkbox-box {
451-
/* Fix vertical alignment when not wrapping since we're flex-start */
452451
--spectrum-checkbox-spacing: calc(var(--mod-checkbox-height, var(--spectrum-checkbox-height)) - var(--mod-checkbox-control-size, var(--spectrum-checkbox-control-size)));
452+
453453
display: flex;
454454
align-items: center;
455455
justify-content: center;
@@ -458,6 +458,8 @@
458458
box-sizing: border-box;
459459
inline-size: var(--mod-checkbox-control-size, var(--spectrum-checkbox-control-size));
460460
block-size: var(--mod-checkbox-control-size, var(--spectrum-checkbox-control-size));
461+
462+
/* Fix vertical alignment when not wrapping since we're flex-start */
461463
margin: calc(var(--mod-checkbox-spacing, var(--spectrum-checkbox-spacing)) / 2) 0;
462464

463465
flex-grow: 0;

components/picker/stories/template.js

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ export const Picker = ({
6464
id=${id}
6565
style=${styleMap(customStyles)}
6666
type="button"
67-
@click=${() => {
68-
if (window.isChromatic()) return;
67+
@click=${function() {
6968
updateArgs({ isOpen: !isOpen });
7069
}}
7170
aria-labelledby=${ifDefined(ariaLabeledBy)}
@@ -109,6 +108,7 @@ export const Template = ({
109108
size = "m",
110109
label,
111110
labelPosition = "top",
111+
placeholder,
112112
helpText,
113113
isQuiet = false,
114114
isOpen = false,
@@ -125,7 +125,7 @@ export const Template = ({
125125
// Helps ensure that Popover appears below the Picker, with side labels layout.
126126
display: "block",
127127
},
128-
content = [],
128+
popoverContent = [],
129129
} = {}, context = {}) => {
130130
const pickerMarkup = Picker({
131131
size,
@@ -134,17 +134,18 @@ export const Template = ({
134134
isInvalid,
135135
isDisabled,
136136
isLoading,
137-
content,
137+
placeholder,
138+
popoverContent,
138139
labelPosition,
139140
ariaLabeledBy: fieldLabelId,
140141
}, context);
141142

142-
const popoverMarkup = content.length !== 0 ? Popover({
143+
const popoverMarkup = popoverContent.length !== 0 ? Popover({
143144
isOpen: isOpen && !isDisabled && !isLoading,
144145
withTip: false,
145146
position: "bottom",
146147
isQuiet,
147-
content,
148+
content: popoverContent,
148149
size,
149150
customStyles: customPopoverStyles,
150151
}, context) : "";
@@ -193,12 +194,6 @@ export const Template = ({
193194
}, context)
194195
)}
195196
</div>`;
196-
197-
// Make sure there is a wrapper around sibling components when using the Chromatic
198-
// template, so their layout is not affected by the flex and grid layouts used.
199-
if (window.isChromatic()) {
200-
return html`<div style="position: relative;">${markup}</div>`;
201-
}
202197
return markup;
203198
};
204199

0 commit comments

Comments
 (0)