Skip to content

Commit e7c7382

Browse files
authored
docs: update pr request template post migrations (#2221)
Now that migrations are concluding, the part in regression testing no longer applies. I've included some additions about running VRTs.
1 parent 00254ec commit e7c7382

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
- Search for (issues)[https://github.com/adobe/spectrum-css/issues]
44
- If there's no issue, please [file it](https://github.com/adobe/spectrum-css/issues/new/choose) and tag @pfulton or @castastrophe for feedback.
55
-->
6-
76
## Description
87

98
<!-- Describe what you changed and link to relevant issue(s) (e.g., #000) -->
@@ -12,8 +11,9 @@
1211

1312
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
1413

14+
### Validation steps
1515
<!--
16-
Example test outline:
16+
Include steps for the PR reviewer that explain how they should test your PR. Example test outline:
1717
1. Open the [storybook](url) for the button component:
1818
- [ ] Hover over the button and validate the new hover background color is applied
1919
- [x] Click the button and validate the new active background color is applied [@castastrophe]
@@ -23,17 +23,14 @@ Please tag yourself on the tests you've marked complete to confirm the tests hav
2323

2424
Validate:
2525

26-
1. A legacy documentation page (such as [accordion](https://pr-###--spectrum-css.netlify.app/accordion.html)), including:
26+
1. The documentation pages for at least two other components are still loading, including:
2727

28-
- [ ] The page renders correctly
29-
- [ ] The page is accessible
30-
- [ ] The page is responsive
28+
- [ ] The pages render correctly, are accessible, and are responsive.
3129

32-
2. A migrated documentation page (such as [action group](https://pr-###--spectrum-css.netlify.app/actiongroup.html)), including:
30+
2. If components have been modified, VRTs have been run on this branch:
3331

34-
- [ ] The page renders correctly
35-
- [ ] The page is accessible
36-
- [ ] The page is responsive
32+
- [ ] VRTs have been run and looked at.
33+
- [ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.
3734

3835
## Screenshots
3936

@@ -46,8 +43,6 @@ Validate:
4643
- [ ] I have read the [contribution guidelines](/.github/CONTRIBUTING.md).
4744
- [ ] I have updated relevant storybook stories and templates.
4845
- [ ] I have tested these changes in Windows High Contrast mode.
49-
5046
- [ ] If my change impacts **other components**, I have tested to make sure they don't break.
5147
- [ ] If my change impacts **documentation**, I have updated the documentation accordingly.
52-
5348
- [ ] ✨ This pull request is ready to merge. ✨

0 commit comments

Comments
 (0)