3
3
- Search for (issues)[https://github.com/adobe/spectrum-css/issues]
4
4
- If there's no issue, please [file it](https://github.com/adobe/spectrum-css/issues/new/choose) and tag @pfulton or @castastrophe for feedback.
5
5
-->
6
-
7
6
## Description
8
7
9
8
<!-- Describe what you changed and link to relevant issue(s) (e.g., #000) -->
12
11
13
12
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
14
13
14
+ ### Validation steps
15
15
<!--
16
- Example test outline:
16
+ Include steps for the PR reviewer that explain how they should test your PR. Example test outline:
17
17
1. Open the [storybook](url) for the button component:
18
18
- [ ] Hover over the button and validate the new hover background color is applied
19
19
- [x] Click the button and validate the new active background color is applied [@castastrophe]
@@ -23,17 +23,14 @@ Please tag yourself on the tests you've marked complete to confirm the tests hav
23
23
24
24
Validate:
25
25
26
- 1 . A legacy documentation page (such as [ accordion ] ( https://pr-###--spectrum-css.netlify.app/accordion.html ) ) , including:
26
+ 1 . The documentation pages for at least two other components are still loading , including:
27
27
28
- - [ ] The page renders correctly
29
- - [ ] The page is accessible
30
- - [ ] The page is responsive
28
+ - [ ] The pages render correctly, are accessible, and are responsive.
31
29
32
- 2 . A migrated documentation page (such as [ action group ] ( https://pr-###--spectrum-css.netlify.app/actiongroup.html ) ), including :
30
+ 2 . If components have been modified, VRTs have been run on this branch :
33
31
34
- - [ ] The page renders correctly
35
- - [ ] The page is accessible
36
- - [ ] The page is responsive
32
+ - [ ] VRTs have been run and looked at.
33
+ - [ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.
37
34
38
35
## Screenshots
39
36
@@ -46,8 +43,6 @@ Validate:
46
43
- [ ] I have read the [ contribution guidelines] ( /.github/CONTRIBUTING.md ) .
47
44
- [ ] I have updated relevant storybook stories and templates.
48
45
- [ ] I have tested these changes in Windows High Contrast mode.
49
-
50
46
- [ ] If my change impacts ** other components** , I have tested to make sure they don't break.
51
47
- [ ] If my change impacts ** documentation** , I have updated the documentation accordingly.
52
-
53
48
- [ ] ✨ This pull request is ready to merge. ✨
0 commit comments