fix(a11y-testing-spike): move playwright a11y config to root

Author: cdransf

1st-gen/package.json

@@ -96,7 +96,6 @@
         "@lit/react": "1.0.8",
         "@open-wc/dev-server-hmr": "0.2.0",
         "@open-wc/testing": "4.0.0",
-        "@playwright/test": "1.53.1",
         "@rollup/plugin-commonjs": "25.0.8",
         "@rollup/plugin-json": "6.1.0",
         "@rollup/plugin-node-resolve": "15.3.1",

1st-gen/test/a11y-helpers.ts

@@ -84,7 +84,9 @@ export async function gotoStory(
     elementSelector: string
 ): Promise<Locator> {
     // Navigate to story (baseURL is set by Playwright project config)
-    await page.goto(`/iframe.html?id=${storyId}&viewMode=story`);
+    await page.goto(`/iframe.html?id=${storyId}&viewMode=story`, {
+        waitUntil: 'domcontentloaded',
+    });
 
     // Wait for story to be ready
     return waitForStoryReady(page, elementSelector);

2nd-gen/package.json

@@ -25,18 +25,16 @@
         "storybook": "yarn workspace @adobe/swc storybook",
         "storybook:build": "yarn workspace @adobe/swc storybook:build",
         "test": "yarn workspace @adobe/swc test",
-        "test:a11y": "playwright test --config=playwright.a11y.config.ts",
-        "test:a11y:1st": "playwright test --config=playwright.a11y.config.ts --project=1st-gen",
-        "test:a11y:2nd": "playwright test --config=playwright.a11y.config.ts --project=2nd-gen",
+        "test:a11y": "playwright test --config=../playwright.a11y.config.ts",
+        "test:a11y:1st": "playwright test --config=../playwright.a11y.config.ts --project=1st-gen",
+        "test:a11y:2nd": "playwright test --config=../playwright.a11y.config.ts --project=2nd-gen",
         "test:a11y:report": "playwright show-report test/playwright-a11y/report",
-        "test:a11y:ui": "playwright test --config=playwright.a11y.config.ts --ui"
+        "test:a11y:ui": "playwright test --config=../playwright.a11y.config.ts --ui"
     },
     "workspaces": [
         "packages/*"
     ],
     "devDependencies": {
-        "@axe-core/playwright": "4.11.0",
-        "@playwright/test": "1.53.1",
         "eslint": "8.57.1",
         "eslint-plugin-simple-import-sort": "12.1.1",
         "npm-run-all2": "8.0.4"

2nd-gen/packages/swc/utils/a11y-helpers.ts

@@ -84,7 +84,9 @@ export async function gotoStory(
     elementSelector: string
 ): Promise<Locator> {
     // Navigate to story (baseURL is set by Playwright project config)
-    await page.goto(`/iframe.html?id=${storyId}&viewMode=story`);
+    await page.goto(`/iframe.html?id=${storyId}&viewMode=story`, {
+        waitUntil: 'domcontentloaded',
+    });
 
     // Wait for story to be ready
     return waitForStoryReady(page, elementSelector);

CONTRIBUTOR-DOCS/01_contributor-guides/09_accessibility-testing.md

@@ -384,7 +384,7 @@ Received: [
 
 ### Playwright config
 
-`2nd-gen/playwright.a11y.config.ts` defines two projects:
+`playwright.a11y.config.ts` (at the root) defines two projects:
 
 ```typescript
 projects: [
@@ -426,11 +426,12 @@ webServer: [
 
 ```
 spectrum-web-components/
+├── playwright.a11y.config.ts              # Playwright config (both gens)
 ├── CONTRIBUTOR-DOCS/
 │   └── 01_contributor-guides/
 │       └── 09_accessibility-testing.md    # This guide
 ├── 1st-gen/
-│   ├── package.json                       # Test scripts (points to 2nd-gen config)
+│   ├── package.json                       # Test scripts (points to root config)
 │   ├── test/
 │   │   └── a11y-helpers.ts                # 1st gen test helpers
 │   └── packages/
@@ -441,8 +442,7 @@ spectrum-web-components/
 │           ├── status-light.a11y.spec.ts
 │           └── status-light.a11y.spec.ts-snapshots/
 └── 2nd-gen/
-    ├── playwright.a11y.config.ts          # Playwright config (both gens)
-    ├── package.json                       # Test scripts
+    ├── package.json                       # Test scripts (points to root config)
     └── packages/swc/
         ├── utils/
         │   └── a11y-helpers.ts            # 2nd gen test helpers

package.json

@@ -27,11 +27,11 @@
         "start:1st-gen": "yarn workspace @spectrum-web-components/1st-gen start",
         "start:2nd-gen": "yarn workspace @spectrum-web-components/2nd-gen start",
         "test": "run-p test:2nd-gen test:1st-gen",
-        "test:a11y": "playwright test --config=../2nd-gen/playwright.a11y.config.ts",
-        "test:a11y:ui": "playwright test --config=../2nd-gen/playwright.a11y.config.ts --ui",
-        "test:a11y:1st": "playwright test --config=../2nd-gen/playwright.a11y.config.ts --project=1st-gen",
-        "test:a11y:2nd": "playwright test --config=../2nd-gen/playwright.a11y.config.ts --project=2nd-gen",
-        "test:a11y:report": "playwright show-report ../2nd-gen/test/playwright-a11y/report",
+        "test:a11y": "playwright test --config=playwright.a11y.config.ts",
+        "test:a11y:ui": "playwright test --config=playwright.a11y.config.ts --ui",
+        "test:a11y:1st": "playwright test --config=playwright.a11y.config.ts --project=1st-gen",
+        "test:a11y:2nd": "playwright test --config=playwright.a11y.config.ts --project=2nd-gen",
+        "test:a11y:report": "playwright show-report 2nd-gen/test/playwright-a11y/report",
         "test:1st-gen": "yarn workspace @spectrum-web-components/1st-gen test",
         "test:2nd-gen": "yarn workspace @spectrum-web-components/2nd-gen test"
     },
@@ -47,9 +47,11 @@
         "playwright": "1.53.1"
     },
     "devDependencies": {
+        "@axe-core/playwright": "4.11.0",
         "@changesets/cli": "2.29.7",
         "@commitlint/cli": "19.8.1",
         "@commitlint/config-conventional": "19.8.1",
+        "@playwright/test": "1.53.1",
         "genversion": "3.2.0",
         "husky": "9.1.7",
         "lint-staged": "16.2.6",

2nd-gen/playwright.a11y.config.ts playwright.a11y.config.ts2nd-gen/playwright.a11y.config.ts renamed to playwright.a11y.config.ts

@@ -19,7 +19,7 @@ const config: PlaywrightTestConfig = {
     forbidOnly: !!process.env.CI,
     retries: process.env.CI ? 2 : 0,
     reporter: [
-        ['html', { outputFolder: 'test/playwright-a11y/report' }],
+        ['html', { outputFolder: '2nd-gen/test/playwright-a11y/report' }],
         ['list'],
     ],
 
@@ -32,7 +32,7 @@ const config: PlaywrightTestConfig = {
     projects: [
         {
             name: '1st-gen',
-            testDir: '../1st-gen/',
+            testDir: './1st-gen/',
             testMatch: '**/packages/*/test/**/*.a11y.spec.ts',
             use: {
                 ...devices['Desktop Chrome'],
@@ -41,7 +41,7 @@ const config: PlaywrightTestConfig = {
         },
         {
             name: '2nd-gen',
-            testDir: './',
+            testDir: './2nd-gen/',
             testMatch: '**/packages/swc/components/*/test/**/*.a11y.spec.ts',
             use: {
                 ...devices['Desktop Chrome'],
@@ -52,13 +52,13 @@ const config: PlaywrightTestConfig = {
 
     webServer: [
         {
-            command: 'cd ../1st-gen && yarn storybook',
+            command: 'cd 1st-gen && yarn storybook',
             port: 8080,
             reuseExistingServer: !process.env.CI,
             timeout: 120 * 1000,
         },
         {
-            command: 'cd packages/swc && yarn storybook',
+            command: 'cd 2nd-gen/packages/swc && yarn storybook',
             port: 6006,
             reuseExistingServer: !process.env.CI,
             timeout: 120 * 1000,

yarn.lock

@@ -5323,7 +5323,6 @@ __metadata:
     "@lit/react": "npm:1.0.8"
     "@open-wc/dev-server-hmr": "npm:0.2.0"
     "@open-wc/testing": "npm:4.0.0"
-    "@playwright/test": "npm:1.53.1"
     "@rollup/plugin-commonjs": "npm:25.0.8"
     "@rollup/plugin-json": "npm:6.1.0"
     "@rollup/plugin-node-resolve": "npm:15.3.1"
@@ -5430,8 +5429,6 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@spectrum-web-components/2nd-gen@workspace:2nd-gen"
   dependencies:
-    "@axe-core/playwright": "npm:4.11.0"
-    "@playwright/test": "npm:1.53.1"
     eslint: "npm:8.57.1"
     eslint-plugin-simple-import-sort: "npm:12.1.1"
     npm-run-all2: "npm:8.0.4"
@@ -27167,9 +27164,11 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "root-workspace-0b6124@workspace:."
   dependencies:
+    "@axe-core/playwright": "npm:4.11.0"
     "@changesets/cli": "npm:2.29.7"
     "@commitlint/cli": "npm:19.8.1"
     "@commitlint/config-conventional": "npm:19.8.1"
+    "@playwright/test": "npm:1.53.1"
     genversion: "npm:3.2.0"
     husky: "npm:9.1.7"
     lint-staged: "npm:16.2.6"