Skip to content

Commit a43a7c7

Browse files
committed
chore: apply code review feedback
1 parent 113b4fc commit a43a7c7

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,10 @@ name: Build
33
# This workflow validates that the commit in question can be built successfully
44
# in several environments:
55
#
6-
# Systems: Ubuntu, MacOS, Windows
7-
# Node: 20
8-
#
9-
# After the build is successful, the compiled assets are uploaded as an artifact
10-
# to the workflow run. This allows us to download the compiled assets and use
11-
# them in other workflows.
12-
#
13-
# Note: we need to skip the nx cache b/c it does not contain the compiled assets
6+
# Systems: Ubuntu, MacOS, Windows (default: macos-latest)
7+
# Node versions: 20 (default)
8+
# Experimental: true/false (default: false)
9+
# Ref: The branch or tag to checkout (default: github.head_ref)
1410
#
1511

1612
on:
@@ -85,13 +81,11 @@ jobs:
8581
node-version: ${{ matrix.node-version }}
8682

8783
- name: Build the project
88-
if: always()
8984
run: yarn build
9085

9186
# This step will evaluate the repo status and report the change
9287
# If there are changes, capture the changes and upload them as an artifact
9388
- name: Check if there are changes
94-
if: always()
9589
run: |
9690
if [[ -z $(git status --porcelain) ]]; then
9791
echo "No changes detected"

.github/workflows/coveralls.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ jobs:
1414
steps:
1515
- name: Checkout PR branch
1616
uses: actions/checkout@v4
17-
with:
18-
fetch-depth: 0
1917

2018
- name: Setup Job and Install Dependencies
2119
uses: ./.github/actions/setup-job

0 commit comments

Comments
 (0)