From 5513db19f98f05ce18534d079a577efbc90fc0ba Mon Sep 17 00:00:00 2001 From: SaaSha Pina Date: Thu, 26 Jun 2025 09:57:41 -0400 Subject: [PATCH 1/2] fix: unintended typography element margins --- tools/styles/src/spectrum-detail.css | 2 -- tools/styles/src/spectrum-heading.css | 2 -- 2 files changed, 4 deletions(-) diff --git a/tools/styles/src/spectrum-detail.css b/tools/styles/src/spectrum-detail.css index 95f8165315a..c2463708d0c 100644 --- a/tools/styles/src/spectrum-detail.css +++ b/tools/styles/src/spectrum-detail.css @@ -42,8 +42,6 @@ --spectrum-detail-sans-serif-font-family: var(--spectrum-sans-font-family-stack); --spectrum-detail-serif-font-family: var(--spectrum-serif-font-family-stack); --spectrum-detail-cjk-font-family: var(--spectrum-cjk-font-family-stack); - --spectrum-detail-margin-start: calc(var(--mod-detail-font-size, var(--spectrum-detail-font-size)) * var(--spectrum-detail-margin-top-multiplier)); - --spectrum-detail-margin-end: calc(var(--mod-detail-font-size, var(--spectrum-detail-font-size)) * var(--spectrum-detail-margin-bottom-multiplier)); --spectrum-detail-font-color: var(--spectrum-detail-color); font-family: var(--mod-detail-sans-serif-font-family, var(--spectrum-detail-sans-serif-font-family)); font-style: var(--mod-detail-sans-serif-font-style, var(--spectrum-detail-sans-serif-font-style)); diff --git a/tools/styles/src/spectrum-heading.css b/tools/styles/src/spectrum-heading.css index 358df7740c3..c412b6107fc 100644 --- a/tools/styles/src/spectrum-heading.css +++ b/tools/styles/src/spectrum-heading.css @@ -68,8 +68,6 @@ --spectrum-heading-cjk-font-family: var(--spectrum-cjk-font-family-stack); --spectrum-heading-cjk-letter-spacing: var(--spectrum-cjk-letter-spacing); --spectrum-heading-font-color: var(--spectrum-heading-color); - --spectrum-heading-margin-start: calc(var(--mod-heading-font-size, var(--spectrum-heading-font-size)) * var(--spectrum-heading-margin-top-multiplier)); - --spectrum-heading-margin-end: calc(var(--mod-heading-font-size, var(--spectrum-heading-font-size)) * var(--spectrum-heading-margin-bottom-multiplier)); font-family: var(--mod-heading-sans-serif-font-family, var(--spectrum-heading-sans-serif-font-family)); font-style: var(--mod-heading-sans-serif-font-style, var(--spectrum-heading-sans-serif-font-style)); font-weight: var(--mod-heading-sans-serif-font-weight, var(--spectrum-heading-sans-serif-font-weight)); From 42776a65498c4a95622df4523edcd53b7f67a248 Mon Sep 17 00:00:00 2001 From: SaaSha Pina Date: Mon, 7 Jul 2025 00:45:25 -0400 Subject: [PATCH 2/2] chore: remove margin definitions from all heading/detail classes --- tools/styles/fonts.css | 4 ---- tools/styles/typography.css | 4 ---- 2 files changed, 8 deletions(-) diff --git a/tools/styles/fonts.css b/tools/styles/fonts.css index 22270fbe70b..a7322d5e8ef 100755 --- a/tools/styles/fonts.css +++ b/tools/styles/fonts.css @@ -73,8 +73,6 @@ --spectrum-heading-cjk-font-family: var(--spectrum-cjk-font-family-stack); --spectrum-heading-cjk-letter-spacing: var(--spectrum-cjk-letter-spacing); --spectrum-heading-font-color: var(--spectrum-heading-color); - --spectrum-heading-margin-start: calc(var(--mod-heading-font-size, var(--spectrum-heading-font-size)) * var(--spectrum-heading-margin-top-multiplier)); - --spectrum-heading-margin-end: calc(var(--mod-heading-font-size, var(--spectrum-heading-font-size)) * var(--spectrum-heading-margin-bottom-multiplier)); font-family: var(--mod-heading-sans-serif-font-family, var(--spectrum-heading-sans-serif-font-family)); font-style: var(--mod-heading-sans-serif-font-style, var(--spectrum-heading-sans-serif-font-style)); font-weight: var(--mod-heading-sans-serif-font-weight, var(--spectrum-heading-sans-serif-font-weight)); @@ -502,8 +500,6 @@ --spectrum-detail-sans-serif-font-family: var(--spectrum-sans-font-family-stack); --spectrum-detail-serif-font-family: var(--spectrum-serif-font-family-stack); --spectrum-detail-cjk-font-family: var(--spectrum-cjk-font-family-stack); - --spectrum-detail-margin-start: calc(var(--mod-detail-font-size, var(--spectrum-detail-font-size)) * var(--spectrum-detail-margin-top-multiplier)); - --spectrum-detail-margin-end: calc(var(--mod-detail-font-size, var(--spectrum-detail-font-size)) * var(--spectrum-detail-margin-bottom-multiplier)); --spectrum-detail-font-color: var(--spectrum-detail-color); font-family: var(--mod-detail-sans-serif-font-family, var(--spectrum-detail-sans-serif-font-family)); font-style: var(--mod-detail-sans-serif-font-style, var(--spectrum-detail-sans-serif-font-style)); diff --git a/tools/styles/typography.css b/tools/styles/typography.css index 22270fbe70b..a7322d5e8ef 100644 --- a/tools/styles/typography.css +++ b/tools/styles/typography.css @@ -73,8 +73,6 @@ --spectrum-heading-cjk-font-family: var(--spectrum-cjk-font-family-stack); --spectrum-heading-cjk-letter-spacing: var(--spectrum-cjk-letter-spacing); --spectrum-heading-font-color: var(--spectrum-heading-color); - --spectrum-heading-margin-start: calc(var(--mod-heading-font-size, var(--spectrum-heading-font-size)) * var(--spectrum-heading-margin-top-multiplier)); - --spectrum-heading-margin-end: calc(var(--mod-heading-font-size, var(--spectrum-heading-font-size)) * var(--spectrum-heading-margin-bottom-multiplier)); font-family: var(--mod-heading-sans-serif-font-family, var(--spectrum-heading-sans-serif-font-family)); font-style: var(--mod-heading-sans-serif-font-style, var(--spectrum-heading-sans-serif-font-style)); font-weight: var(--mod-heading-sans-serif-font-weight, var(--spectrum-heading-sans-serif-font-weight)); @@ -502,8 +500,6 @@ --spectrum-detail-sans-serif-font-family: var(--spectrum-sans-font-family-stack); --spectrum-detail-serif-font-family: var(--spectrum-serif-font-family-stack); --spectrum-detail-cjk-font-family: var(--spectrum-cjk-font-family-stack); - --spectrum-detail-margin-start: calc(var(--mod-detail-font-size, var(--spectrum-detail-font-size)) * var(--spectrum-detail-margin-top-multiplier)); - --spectrum-detail-margin-end: calc(var(--mod-detail-font-size, var(--spectrum-detail-font-size)) * var(--spectrum-detail-margin-bottom-multiplier)); --spectrum-detail-font-color: var(--spectrum-detail-color); font-family: var(--mod-detail-sans-serif-font-family, var(--spectrum-detail-sans-serif-font-family)); font-style: var(--mod-detail-sans-serif-font-style, var(--spectrum-detail-sans-serif-font-style));